Elgato_dark/console
1
0
Fork 0
mirror of https://github.com/graphql-hive/console synced 2026-05-22 08:38:27 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Extra read from KV storage (#1185)

Browse source
This commit is contained in:
Kamil Kisiela 2023-01-30 18:32:07 +01:00 committed by GitHub
parent 44dce72489
commit 19d79bea3b
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 19 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
packages/services/cdn-worker/src/handler.ts
View file

@ -193,7 +193,12 @@ export const createRequestHandler = (deps: RequestHandlerDependencies) => {
analytics.track({ type: 'artifact', value: artifactType, version: 'v0' }, targetId);
const kvStorageKey = `target:${targetId}:${storageKeyType}`;
const rawValue = await deps.getRawStoreValue(kvStorageKey);
const rawValue = await deps.getRawStoreValue(kvStorageKey).catch(() => {
// Do an extra attempt to read the value from the store.
// If we see that a single retry does not help, we should do a proper retry logic here.
// Why not now? Because we do have a new implementation that is based on R2 storage and this change is simple enough.
return deps.getRawStoreValue(kvStorageKey);
});
if (rawValue) {
const etag = await createETag(`${kvStorageKey}|${rawValue}`);

26
packages/services/cdn-worker/tests/cdn.spec.ts
View file

@ -46,7 +46,7 @@ describe('CDN Worker', () => {
},
},
}),
getRawStoreValue: (key: string) => map.get(key),
getRawStoreValue: async (key: string) => map.get(key),
});
const schemaRequest = new Request(`https://fake-worker.com/${targetId}/schema`, {
@ -92,7 +92,7 @@ describe('CDN Worker', () => {
},
},
}),
getRawStoreValue: (key: string) => map.get(key),
getRawStoreValue: async (key: string) => map.get(key),
});
const token = createToken(SECRET, targetId);
@ -160,7 +160,7 @@ describe('CDN Worker', () => {
},
},
}),
getRawStoreValue: (key: string) => map.get(key),
getRawStoreValue: async (key: string) => map.get(key),
});
const firstRequest = new Request(`https://fake-worker.com/${targetId}/supergraph`, {
@ -221,7 +221,7 @@ describe('CDN Worker', () => {
},
},
}),
getRawStoreValue: (key: string) => map.get(key),
getRawStoreValue: async (key: string) => map.get(key),
});
const token = createToken(SECRET, targetId);
@ -284,7 +284,7 @@ describe('CDN Worker', () => {
},
},
}),
getRawStoreValue: (key: string) => map.get(key),
getRawStoreValue: async (key: string) => map.get(key),
});
const token = createToken(SECRET, targetId);
@ -352,7 +352,7 @@ describe('CDN Worker', () => {
},
},
}),
getRawStoreValue: (key: string) => map.get(key),
getRawStoreValue: async (key: string) => map.get(key),
});
const token = createToken(SECRET, targetId);
@ -397,7 +397,7 @@ describe('CDN Worker', () => {
it('Should throw when target id is missing', async () => {
const handleRequest = createRequestHandler({
isKeyValid: KeyValidators.AlwaysTrue,
getRawStoreValue: (_key: string) => Promise.resolve(null),
getRawStoreValue: async (_key: string) => Promise.resolve(null),
});
const request = new Request('https://fake-worker.com/', {});
@ -410,7 +410,7 @@ describe('CDN Worker', () => {
it('Should throw when requested resource is not valid', async () => {
const handleRequest = createRequestHandler({
isKeyValid: KeyValidators.AlwaysTrue,
getRawStoreValue: (_key: string) => Promise.resolve(null),
getRawStoreValue: async (_key: string) => Promise.resolve(null),
});
const request = new Request('https://fake-worker.com/fake-target-id/error', {});
@ -423,7 +423,7 @@ describe('CDN Worker', () => {
it('Should throw when auth key is missing', async () => {
const handleRequest = createRequestHandler({
isKeyValid: KeyValidators.AlwaysTrue,
getRawStoreValue: (_key: string) => Promise.resolve(null),
getRawStoreValue: async (_key: string) => Promise.resolve(null),
});
const request = new Request('https://fake-worker.com/fake-target-id/sdl', {});
@ -436,7 +436,7 @@ describe('CDN Worker', () => {
it('Should throw when key validation function fails', async () => {
const handleRequest = createRequestHandler({
isKeyValid: KeyValidators.AlwaysFalse,
getRawStoreValue: (_key: string) => Promise.resolve(null),
getRawStoreValue: async (_key: string) => Promise.resolve(null),
});
const request = new Request('https://fake-worker.com/fake-target-id/sdl', {
@ -474,7 +474,7 @@ describe('CDN Worker', () => {
},
},
}),
getRawStoreValue: (key: string) => map.get(key),
getRawStoreValue: async (key: string) => map.get(key),
});
const token = createToken(SECRET, targetId);
@ -509,7 +509,7 @@ describe('CDN Worker', () => {
},
},
}),
getRawStoreValue: (key: string) => map.get(key),
getRawStoreValue: async (key: string) => map.get(key),
});
const token = createToken(SECRET, 'fake-target-id');
@ -542,7 +542,7 @@ describe('CDN Worker', () => {
},
},
}),
getRawStoreValue: (key: string) => new Map().get(key),
getRawStoreValue: async (key: string) => new Map().get(key),
});
const request = new Request(`https://fake-worker.com/some-target/sdl`, {