Elgato_dark/console
1
0
Fork 0
mirror of https://github.com/graphql-hive/console synced 2026-04-21 14:37:17 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

fix integration test failing due to zero division (#7312)

Browse source
This commit is contained in:
Laurin Quast 2025-11-26 09:51:28 +01:00 committed by GitHub
parent b9092379e6
commit 12378d574f
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 18 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
packages/services/api/src/modules/schema/providers/breaking-schema-changes-helper.ts
View file

@ -36,7 +36,15 @@ export class BreakingSchemaChangeUsageHelper {
return {
topAffectedOperations: schemaChange.usageStatistics.topAffectedOperations.map(operation => {
const percentage = (operation.count / metadata.usage.totalRequestCount) * 100;
// Note:
// "metadata.usage.totalRequestCount" is sometimes 0 in case of a integration test
// causing a zero devision and GraphQL exception,
// because we aggressively poll for the schema change after publishing usage data
// it seems like clickhouse slighty lags behind for the materialized view here.
// since it only happens in context of an integration test (no production issues)
// we can safely treat 0 as 1 request.
const totalRequestCount = Math.max(1, metadata.usage.totalRequestCount);
const percentage = (operation.count / totalRequestCount) * 100;
return {
...operation,
percentage,
@ -44,7 +52,15 @@ export class BreakingSchemaChangeUsageHelper {
};
}),
topAffectedClients: schemaChange.usageStatistics.topAffectedClients.map(client => {
const percentage = (client.count / metadata.usage.totalRequestCount) * 100;
// Note:
// "metadata.usage.totalRequestCount" is sometimes 0 in case of a integration test
// causing a zero devision and GraphQL exception,
// because we aggressively poll for the schema change after publishing usage data
// it seems like clickhouse slighty lags behind for the materialized view here.
// since it only happens in context of an integration test (no production issues)
// we can safely treat 0 as 1 request.
const totalRequestCount = Math.max(1, metadata.usage.totalRequestCount);
const percentage = (client.count / totalRequestCount) * 100;
return {
...client,