From 0692c2cb3ccc65aae8b8277d49ba4b13aa992f2e Mon Sep 17 00:00:00 2001
From: Laurin Quast <laurinquast@googlemail.com>
Date: Wed, 6 Mar 2024 16:35:29 +0100
Subject: [PATCH] resolve correct target name (#4165)

---
 .../api/src/modules/schema/providers/schema-publisher.ts | 6 ++----
 .../src/components/target/history/errors-and-changes.tsx | 9 ++++++---
 2 files changed, 8 insertions(+), 7 deletions(-)

diff --git a/packages/services/api/src/modules/schema/providers/schema-publisher.ts b/packages/services/api/src/modules/schema/providers/schema-publisher.ts
index 6073c3dde..c8a6696db 100644
--- a/packages/services/api/src/modules/schema/providers/schema-publisher.ts
+++ b/packages/services/api/src/modules/schema/providers/schema-publisher.ts
@@ -254,10 +254,8 @@ export class SchemaPublisher {
             return {
               id: targetId,
               name: (
-                await this.targetManager.getTarget({
-                  organization: args.organizationId,
-                  project: args.projectId,
-                  target: args.targetId,
+                await this.targetManager.getTargetById({
+                  targetId: targetId,
                 })
               ).name,
             };
diff --git a/packages/web/app/src/components/target/history/errors-and-changes.tsx b/packages/web/app/src/components/target/history/errors-and-changes.tsx
index f30193ea3..c9109f12f 100644
--- a/packages/web/app/src/components/target/history/errors-and-changes.tsx
+++ b/packages/web/app/src/components/target/history/errors-and-changes.tsx
@@ -254,11 +254,14 @@ function ChangeItem(props: {
                             {target.name}
                           </Link>
                         )}
-                        {index === arr.length - 1 ? null : index === arr.length - 2 ? 'and' : ','}
+                        {index === arr.length - 1
+                          ? null
+                          : index === arr.length - 2
+                            ? ' and '
+                            : ', '}
                       </>
                     ))}{' '}
-                    target{metadata.settings.targets.length > 1 && 's'} insights for live usage
-                    data.
+                    target insights for live usage data.
                   </span>
                 )}
               </div>