Elgato_dark/bunkerweb
1
0
Fork 0
mirror of https://github.com/bunkerity/bunkerweb synced 2026-05-24 09:28:37 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Refactor table renaming and dropping in Database.py to avoid data loss

Browse source
This commit is contained in:
Théophile Diot 2024-03-27 10:29:14 +00:00
parent 2aae0394eb
commit ead4c936e0
No known key found for this signature in database
GPG key ID: 248FEA4BAE400D06
1 changed files with 7 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
src/common/db/Database.py
View file

@ -177,7 +177,7 @@ class Database:
self.__sql_engine.dispose()
@contextmanager
def __db_session(self):
def __db_session(self, raise_error: bool = False) -> Any:
try:
assert self.__sql_engine is not None
except AssertionError:
@ -449,11 +449,15 @@ class Database:
with self.__db_session() as session:
old_data[table_name] = session.query(metadata.tables[table_name]).all()
# Drop all missing tables
# Rename the old tables
db_version_id = db_version.replace(".", "_")
for table_name in metadata.tables.keys():
if table_name not in Base.metadata.tables:
with self.__db_session() as session:
session.execute(text(f"DROP TABLE {table_name}"))
if inspector.has_table(f"{table_name}_{db_version_id}"):
self.logger.warning(f'Table "{table_name}" already exists, dropping it to make room for the new one')
session.execute(text(f"DROP TABLE {table_name}_{db_version_id}"))
session.execute(text(f"ALTER TABLE {table_name} RENAME TO {table_name}_{db_version_id}"))
Base.metadata.drop_all(self.__sql_engine)