Elgato_dark/bunkerweb
1
0
Fork 0
mirror of https://github.com/bunkerity/bunkerweb synced 2026-05-24 09:28:37 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Refactor plugin page rendering to handle old templates gracefully

Browse source
This commit is contained in:
Théophile Diot 2024-10-25 10:04:12 +02:00
parent 788ccb1d3a
commit 196c1a458a
No known key found for this signature in database
GPG key ID: FA995104A0BA376A
1 changed files with 22 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

34
src/ui/app/routes/plugins.py
View file

@ -550,19 +550,29 @@ def custom_plugin_page(plugin: str):
pre_render = run_action(plugin, "pre_render", tmp_dir=tmp_page_dir)
if tmp_page_dir.joinpath("template.html").is_file():
try:
plugin_page = (
# deepcode ignore Ssti: We trust the plugin template
Environment(
loader=FileSystemLoader((tmp_page_dir.as_posix() + "/", join(sep, "usr", "share", "bunkerweb", "ui", "templates") + "/")),
autoescape=select_autoescape(["html"]),
page_content = tmp_page_dir.joinpath("template.html").read_text(encoding="utf-8")
if page_content.startswith('{% extends "base.html" %}'):
page_content = """<div class="d-flex align-items-center justify-content-center">
<div class="text-center text-primary">
<p class="text-center relative w-full p-2 text-primary rounded-lg fw-bold">
Plugin page uses old template, therefore it will not be displayed correctly. Please update it to the new format.
</p>
</div>
</div>"""
else:
try:
plugin_page = (
# deepcode ignore Ssti: We trust the plugin template
Environment(
loader=FileSystemLoader((tmp_page_dir.as_posix() + "/", join(sep, "usr", "share", "bunkerweb", "ui", "templates") + "/")),
autoescape=select_autoescape(["html"]),
)
.from_string(page_content)
.render(pre_render=pre_render, **current_app.jinja_env.globals)
)
.from_string(tmp_page_dir.joinpath("template.html").read_text(encoding="utf-8"))
.render(pre_render=pre_render, **current_app.jinja_env.globals)
)
except BaseException as e:
LOGGER.exception("An error occurred while rendering the plugin page")
plugin_page = f'<div class="mt-2 mb-2 alert alert-danger text-center" role="alert">An error occurred while rendering the plugin page: {e}<br/>See logs for more details</div>'
except BaseException as e:
LOGGER.exception("An error occurred while rendering the plugin page")
plugin_page = f'<div class="mt-2 mb-2 alert alert-danger text-center" role="alert">An error occurred while rendering the plugin page: {e}<br/>See logs for more details</div>'
return render_template(
"plugin_page.html",