mirror of
https://github.com/argoproj/argo-cd
synced 2026-04-22 01:17:16 +00:00
9476ab5e18
* feat: add first class support to access repositories using proxy Currently, users need to set the proxy URLs as env variables in the repo server. This is not user-friendly and also error-prone. This PR adds support to maintain proxy URLs along with repository configs in the argocd-cm. Argo CD uses this proxy to access your repository. In case the custom proxy is absent, it defaults to reading the proxy from the env variables. Signed-off-by: Chetan Banavikalmutt <chetanrns1997@gmail.com> * set both http & https proxy variables Signed-off-by: Chetan Banavikalmutt <chetanrns1997@gmail.com>
44 lines
1.3 KiB
Go
44 lines
1.3 KiB
Go
package proxy
|
|
|
|
import (
|
|
"net/http/httptest"
|
|
"os"
|
|
"os/exec"
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
func TestAddProxyEnvIfAbsent(t *testing.T) {
|
|
t.Run("Existing proxy env variables", func(t *testing.T) {
|
|
proxy := "https://proxy:5000"
|
|
cmd := exec.Command("test")
|
|
cmd.Env = []string{`http_proxy="https_proxy=https://env-proxy:8888"`, "key=val"}
|
|
got := UpsertEnv(cmd, proxy)
|
|
assert.EqualValues(t, []string{"key=val", httpProxy(proxy), httpsProxy(proxy)}, got)
|
|
})
|
|
t.Run("proxy env variables not found", func(t *testing.T) {
|
|
proxy := "http://proxy:5000"
|
|
cmd := exec.Command("test")
|
|
cmd.Env = []string{"key=val"}
|
|
got := UpsertEnv(cmd, proxy)
|
|
assert.EqualValues(t, []string{"key=val", httpProxy(proxy), httpsProxy(proxy)}, got)
|
|
})
|
|
}
|
|
|
|
func TestGetCallBack(t *testing.T) {
|
|
t.Run("custom proxy present", func(t *testing.T) {
|
|
proxy := "http://proxy:8888"
|
|
url, err := GetCallback(proxy)(nil)
|
|
assert.Nil(t, err)
|
|
assert.Equal(t, proxy, url.String())
|
|
})
|
|
t.Run("custom proxy absent", func(t *testing.T) {
|
|
proxyEnv := "http://proxy:8888"
|
|
os.Setenv("http_proxy", "http://proxy:8888")
|
|
defer os.Unsetenv("http_proxy")
|
|
url, err := GetCallback("")(httptest.NewRequest("GET", proxyEnv, nil))
|
|
assert.Nil(t, err)
|
|
assert.Equal(t, proxyEnv, url.String())
|
|
})
|
|
}
|