argo-cd/hack
jannfis be718e2b61
feat: GPG commit signature verification (#2492) (#3242)
* Add initial primitives and tests for GPG related operations

* More tests and test documentation

* Move gpg primitives to own module

* Add initial primitives for running git verify-commit and tests

* Improve and better comment test

* Implement VerifyCommitSignature() primitive for metrics wrapper

* More commentary

* Make reposerver verify gpg signatures when generating manifests

* Make signature validation optional

* Forbid use of local manifests when signature verification is enabled

* Introduce new signatureKeys field in project CRD

* Initial support for only syncing against signed revisions

* Updates to GnuPG primitives and more test cases

* Move signature verification to correct place and add tests

* Add signature verification result to revision metadata and display it in UI

* Add more primitives and move out some stuff to common module

* Add more testdata

* Add key management primitives to ArgoDB

* Move type GnuPGPublicKey to appsv1 package

* Add const ArgoCDGPGKeysConfigMapName

* Handle key operations with appsv1.GnuPGPublicKey

* Add initial API for managing GPG keys

* Remove deprecated code

* Add primitives for adding public keys to configuration

* Change semantics of ValidateGPGKeys to return more key information

* Add key import functionality to public key API

* Fix code quirks reported by linter

* More code quirks fixes

* Fix test

* Add primitives for deleting keys from configuration

* Add delete key operation to API and CLI

* Cosmetics

* Implement logic to sync configuration to keyring in repo-server

* Add IsGPGEnabled() primitive and also update trustdb on ownertrust changes

* Use gpg.IsGPGEnabled() instead of custom test

* Remove all keyring manipulating methods from DB

* Cosmetics/comments

* Require grpc methods from argoproj pkg

* Enable setting config path via ARGOCD_GPG_DATA_PATH

* Allow "no" and any cases in ARGOCD_GPG_ENABLED

* Enable GPG feature on start and start-e2e and set required environment

* Cosmetics/comments

* Cosmetics and commentary

* Update API documentation

* Fix comment

* Only run GPG related operations if GPG is enabled

* Allow setting ARGOCD_GPG_ENABLE from the environment

* Create GPG ConfigMap resource during installation

* Use function instead of constant to get the watcher path

* Re-watch source path in case it gets recreated. Also, error on finish

* Add End-to-End tests for GPG commit verification

* Introduce SignatureKey type for AppProject CRD

* Fix merge error from previous commit

* Adapt test for additional manifest (argocd-gpg-keys-cm.yaml)

* Fix linter issues

* Adapt CircleCI configuration to enable running tests

* Add wrapper scripts for git and gpg

* Sigh.

* Display gpg version in CircleCI

* Install gnupg2 and link it to gpg in CI

* Try to install gnupg2 in CircleCI image

* More CircleCI tweaks

* # This is a combination of 10 commits.
# This is the 1st commit message:

Containerize tests - test cycle

# This is the commit message #2:

adapt working directory

# This is the commit message #3:

Build before running tests (so we might have a cache)

# This is the commit message #4:

Test limiting parallelism

# This is the commit message #5:

Remove unbound variable

# This is the commit message #6:

Decrease parallelism to find out limit

# This is the commit message #7:

Use correct flag

# This is the commit message #8:

Update Docker image

# This is the commit message #9:

Remove build phase and increase parallelism

# This is the commit message #10:

Further increase parallelism

* Dockerize toolchain

* Add new targets to Makefile

* Codegen

* Properly handle permissions for E2E tests

* Remove gnupg2 installation from CircleCI configuration

* Limit parallelism of build

* Fix Yarn lint

* Retrigger CI for possible flaky test

* Codegen

* Remove duplicate target in Makefile

* Pull in pager from dep ensure -v

* Adapt to gitops-engine changes and codegen

* Use new health package for health status constants

* Add GPG methods to ArgoDB mock module

* Fix possible nil pointer dereference

* Fix linter issue in imports

* Introduce RBAC resource type 'gpgkeys' and adapt policies

* Use ARGOCD_GNUPGHOME instead of GNUPGHOME for subsystem configuration

Also remove some deprecated unit tests.

* Also register GPG keys API with gRPC-GW

* Update from codegen

* Update GPG key API

* Add web UI to manage GPG keys

* Lint updates

* Change wording

* Add some plausibility checks for supplied data on key creation

* Update from codegen

* Re-allow binary keys and move check for ASCII armoured to UI

* Make yarn lint happy

* Add editing signature keys for projects in UI

* Add ability to configure signature keys for project in CLI

* Change default value to use for GNUPGHOME

* Do not include data section in default gpg keys CM

* Adapt Docker image for GnuPG feature

* Add required configuration to installation manifests

* Add add-signature-key and remove-signature-key commands to project CLI

* Fix typo

* Add initial user documentation for GnuPG verification

* Fix role name - oops

* Mention required RBAC roles in docs

* Support GPG verification of git annotated tags as well

* Ensure CLI can build succesfully

* Better support verification on tags

* Print key type in upper case

* Update user documentation

* Correctly disable GnuPG verification if ARGOCD_GPG_ENABLE=false

* Clarify that this feature is only available with Git repositories

* codegen

* Move verification code to own function

* Remove deprecated check

* Make things more developer friendly when running locally

* Enable GPG feature by default, and don't require ARGOCD_GNUPGHOME to be set

* Revert changes to manifests to reflect default enable state

* Codegen
2020-06-22 18:21:53 +02:00
..
dev-mounter feat: GPG commit signature verification (#2492) (#3242) 2020-06-22 18:21:53 +02:00
gen-crd-spec chore: Migrate CI toolchain to GitHub actions (#3677) 2020-05-31 23:11:28 +02:00
installers feat: upgrade kustomize to v3.6.1 version (#3696) 2020-06-02 09:37:10 -07:00
known_types chore: Fix a bunch of lint issues (#3412) 2020-04-14 08:01:43 -07:00
.dockerignore Move kustomization files back to kustomize 2.0.3 (#1972) 2019-07-23 11:24:59 -07:00
custom-boilerplate.go.txt Add application CRD definition. Implement CRD install CLI command (#1) 2018-02-16 12:58:02 -08:00
Dockerfile.dev-tools chore: Containerize complete build & test toolchain (#3245) 2020-03-27 11:36:20 -07:00
generate-proto.sh feat: GPG commit signature verification (#2492) (#3242) 2020-06-22 18:21:53 +02:00
git-ask-pass.sh chore: Spelling (#3647) 2020-05-27 10:22:13 -07:00
git-verify-wrapper.sh feat: GPG commit signature verification (#2492) (#3242) 2020-06-22 18:21:53 +02:00
gpg-wrapper.sh feat: GPG commit signature verification (#2492) (#3242) 2020-06-22 18:21:53 +02:00
install.sh feat: Add build support for ARM images (#3554) 2020-05-31 19:31:29 +02:00
ssh_known_hosts Git cloning via SSH was not verifying host public key (#1276) 2019-03-15 14:29:10 -07:00
test.sh chore: Migrate CI toolchain to GitHub actions (#3677) 2020-05-31 23:11:28 +02:00
tool-versions.sh feat: upgrade kustomize to v3.6.1 version (#3696) 2020-06-02 09:37:10 -07:00
tools.go chore: Migrate to Go modules (#3639) 2020-05-26 18:15:38 +02:00
trigger-release.sh chore: fix tag matching in trigger-release.sh script (#3785) 2020-06-17 08:59:08 +02:00
update-codegen.sh chore: Migrate CI toolchain to GitHub actions (#3677) 2020-05-31 23:11:28 +02:00
update-manifests.sh chore: Containerize complete build & test toolchain (#3245) 2020-03-27 11:36:20 -07:00
update-openapi.sh chore: Migrate CI toolchain to GitHub actions (#3677) 2020-05-31 23:11:28 +02:00
update-ssh-known-hosts.sh Git cloning via SSH was not verifying host public key (#1276) 2019-03-15 14:29:10 -07:00
versions.sh chore: Migrate to Go modules (#3639) 2020-05-26 18:15:38 +02:00