argo-cd/util/webhook/registry.go
Nitish Kumar db7d672f05
feat(webhooks): add webhook support for GHCR (#26462)
Signed-off-by: nitishfy <justnitish06@gmail.com>
2026-04-16 13:11:31 +02:00

136 lines
4.5 KiB
Go

package webhook
import (
"errors"
"fmt"
"strings"
log "github.com/sirupsen/logrus"
"github.com/argoproj/argo-cd/v3/pkg/apis/application/v1alpha1"
"github.com/argoproj/argo-cd/v3/util/argo"
"github.com/argoproj/argo-cd/v3/util/glob"
"k8s.io/apimachinery/pkg/labels"
)
// RegistryEvent represents a normalized container registry webhook event.
//
// It captures the essential information needed to identify an OCI artifact
// update, including the registry host, repository name, tag, and optional
// content digest. This structure is produced by registry-specific parsers
// and consumed by the registry webhook handler to trigger application refreshes.
type RegistryEvent struct {
// RegistryURL is the hostname of the registry, without protocol or trailing slash.
// e.g. "ghcr.io", "docker.io", "123456789.dkr.ecr.us-east-1.amazonaws.com"
// Together with Repository, it forms the OCI repo URL: oci://RegistryURL/Repository.
// Parsers must ensure this value is consistent with how users configure repoURL
// in their Argo CD Applications (e.g. oci://ghcr.io/owner/repo).
RegistryURL string `json:"registryUrl,omitempty"`
// Repository is the full repository path within the registry, without a leading slash.
// e.g. "owner/repo" for ghcr.io, "library/nginx" for docker.io.
// Together with RegistryURL, it forms the OCI repo URL: oci://RegistryURL/Repository.
Repository string `json:"repository,omitempty"`
// Tag is the image tag
// eg. 0.3.0
Tag string `json:"tag,omitempty"`
}
// OCIRepoURL returns the full OCI repository URL for use in Argo CD Application
// source matching, e.g. "oci://ghcr.io/owner/repo".
func (e *RegistryEvent) OCIRepoURL() string {
return fmt.Sprintf("oci://%s/%s", e.RegistryURL, e.Repository)
}
// ErrHMACVerificationFailed is returned when a registry webhook signature check fails.
var ErrHMACVerificationFailed = errors.New("HMAC verification failed")
// HandleRegistryEvent processes a normalized registry event and refreshes
// matching Argo CD Applications.
//
// It constructs the full OCI repository URL from the event, finds Applications
// whose sources reference that repository and revision, and triggers a refresh
// for each matching Application. Namespace filters are applied according to the
// handler configuration.
func (a *ArgoCDWebhookHandler) HandleRegistryEvent(event *RegistryEvent) {
repoURL := event.OCIRepoURL()
normalizedRepoURL := normalizeOCI(repoURL)
revision := event.Tag
log.WithFields(log.Fields{
"repo": repoURL,
"tag": revision,
}).Info("Received registry webhook event")
// Determine namespaces to search
nsFilter := a.ns
if len(a.appNs) > 0 {
nsFilter = ""
}
appIf := a.appsLister.Applications(nsFilter)
apps, err := appIf.List(labels.Everything())
if err != nil {
log.Errorf("Failed to list applications: %v", err)
return
}
var filteredApps []v1alpha1.Application
for _, app := range apps {
if app.Namespace == a.ns || glob.MatchStringInList(a.appNs, app.Namespace, glob.REGEXP) {
filteredApps = append(filteredApps, *app)
}
}
for _, app := range filteredApps {
sources := app.Spec.GetSources()
if app.Spec.SourceHydrator != nil {
sources = append(sources, app.Spec.SourceHydrator.GetDrySource())
}
for _, source := range sources {
if normalizeOCI(source.RepoURL) != normalizedRepoURL {
log.WithFields(log.Fields{
"sourceRepoURL": source.RepoURL,
"eventRepoURL": repoURL,
}).Debug("Skipping app: OCI repository URLs do not match")
continue
}
if !compareRevisions(revision, source.TargetRevision) {
log.WithFields(log.Fields{
"revision": revision,
"targetRevision": source.TargetRevision,
}).Debug("Skipping app: revision does not match targetRevision")
continue
}
log.Infof("Refreshing app '%s' due to OCI push %s:%s",
app.Name, repoURL, revision,
)
namespacedAppInterface := a.appClientset.ArgoprojV1alpha1().
Applications(app.Namespace)
if _, err := argo.RefreshApp(
namespacedAppInterface,
app.Name,
v1alpha1.RefreshTypeNormal,
false,
); err != nil {
log.Errorf("Failed to refresh app '%s': %v",
app.Name, err)
}
break // no need to check other sources
}
}
}
// normalizeOCI normalizes an OCI repository URL for comparison.
//
// It removes the oci:// prefix, converts to lowercase, and removes any
// trailing slash to ensure consistent matching between webhook events
// and Application source URLs.
func normalizeOCI(url string) string {
url = strings.TrimPrefix(url, "oci://")
url = strings.TrimSuffix(url, "/")
return strings.ToLower(url)
}