Commit graph

438 commits

Author SHA1 Message Date
Alexander Matyushentsev
cea3c19d62
feat: support disabling grpc histogram (#4075) 2020-08-11 13:28:57 -07:00
Alex Stein
978d10f2f3
feat: add user-defined css overlay (#3642) (#4065) 2020-08-10 19:13:40 +02:00
rachelwang20
011415f5bd
feat: Switch to use weighted semaphore (#4049)
* Switch to use weighted semaphore

* Add replica count env

* fixed codegen
2020-08-06 13:29:30 -07:00
Alexander Matyushentsev
ba71ad934c
refactor: upgrade k8s client to 1.18 (#4046)
* refactor: upgrade k8s client to 1.18

* remove unnecessary go mod replacements
2020-08-05 11:36:40 -07:00
Darshan Chaudhary
cb7fa39144
feat: add cluster resource blacklist to projects (#3960)
feat: add cluster resource blacklist to projects (#3960)

Signed-off-by: darshanime <deathbullet@gmail.com>
2020-08-04 08:06:28 -07:00
May Zhang
613af547c3
feat: adding validate for app create and app set (#4016)
* feat: adding disable-validation for app create and app set

* feat: adding disable-validation for app create and app set

* feat: change test func name

* feat: added support of app unset and app edit in addition to app create and app set.

* feat: remove extra space.
2020-07-30 13:28:36 -07:00
Alexander Matyushentsev
50d9914e8d
fix: handle encoded URL parameter in cluster details page (#4011) 2020-07-28 14:16:49 -07:00
Alexander Matyushentsev
a6399e59e1
feat: support retrying failed sync attempts (#3997)
* feat: support retrying failed sync attempts

* fix: sync results should be cleared in retry sync attempt
2020-07-28 10:14:17 -07:00
rachelwang20
95820cf64f
feat: User can define Orphaned exception avoiding unnecessary warnings (#3900)
* Include sub and and iat in PermissionDenied message

* iat fromat changing

* Adding MapClaims convertion

* Adding Orphaned exception list

* Adding group kind label

* Fixed lint errors

* Method rename
2020-07-09 16:19:47 -07:00
May Zhang
021b13c660
fix: permission denied due to NormalizeProjs failed to get list of pr… (#3883)
* fix: permission denied due to NormalizeProjs failed to get list of projects

* fix: permission denied due to NormalizeProjs failed to get list of projects

* fix: return error if normalization failed.

* fix: return error if normalization failed.

* fix: return error if normalization failed.

* fix: in GetJWTToken, remove normalize. It causes issue with delete token.

* Moved get project to only when apierr.IsConflict(err)
2020-07-02 15:31:35 -07:00
Alexander Matyushentsev
d09d25cc2a
feat: implement 'argocd-util apps get-reconcile-results command' (#3888)
* feat: implement 'argocd-util apps get-reconcile-results' command

* implement missing unit tests
2020-07-02 13:47:56 -07:00
Alexander Matyushentsev
20eb8bbc4d
fix: application list page consumes too much CPU (#3849)
* fix: application list page consumes too much CPU

* add broadcasterHandler tests
2020-06-29 15:32:18 -07:00
May Zhang
7fbf51c346
fix: jwtTokens are reset when applying AppProjects (#3791)
* jwtTokens are reset when applying AppProjects

* fix unit tests in server_test.go
checking in generated.pb.go

* fix unit tests in rbackpolicy_test.go

* fix yarnl lint errors

* fix delete token in both spec and status

* add tests

* fixing failed test

* fixing failed test

* retry 3 times during update

* renamed CRD fields.
Updated nomalize method.

* fixed UI

* fixing merge conflicts

* fixing merge conflicts

* removed unused variables in UI
renamed a CRD field
updated combineToken logic using map

* Only update project which needs normalize token.

* Changed logging.

* check for nil

* Fix UI

* added project role get tests

* rename variables

* clean up

* fixing failed tests

* fixing failed tests

* fixing error handling for remove token

* log err when we have retried 3 times

* sort tokens

* sort tokens
2020-06-25 15:11:24 -07:00
jannfis
28eb286f85
refactor: Migrate JSON marshaler from gitops-engine to argo-cd (#3839)
* fix: Migrate JSON marshaler from gitops-engine to argo-cd

* Lint
2020-06-24 18:07:49 +02:00
Alexander Matyushentsev
5d5d6a4ad6
feat: Display cluster info on cluster details page (#3793)
* feat: Display cluster info on cluster details page

* Store cluster info in cache instead of secret
2020-06-22 17:51:20 -07:00
Povilas Versockas
7d4f8558fe
feat: add grpc histogram metric in server (#3776) 2020-06-22 16:02:31 -07:00
Alexander Matyushentsev
fc2e3f82a2
fix: application controller should not modify cached applications (#3821) 2020-06-22 11:04:25 -07:00
jannfis
be718e2b61
feat: GPG commit signature verification (#2492) (#3242)
* Add initial primitives and tests for GPG related operations

* More tests and test documentation

* Move gpg primitives to own module

* Add initial primitives for running git verify-commit and tests

* Improve and better comment test

* Implement VerifyCommitSignature() primitive for metrics wrapper

* More commentary

* Make reposerver verify gpg signatures when generating manifests

* Make signature validation optional

* Forbid use of local manifests when signature verification is enabled

* Introduce new signatureKeys field in project CRD

* Initial support for only syncing against signed revisions

* Updates to GnuPG primitives and more test cases

* Move signature verification to correct place and add tests

* Add signature verification result to revision metadata and display it in UI

* Add more primitives and move out some stuff to common module

* Add more testdata

* Add key management primitives to ArgoDB

* Move type GnuPGPublicKey to appsv1 package

* Add const ArgoCDGPGKeysConfigMapName

* Handle key operations with appsv1.GnuPGPublicKey

* Add initial API for managing GPG keys

* Remove deprecated code

* Add primitives for adding public keys to configuration

* Change semantics of ValidateGPGKeys to return more key information

* Add key import functionality to public key API

* Fix code quirks reported by linter

* More code quirks fixes

* Fix test

* Add primitives for deleting keys from configuration

* Add delete key operation to API and CLI

* Cosmetics

* Implement logic to sync configuration to keyring in repo-server

* Add IsGPGEnabled() primitive and also update trustdb on ownertrust changes

* Use gpg.IsGPGEnabled() instead of custom test

* Remove all keyring manipulating methods from DB

* Cosmetics/comments

* Require grpc methods from argoproj pkg

* Enable setting config path via ARGOCD_GPG_DATA_PATH

* Allow "no" and any cases in ARGOCD_GPG_ENABLED

* Enable GPG feature on start and start-e2e and set required environment

* Cosmetics/comments

* Cosmetics and commentary

* Update API documentation

* Fix comment

* Only run GPG related operations if GPG is enabled

* Allow setting ARGOCD_GPG_ENABLE from the environment

* Create GPG ConfigMap resource during installation

* Use function instead of constant to get the watcher path

* Re-watch source path in case it gets recreated. Also, error on finish

* Add End-to-End tests for GPG commit verification

* Introduce SignatureKey type for AppProject CRD

* Fix merge error from previous commit

* Adapt test for additional manifest (argocd-gpg-keys-cm.yaml)

* Fix linter issues

* Adapt CircleCI configuration to enable running tests

* Add wrapper scripts for git and gpg

* Sigh.

* Display gpg version in CircleCI

* Install gnupg2 and link it to gpg in CI

* Try to install gnupg2 in CircleCI image

* More CircleCI tweaks

* # This is a combination of 10 commits.
# This is the 1st commit message:

Containerize tests - test cycle

# This is the commit message #2:

adapt working directory

# This is the commit message #3:

Build before running tests (so we might have a cache)

# This is the commit message #4:

Test limiting parallelism

# This is the commit message #5:

Remove unbound variable

# This is the commit message #6:

Decrease parallelism to find out limit

# This is the commit message #7:

Use correct flag

# This is the commit message #8:

Update Docker image

# This is the commit message #9:

Remove build phase and increase parallelism

# This is the commit message #10:

Further increase parallelism

* Dockerize toolchain

* Add new targets to Makefile

* Codegen

* Properly handle permissions for E2E tests

* Remove gnupg2 installation from CircleCI configuration

* Limit parallelism of build

* Fix Yarn lint

* Retrigger CI for possible flaky test

* Codegen

* Remove duplicate target in Makefile

* Pull in pager from dep ensure -v

* Adapt to gitops-engine changes and codegen

* Use new health package for health status constants

* Add GPG methods to ArgoDB mock module

* Fix possible nil pointer dereference

* Fix linter issue in imports

* Introduce RBAC resource type 'gpgkeys' and adapt policies

* Use ARGOCD_GNUPGHOME instead of GNUPGHOME for subsystem configuration

Also remove some deprecated unit tests.

* Also register GPG keys API with gRPC-GW

* Update from codegen

* Update GPG key API

* Add web UI to manage GPG keys

* Lint updates

* Change wording

* Add some plausibility checks for supplied data on key creation

* Update from codegen

* Re-allow binary keys and move check for ASCII armoured to UI

* Make yarn lint happy

* Add editing signature keys for projects in UI

* Add ability to configure signature keys for project in CLI

* Change default value to use for GNUPGHOME

* Do not include data section in default gpg keys CM

* Adapt Docker image for GnuPG feature

* Add required configuration to installation manifests

* Add add-signature-key and remove-signature-key commands to project CLI

* Fix typo

* Add initial user documentation for GnuPG verification

* Fix role name - oops

* Mention required RBAC roles in docs

* Support GPG verification of git annotated tags as well

* Ensure CLI can build succesfully

* Better support verification on tags

* Print key type in upper case

* Update user documentation

* Correctly disable GnuPG verification if ARGOCD_GPG_ENABLE=false

* Clarify that this feature is only available with Git repositories

* codegen

* Move verification code to own function

* Remove deprecated check

* Make things more developer friendly when running locally

* Enable GPG feature by default, and don't require ARGOCD_GNUPGHOME to be set

* Revert changes to manifests to reflect default enable state

* Codegen
2020-06-22 18:21:53 +02:00
Liviu Costea
7ccb16bf7a
feat: Support cluster name on Application destination. Closes #1548 (#2808)
feat: Support cluster name on Application destination. Closes #1548 (#2808)
2020-06-20 16:12:46 -07:00
Alexander Matyushentsev
6143f6d9be
fix: return default scopes if custom scopes are not configured (#3805) 2020-06-18 11:00:44 -07:00
May Zhang
d040d9bf04
feat: Support additional metadata in Application sync operation (#3747)
* feat: Support additional metadata in Application sync operation

* regenerated generated.pb.go
2020-06-10 15:28:07 -07:00
Darshan Chaudhary
e102ec11ac
feat: Allow --local with automatic sync for --dry-run (#3675)
* feat: Allow --local with automatic sync for --dry-run

Signed-off-by: darshanime <deathbullet@gmail.com>

* feat: add e2e test for local sync with dry run

Signed-off-by: darshanime <deathbullet@gmail.com>
2020-06-10 14:05:37 +02:00
Alexander Matyushentsev
460f6653dc
fix: avoid panic in badge handler (#3741) 2020-06-09 19:01:25 -07:00
May Zhang
10dc082404
fix: Support argocd app diff --local and argocd app sync --local with custom plugins (#3733)
* settingsMgr returns plugins list When login successful or When API server DisableAuth
2020-06-09 14:06:49 -07:00
Alexander Matyushentsev
94e6efc0fc
fix: delete api should return 404 error if app does not exist (#3739) 2020-06-09 11:06:34 -07:00
May Zhang
d60e1b2876
feat: get cluster connection status from cluster synced time (#3604)
feat: get cluster connection status from cluster synced time (#3604)
2020-06-04 11:36:26 -07:00
jannfis
bc83719037
chore: Fix complaints of golang-ci lint v1.26.0 (#3673) 2020-05-30 18:54:14 -07:00
Alexander Matyushentsev
ee64a4d9ca
fix: upgrade gitops engine dependency (#3668) 2020-05-28 18:42:01 -07:00
Josh Soref
a724574ede
chore: Spelling (#3647)
chore: Spelling (#3647)
2020-05-27 10:22:13 -07:00
Phil Gore
8aadc310c9
fix: apply scopes from argocd-rbac-cm to project jwt group searches (#3508)
* merging changes

* apply scopes from argocd-rbac-cm to projects

* fixing server merge conflict

* passing tests
2020-05-25 09:05:56 +02:00
Alexander Matyushentsev
fe8d47e0ea
feat: move engine code to argoproj/gitops-engine repo (#3599) 2020-05-15 14:39:29 -07:00
Alexander Matyushentsev
192ee93fc4
feat: Gitops engine (#3066)
* Move utils packages that are required for gitops engine under engine/pkg/utils package.
Following changes were implemented:
* util/health package is split into two parts: resource health assessement & resource health assessement and moved into engine/pkg/utils
* utils packages moved: Closer and Close method of util package moved into engine/pkg/utils/io package
* packages diff, errors, exec, json, kube and tracing moved into engine/pkg/utils

* Move single cluster caching into engine/kube/cache package

* move sync functionality to engine/kube/sync package

* remove dependency on metrics package from engine/pkg/utils/kube/cache

* move annotation label definitions into engine/pkg/utils/kube/sync

* make sure engine/pkg has no dependencies on other argo-cd packages

* allow importing engine as a go module

* implement a high-level interface that might be consumed by flux

* fix deadlock caused by cluster cache event handler

* ClusterCache should return error if requested group kind not found

* remove obsolete tests

* apply reviewer notes
2020-05-15 10:01:18 -07:00
Alexander Matyushentsev
24fa758444
fix: enable redis retries; add redis request duration metric (#3575) 2020-05-12 14:39:18 -07:00
May Zhang
e42102a67e
fix: when --rootpath is on, 404 is returned when URL contains encoded URI (#3564)
* Fix when --rootpath is on, 404 is returned when URL contains encoded URI

* Update doc

* Update doc
2020-05-11 08:39:27 -07:00
SB
e5d4673eac
feat: Add a Get Repo command to see if Argo CD has a repo (#3523)
* fix: Updating to jsonnet v1.15.0 fix issue #3277

* feat: Changes from codegen, adding a repository gt service

* feat: Adding a get repository command

* Retrigger CI pipeline

* refactor: delete deprecated option on Get
refactor printing getcommand result
Getrepository() dependent on rbac enforcement

* fix: setting Get repo command to get
2020-05-04 09:20:48 +02:00
May Zhang
7ed6c18762
fix: to support --rootpath (#3503)
* added path to cookie

* additional changes to support rootpath:
1. when using https, redirect to the right URL.
2. when rootpath is set, handle healthz, swagger, etc.

* additional changes to support rootpath:
1. when using https, redirect to the right URL.
2. when rootpath is set, handle healthz only.

* additional changes to support rootpath:
1. when using https, redirect to the right URL.
2. when rootpath is set, handle healthz only.

* Fixed for swagger-ui with rootpath

* Fixed for swagger test

* Fixed for redirect path

* Fixed for redirect path
2020-04-29 14:40:03 -07:00
Alexander Matyushentsev
81d5b13083
fix: api incorrectly verifies if auto-sync is enabled and reject sync local request (#3506) 2020-04-29 00:09:27 -07:00
Alexander Matyushentsev
842a3d12f6
feat: add redis metrics to application controller and api server (#3500)
* add redis metrics to application controller and api server

* fix failed test
2020-04-28 12:52:03 -07:00
May Zhang
14f1725f53
added path to cookie (#3501) 2020-04-28 10:26:47 -07:00
May Zhang
d77072b534
fix: Set root path (#3475)
* Set root path

* updated http mux if --rootpath is set during server startup.
updated baseHRef if --rootpath is set.
added --grpc-web-root-path for CLI.

* added rootpath as part of config context name

* clean up not used variables.
2020-04-27 08:35:58 -07:00
Alexander Matyushentsev
f5b600d4af
feat: limit the maximum number of concurrent login attempts (#3467)
* feat: limit the maximum number of concurrent login attempts

* unit test rate limiter

* address reviewer questions
2020-04-23 12:33:17 -07:00
Alexander Matyushentsev
14188656c8
fix: GetApplicationSyncWindows API should not validate project permissions (#3456) 2020-04-21 11:26:17 -07:00
jannfis
76bacfdea4
fix: Add initial implementation for rate limiting failed logins (#3404)
* fix: Add initial implementation  for rate limiting failed logins

* Trigger test build

* Remove deprecated code and fix new project tests

* move cache related code from sessionmanager to cache access wrapper

* avoid using sleep in sessionmanager tests

* mention SECONDS in session manager environment variables to make it easier to understand meaning of each variable

* Login button should be disabled while user is waiting for login result

* prevent timing-based user enumeration attack

* reject too many failed attempts; always compute hash and introduce random delay

* remove unused constants

* fix linter errors

Co-authored-by: Alexander Matyushentsev <amatyushentsev@gmail.com>
2020-04-21 11:10:25 -07:00
Alexander Matyushentsev
16c6eaf9ae
feat: support user specified account token ids (#3425) 2020-04-15 15:19:25 -07:00
Alexander Matyushentsev
05f5a79923
feat: support separate Kustomize version per application (#3414) 2020-04-15 12:04:31 -07:00
jannfis
8ad928330f
chore: Fix a bunch of lint issues (#3412)
* chore: Fix linter complaints
2020-04-14 08:01:43 -07:00
rachelwang20
b4236e1dc7
feat: Let user to define meaningful unique JWT token name (#3388)
* feat: Let user to define meaningful unique JWT token name

* Update sessionmanager.go

* Update server_test.go

* Update sessionmanager_test.go

* Adding get JWTToken by id if not then by issued time

* Adding relate tests

* Adding relate tests

* Retrigger the build

* feat: Let user to define meaningful unique JWT token name

* Update sessionmanager.go

* Update server_test.go

* Update sessionmanager_test.go

* Adding get JWTToken by id if not then by issued time

* Adding relate tests

* Retrigger the build

* feat: Let user to define meaningful unique JWT token name

* Adding get JWTToken by id if not then by issued time

* Adding relate tests

* Adding UI change

* add yarn lint
2020-04-13 14:13:05 -07:00
Alexander Matyushentsev
e5452ff70e
fix: return 401 error code if username does not exist (#3369) 2020-04-06 11:15:15 +02:00
May Zhang
98337065ae
fix: Fixing could not find plugin issue when app sync and app diff (#3326)
* Fixing could not find plugin issue when app sync and app diff

* Fixing codegen error

* Revert "Fixing codegen error"

This reverts commit b2dcfb81

* Fixing codegen error

* If user is logged in, settings API would return ConfigManagementPlugins
2020-04-02 09:50:42 -07:00
Alexander Matyushentsev
7ae204d426
fix: avoid nil pointer dereference in badge handler (#3316) 2020-03-30 14:27:43 -07:00