Signed-off-by: Kevin Huber <kevin.huber@hotmail.com>
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* fix: update managed namespace metadata
This commit fixes an issue where a namespace does not get updated
unless a sync is performed. Since the `managedNamespaceMetadata` is not
a part of the Application Git state, we need a way to force a sync once
the metadata has changed. In order to do that, we need to add state
to compare with.
Once a sync is performed, the `ManagedNamespaceMetadata` gets copied
to `SyncResult`, which will then be compared with on subsequent syncs.
If there's a mismatch between
`app.Spec.SyncPolicy.ManagedNamespaceMetadata` and
`app.Status.OperationState.SyncResult.ManagedNamespaceMetadata` we mark
the Application as `OutOfSync`.
Fixes#12661.
Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
* fix: nil check
Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
* fix: allow empty apps to be updated
If an app is empty but still differs in terms of
`managedNamespaceMetadata`, it should still be kept up to date.
Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
* test: add unit tests in appcontroller
Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
* fix: rebase
Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
* refactor: extract method
Consolidate checks to `app.HasChangedManagedNamespaceMetadata()`
Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
* chore: make codegen
Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
---------
Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
* feat: Support configuring annotations that are preserved by the AppSet
Signed-off-by: Lawrence Carvalho <lacarvalho91@gmail.com>
Signed-off-by: Lawrence Carvalho <lawrence.carvalho@sky.uk>
* Docs
Signed-off-by: Lawrence Carvalho <lawrence.carvalho@sky.uk>
* Retrigger CI pipeline
Signed-off-by: Lawrence Carvalho <lawrence.carvalho@sky.uk>
---------
Signed-off-by: Lawrence Carvalho <lacarvalho91@gmail.com>
Signed-off-by: Lawrence Carvalho <lawrence.carvalho@sky.uk>
* fix: pathParamPrefix is optional
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* go mod tidy
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* fix import
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* fix codegen
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* feat: Add support for cloning Google Cloud Source repos (#7534)
* Google Cloud service account auth
Signed-off-by: David Becher <becher.david@googlemail.com>
* fix: Fill missing struct field (GCP SA key) in cli cmd
Signed-off-by: David Becher <becher.david@googlemail.com>
* fix(ui): Add proxy option when configuring Google Cloud Source repo
Signed-off-by: David Becher <becher.david@googlemail.com>
* fix: Remove secret (GCP SA key) in Get server req
Signed-off-by: David Becher <becher.david@googlemail.com>
* refactor: Do not use context.WithTimeout for Google creds
As the context is used in the background to refresh credentials, it
should not be cancelled.
Signed-off-by: David Becher <becher.david@googlemail.com>
* fix: Use proxy setting only in repo-service, not repocreds-service
Signed-off-by: David Becher <becher.david@googlemail.com>
* test: Create tests for GoogleCloudCreds
This commit refactors the implementation of GoogleCloudCreds in order to
make its methods testable.
Signed-off-by: David Becher <becher.david@googlemail.com>
* fix: Linting issues
Signed-off-by: David Becher <becher.david@googlemail.com>
* chore: Fix typo in docs.
Signed-off-by: David Becher <becher.david@googlemail.com>
* chore: Adjust url-allow-list for lint-docs action
Signed-off-by: David Becher <becher.david@googlemail.com>
* chore: Incorporate suggested refactorings
Signed-off-by: David Becher <becher.david@googlemail.com>
* Delete url-allow-list
Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com>
* wrap errors
Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com>
* More UI goodies and codegen
Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com>
* Update docs screenshots
Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com>
* move interface up next to other interfaces
Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com>
* Reduce png size
Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com>
* update generated
Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com>
* fix whitespace from codegen
Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com>
Signed-off-by: David Becher <becher.david@googlemail.com>
Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com>
Co-authored-by: David Becher <becher.david@googlemail.com>
* feat: parameterized CMPs
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
* values types for parameters
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
* Add types for CMP announcement
Signed-off-by: zachaller <zachaller@hotmail.com>
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
* Reorg
Signed-off-by: zachaller <zachaller@hotmail.com>
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
* finish type
Signed-off-by: zachaller <zachaller@hotmail.com>
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
* First pass at working GetParametersAnnouncement
Signed-off-by: zachaller <zachaller@hotmail.com>
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
* Typos
Signed-off-by: zachaller <zachaller@hotmail.com>
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
* Make all fields optional
Signed-off-by: zachaller <zachaller@hotmail.com>
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
* Make sure response makes it to repo server
Signed-off-by: zachaller <zachaller@hotmail.com>
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
* Refactor for testing
Signed-off-by: zachaller <zachaller@hotmail.com>
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
* lint
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
* send build env to param announcement gen
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
* test parameter announcement
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
* tests
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
* environ tests
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
* Rename workdir to app dir
Signed-off-by: zachaller <zachaller@hotmail.com>
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
* handle empty command, start ui work (#11)
* Add types for CMP announcement
Signed-off-by: zachaller <zachaller@hotmail.com>
* Reorg
Signed-off-by: zachaller <zachaller@hotmail.com>
* finish type
Signed-off-by: zachaller <zachaller@hotmail.com>
* First pass at working GetParametersAnnouncement
Signed-off-by: zachaller <zachaller@hotmail.com>
* Typos
Signed-off-by: zachaller <zachaller@hotmail.com>
* Make all fields optional
Signed-off-by: zachaller <zachaller@hotmail.com>
* Make sure response makes it to repo server
Signed-off-by: zachaller <zachaller@hotmail.com>
* Refactor for testing
Signed-off-by: zachaller <zachaller@hotmail.com>
* values types for parameters
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
* lint
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
* send build env to param announcement gen
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
* test parameter announcement
* tests
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
* environ tests
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
* Rename workdir to app dir
Signed-off-by: zachaller <zachaller@hotmail.com>
* handle empty command, start ui work
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
* fix order
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
* fix map merging, make params read-only
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
Co-authored-by: zachaller <zachaller@hotmail.com>
* Add helm PoC example plugin
Signed-off-by: zachaller <zachaller@hotmail.com>
* example as kustomize overlay
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
* Parameterized cmps docs (#12)
* use printf instead of echo
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
* docs
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
* test for temp dir cleanup
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
* handle empty params
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
* handle empty values
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
* consolidate types
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
* fix tests
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
* docs
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
* docs
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
* remove duplicate info
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
* add warning about param announcements vs param values
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
* tests (#13)
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
* tests
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
* fix types
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
* fix test
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
* fix codegen
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
* fix codegen
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
* revert test hack
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
* docs correction
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
* fix indentation
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
* fix spacing
Signed-off-by: CI <michael@crenshaw.dev>
* move util function to util file and add test
Signed-off-by: CI <michael@crenshaw.dev>
* wrap error
Signed-off-by: CI <michael@crenshaw.dev>
* correct version number
Signed-off-by: CI <michael@crenshaw.dev>
* document necessity of collectionType param
Signed-off-by: CI <michael@crenshaw.dev>
* remove part of error message that's not useful (dir name is now randomized)
Signed-off-by: CI <michael@crenshaw.dev>
* fix things so that they are not broken
Signed-off-by: CI <michael@crenshaw.dev>
* don't close file before caller gets a chance to use it
Signed-off-by: CI <michael@crenshaw.dev>
* codegen
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* fix test
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* comments
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* fix test
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* DON'T PANIC
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
Signed-off-by: zachaller <zachaller@hotmail.com>
Signed-off-by: CI <michael@crenshaw.dev>
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Co-authored-by: zachaller <zachaller@hotmail.com>
* namespace labels
Signed-off-by: pashavictorovich <pavel@codefresh.io>
* create namespace should support annotations
Signed-off-by: pashavictorovich <pavel@codefresh.io>
* handle also modification hook
Signed-off-by: pashavictorovich <pavel@codefresh.io>
* regenerate entity on modify hook
Signed-off-by: pashavictorovich <pavel@codefresh.io>
* manifests
Signed-off-by: pashavictorovich <pavel@codefresh.io>
* feat: enable metadata to be set on namespaces
This builds upon the work that @pasha-codefresh did in #10288.
The main differences between this PR and the previous one is that we use
SSA to diff between different versions of the namespace, as well as
having a slightly different API in gitops-engine for setting the
namespace modifier.
We now also set the ownership of the namespace in ArgoCD.
Closes#4628Closes#6215Closes#7799
Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
* fix: don't always track namespaces
For now, only allow namespaces managed with `managedNamespaceMetadata`
to have tracking set by Argo. Ideally we'd like new namespaces to also
be tracked by Argo, but there's currently an issue with a failing
integration test.
Also wrap error message if setting the app instance errors on the
namespace.
Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
* fix: always return true with `hasManagedMetadata`
If `hasManagedMetadata` is set, `true` should always be returned.
Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
* docs: add clarifying docs on resource tracking
Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
* style: pr tweaks
Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
* fix: re-add label unsetting
Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
* Update gitops-engine to current master
Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>
Signed-off-by: pashavictorovich <pavel@codefresh.io>
Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>
Co-authored-by: pashavictorovich <pavel@codefresh.io>
Co-authored-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>
This commit adds a new flag, `permitOnlyProjectScopedClusters`, which
prevents any application from syncing to clusters which are not a part
of the same project. Fixes#10220.
Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
* chore: infer managed resources health from redis instead of storing it in CRD
Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
* apply reviewer notes
Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
* chore: remove helm2
Reorder test/container/Dockerfile to mitigate issue of being unable to create
.gitconfig since the homedir is not present
chore: cleanup helm2 and tests related to it
Remove helm2 init. Fix unused import
Use helm 3 structure for CRDs
Remove helm2-dependency testdata
Address PR comments
Add back values-production and value.yaml on helm tests
Remove helm2 from openapi.
Signed-off-by: Shyukri Shyukriev <shyukri.shyukriev@mariadb.com>
modified: util/helm/cmd_test.go
* fix: generated openapi
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
Co-authored-by: Michael Crenshaw <michael@crenshaw.dev>
* feat: add skipCrds flag for helm charts
* replace additionalTemplateArgs with includeCrds flag
* add testcase for skip crds
Signed-off-by: patst <patrick.steinig@googlemail.com>
* feat: add skipCrds flag for helm charts
* replace additionalTemplateArgs with includeCrds flag
* add testcase for skip crds
Signed-off-by: patst <patrick.steinig@googlemail.com>
* feat: add skipCrds flag for helm charts
* replace additionalTemplateArgs with includeCrds flag
* add testcase for skip crds
Signed-off-by: patst <patrick.steinig@googlemail.com>
* feat: add skipCrds flag for helm charts
* make sure include crds is not added for helm2
Signed-off-by: patst <patrick.steinig@googlemail.com>
so as to allow operators to prevent Argo CD from passing valueFiles
to helm template if they don't exist in the source under the specified path.
Signed-off-by: Oscar Craviotto <craviotto@avellaneda.com>
* feat: add first class support to access repositories using proxy
Currently, users need to set the proxy URLs as env variables in the repo server. This is not user-friendly and also error-prone. This PR adds support to maintain proxy URLs along with repository configs in the argocd-cm. Argo CD uses this proxy to access your repository. In case the custom proxy is absent, it defaults to reading the proxy from the env variables.
Signed-off-by: Chetan Banavikalmutt <chetanrns1997@gmail.com>
* set both http & https proxy variables
Signed-off-by: Chetan Banavikalmutt <chetanrns1997@gmail.com>
Currently, the usage of standard lua library is always disabled, making it difficult to implement complex health check scripts.
This feat allow admins to control the usage of standard library by setting "health.lua.useOpenLibs" (merged-keys convention)/"resource.customizations.useOpenLibs.<group_kind>"
(split-keys convention) field in argocd-cm ConfigMap.
Signed-off-by: Chetan Banavikalmutt <chetanrns1997@gmail.com>
* fix: add helm dependecies with custom CA
Signed-off-by: Shubham Agarwal <shubhamagarawal19@gmail.com>
* fixed go lint error
Signed-off-by: Shubham Agarwal <shubhamagarawal19@gmail.com>
* ignore existing repos
Signed-off-by: Shubham Agarwal <shubhamagarawal19@gmail.com>
* fix: Enable helm OCI to work for lots of different URLs without having to create a repo for each one
Signed-off-by: May Zhang <may_zhang@intuit.com>
* fix: Enable helm OCI to work for lots of different URLs without having to create a repo for each one
Signed-off-by: May Zhang <may_zhang@intuit.com>
* fix: lint
Signed-off-by: May Zhang <may_zhang@intuit.com>
* fix: lint
Signed-off-by: May Zhang <may_zhang@intuit.com>
* fix: fix test code
Signed-off-by: May Zhang <may_zhang@intuit.com>
* fix: dependency add for https and oci
Signed-off-by: May Zhang <may_zhang@intuit.com>
* fix: go.sum and install.yaml
Signed-off-by: May Zhang <may_zhang@intuit.com>
* fix: fix checking if repo exits
Signed-off-by: May Zhang <may_zhang@intuit.com>
* fix: fix generated files
Signed-off-by: May Zhang <may_zhang@intuit.com>
* fix: fix go.mod and go.sum
Signed-off-by: May Zhang <may_zhang@intuit.com>
* fix: clean up code
Signed-off-by: May Zhang <may_zhang@intuit.com>
* fix: rename RepoCreds to HelmRepoCreds
Signed-off-by: May Zhang <may_zhang@intuit.com>
* fix: Added type for repoCreds.
Signed-off-by: May Zhang <may_zhang@intuit.com>
* fix: checking in install.yaml
Signed-off-by: May Zhang <may_zhang@intuit.com>
* fix: checking in install.yaml
Signed-off-by: May Zhang <may_zhang@intuit.com>
* fix: checking in install.yaml
Signed-off-by: May Zhang <may_zhang@intuit.com>
* fix: Makefile
Signed-off-by: May Zhang <may_zhang@intuit.com>
Co-authored-by: Shubham Agarwal <shubhamagarawal19@gmail.com>
