* fix(health): only consider non-empty health checks
For wildcard health checks, only consider wildcards with a non-empty
health check. Fixes#16905 (at least partially).
Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
* test: renaming test case for clarity
Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
* refactor: add clarity as to what the function is supposed to do
Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
* Update docs/operator-manual/health.md
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
* test: add test case for `*/*` override with empty healthcheck
Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
---------
Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* Kind wildcard support in health customizations
Signed-off-by: reggie <reginakagan@gmail.com>
* Updated health customizations docs to using the correct field with a /
Signed-off-by: reggie <reginakagan@gmail.com>
* Updated health customizations docs to using the correct field with a /
Signed-off-by: reggie <reginakagan@gmail.com>
* Document resource kind wildcard for custom health check
Signed-off-by: reggie <reginakagan@gmail.com>
* Implemented wildcard * support in API Group and Resource Kind and updated docs
Signed-off-by: reggie <reginakagan@gmail.com>
* Implemented wildcard * support in API Group and Resource Kind and updated docs
Signed-off-by: reggie <reginakagan@gmail.com>
* Implemented wildcard * support in API Group and Resource Kind and updated docs
Signed-off-by: reggie <reginakagan@gmail.com>
* Added a custom create-from CronJob action
Signed-off-by: reggie <reginakagan@gmail.com>
* in progress
Signed-off-by: reggie <reginakagan@gmail.com>
* in progress
Signed-off-by: reggie <reginakagan@gmail.com>
* in progress
Signed-off-by: reggie <reginakagan@gmail.com>
* in progress
Signed-off-by: reggie <reginakagan@gmail.com>
* added a ns in the action.lua and fixed tests
Signed-off-by: reggie <reginakagan@gmail.com>
* create-job
Signed-off-by: reggie <reginakagan@gmail.com>
* in progress
Signed-off-by: reggie <reginakagan@gmail.com>
* more changes
Signed-off-by: reggie <reginakagan@gmail.com>
* full unit tests and action returning an array
Signed-off-by: reggie <reginakagan@gmail.com>
* cleanup
Signed-off-by: reggie <reginakagan@gmail.com>
* fix the custom tests
Signed-off-by: reggie <reginakagan@gmail.com>
* e2e tests
Signed-off-by: reggie <reginakagan@gmail.com>
* json marshaling annotations ImpactedResource, e2e tests and docs
Signed-off-by: reggie <reginakagan@gmail.com>
* more docs and tests
Signed-off-by: reggie <reginakagan@gmail.com>
* upstream sync
Signed-off-by: reggie <reginakagan@gmail.com>
* fix wrong return upon going over the impacted resources + docs + fixing e2e tests
Signed-off-by: reggie <reginakagan@gmail.com>
* docs
Signed-off-by: reggie <reginakagan@gmail.com>
* better error handling
Signed-off-by: reggie <reginakagan@gmail.com>
* K8SOperation as an enum
Signed-off-by: reggie <reginakagan@gmail.com>
* added dry-run for create operation
Signed-off-by: reggie <reginakagan@gmail.com>
* small changes
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* ref to my gitops-engine fork out
Signed-off-by: reggie <reginakagan@gmail.com>
* ref to my gitops-engine fork out
Signed-off-by: reggie <reginakagan@gmail.com>
* ref to my gitops-engine fork out
Signed-off-by: reggie <reginakagan@gmail.com>
* ref to my gitops-engine fork out
Signed-off-by: reggie <reginakagan@gmail.com>
* ref to my gitops-engine fork out
Signed-off-by: reggie <reginakagan@gmail.com>
* gitops engine dependency and test fixes
Signed-off-by: reggie <reginakagan@gmail.com>
* add workflows action
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* cronworkflow and workflowtemplate actions
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* update gitops-engine
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
---------
Signed-off-by: reggie <reginakagan@gmail.com>
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* Kind wildcard support in health customizations
Signed-off-by: reggie <reginakagan@gmail.com>
* Updated health customizations docs to using the correct field with a /
Signed-off-by: reggie <reginakagan@gmail.com>
* Updated health customizations docs to using the correct field with a /
Signed-off-by: reggie <reginakagan@gmail.com>
* Document resource kind wildcard for custom health check
Signed-off-by: reggie <reginakagan@gmail.com>
* Implemented wildcard * support in API Group and Resource Kind and updated docs
Signed-off-by: reggie <reginakagan@gmail.com>
* Implemented wildcard * support in API Group and Resource Kind and updated docs
Signed-off-by: reggie <reginakagan@gmail.com>
* Implemented wildcard * support in API Group and Resource Kind and updated docs
Signed-off-by: reggie <reginakagan@gmail.com>
* Removed code duplication and returned an empty string instead of an error
Signed-off-by: reggie <reginakagan@gmail.com>
Signed-off-by: reggie <reginakagan@gmail.com>
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Currently, the usage of standard lua library is always disabled, making it difficult to implement complex health check scripts.
This feat allow admins to control the usage of standard library by setting "health.lua.useOpenLibs" (merged-keys convention)/"resource.customizations.useOpenLibs.<group_kind>"
(split-keys convention) field in argocd-cm ConfigMap.
Signed-off-by: Chetan Banavikalmutt <chetanrns1997@gmail.com>
* Revert "feat: Add health check for HPA (#4915)"
This reverts commit f6a32a9e
Signed-off-by: May Zhang <may_zhang@intuit.com>
* fix: revert health check
Signed-off-by: May Zhang <may_zhang@intuit.com>
* fix: remove extra line
Signed-off-by: May Zhang <may_zhang@intuit.com>
HorizontalPodAutoscaler uses annotations to store conditions. This commit adds a custom heath check that parses the conditions from annotation and creates health status.
Fixes: #4413
Signed-off-by: Chetan Banavikalmutt <chetanrns1997@gmail.com>
* Move utils packages that are required for gitops engine under engine/pkg/utils package.
Following changes were implemented:
* util/health package is split into two parts: resource health assessement & resource health assessement and moved into engine/pkg/utils
* utils packages moved: Closer and Close method of util package moved into engine/pkg/utils/io package
* packages diff, errors, exec, json, kube and tracing moved into engine/pkg/utils
* Move single cluster caching into engine/kube/cache package
* move sync functionality to engine/kube/sync package
* remove dependency on metrics package from engine/pkg/utils/kube/cache
* move annotation label definitions into engine/pkg/utils/kube/sync
* make sure engine/pkg has no dependencies on other argo-cd packages
* allow importing engine as a go module
* implement a high-level interface that might be consumed by flux
* fix deadlock caused by cluster cache event handler
* ClusterCache should return error if requested group kind not found
* remove obsolete tests
* apply reviewer notes
