Commit graph

410 commits

Author SHA1 Message Date
Alexander Matyushentsev
51998e0846
feat: argocd-util settings resource-overrides list-actions (#3616) 2020-05-19 14:46:46 -07:00
Shuhei Kitagawa
f95004c428
fix: Allow CLI version command to succeed without server connection (#3049) (#3550) 2020-05-19 14:21:34 +02:00
May Zhang
ec23d917eb
feat: adding failure retry (#3548)
* Initial Try of failure retry

* Get failureRetryCount and failureRetryPeriodSecond from command line args.

* Get failureRetryCount and failureRetryPeriodSecond from command line args.

* Get failureRetryCount and failureRetryPeriodSecond from command line args.

* Get failureRetryCount and failureRetryPeriodSecond from command line args.

* Update logic to find out if we should retry.

* 1. add retry wrapper to only argo client.
2. change to env variables instead of command line arguments.

* keep imports grouped

* resolve merge conflict
2020-05-18 09:51:03 -07:00
Alexander Matyushentsev
fe8d47e0ea
feat: move engine code to argoproj/gitops-engine repo (#3599) 2020-05-15 14:39:29 -07:00
Alexander Matyushentsev
192ee93fc4
feat: Gitops engine (#3066)
* Move utils packages that are required for gitops engine under engine/pkg/utils package.
Following changes were implemented:
* util/health package is split into two parts: resource health assessement & resource health assessement and moved into engine/pkg/utils
* utils packages moved: Closer and Close method of util package moved into engine/pkg/utils/io package
* packages diff, errors, exec, json, kube and tracing moved into engine/pkg/utils

* Move single cluster caching into engine/kube/cache package

* move sync functionality to engine/kube/sync package

* remove dependency on metrics package from engine/pkg/utils/kube/cache

* move annotation label definitions into engine/pkg/utils/kube/sync

* make sure engine/pkg has no dependencies on other argo-cd packages

* allow importing engine as a go module

* implement a high-level interface that might be consumed by flux

* fix deadlock caused by cluster cache event handler

* ClusterCache should return error if requested group kind not found

* remove obsolete tests

* apply reviewer notes
2020-05-15 10:01:18 -07:00
Shuhei Kitagawa
c2ff86e8b2
chore: Change cli log to logrus (#3566) 2020-05-15 17:49:35 +02:00
jannfis
02b3c61fd9
feat: Introduce diff normalizer knobs and allow for ignoring aggregated cluster roles (#2382) (#3076)
* Add the ability to ignore rules added by aggregated cluster roles
2020-05-13 13:34:43 -07:00
Christine Banek
046406e7d3
fix: Fix login with port forwarding (#3574)
The argocd command line supports using the --port-forward options
to allow you to connect to an argocd without an ingress rule.  This
is especially useful for command line automation of new environments.

But login doesn't respect port-forward - making it impossible to login
to argocd to be able to later create apps.  App creation works fine
with port-forwarding after being able to login.
2020-05-13 10:28:42 -07:00
Alexander Matyushentsev
24fa758444
fix: enable redis retries; add redis request duration metric (#3575) 2020-05-12 14:39:18 -07:00
Shuhei Kitagawa
9a17103830
feat: Add --logformat switch to API server, repository server and controller (#3408) 2020-05-05 14:03:48 +02:00
SB
e5d4673eac
feat: Add a Get Repo command to see if Argo CD has a repo (#3523)
* fix: Updating to jsonnet v1.15.0 fix issue #3277

* feat: Changes from codegen, adding a repository gt service

* feat: Adding a get repository command

* Retrigger CI pipeline

* refactor: delete deprecated option on Get
refactor printing getcommand result
Getrepository() dependent on rbac enforcement

* fix: setting Get repo command to get
2020-05-04 09:20:48 +02:00
Alexander Matyushentsev
e845478a96
docs: v1.5.3 changelog (#3526)
* docs: v1.5.3 changelog

* address reviewer notes
2020-04-30 13:17:44 -07:00
Alexander Matyushentsev
842a3d12f6
feat: add redis metrics to application controller and api server (#3500)
* add redis metrics to application controller and api server

* fix failed test
2020-04-28 12:52:03 -07:00
Alexander Matyushentsev
9b142c799a
fix: 'argocd sync' does not take into account IgnoreExtraneous annotation (#3486) 2020-04-28 08:49:07 -07:00
May Zhang
d77072b534
fix: Set root path (#3475)
* Set root path

* updated http mux if --rootpath is set during server startup.
updated baseHRef if --rootpath is set.
added --grpc-web-root-path for CLI.

* added rootpath as part of config context name

* clean up not used variables.
2020-04-27 08:35:58 -07:00
Alexander Matyushentsev
8a77075cff
fix: CLI renders flipped diff results (#3480) 2020-04-24 10:18:15 -07:00
Alexander Matyushentsev
f5b600d4af
feat: limit the maximum number of concurrent login attempts (#3467)
* feat: limit the maximum number of concurrent login attempts

* unit test rate limiter

* address reviewer questions
2020-04-23 12:33:17 -07:00
Alexander Matyushentsev
89774fef17
fix: argocd-util kubeconfig should use RawRestConfig to export config (#3447)
* fix: argocd-util kubeconfig should use RawRestConfig to export config

* document 'argocd-util kubeconfig' command
2020-04-21 13:45:20 +02:00
jannfis
75d9f23adb
chore: Migrate golangci-lint into CircleCI tests (#3427) 2020-04-16 08:55:13 -07:00
Alexander Matyushentsev
16c6eaf9ae
feat: support user specified account token ids (#3425) 2020-04-15 15:19:25 -07:00
jannfis
476cb655b7
fix: Make CLI downwards compatible using old repository API (#3418) 2020-04-15 23:05:17 +02:00
Alexander Matyushentsev
05f5a79923
feat: support separate Kustomize version per application (#3414) 2020-04-15 12:04:31 -07:00
May Zhang
3dbc330cf0
fix: app diff --local support for helm repo. #3151 (#3407)
* Fixing argocd app diff when using helm repo

* adding test code

* get rid of optional parameter

* get rid of optional parameter

* Added test case

* Fix failed tests
2020-04-14 08:13:38 -07:00
jannfis
8ad928330f
chore: Fix a bunch of lint issues (#3412)
* chore: Fix linter complaints
2020-04-14 08:01:43 -07:00
Bruno Clermont
355e77e56f
feat: add support for dex prometheus metrics (#3249) 2020-04-14 07:53:59 -07:00
Alexander Matyushentsev
376d79a454
feat: add settings troubleshooting commands to the 'argocd-util' binary (#3398)
* feat: add settings troubleshooting commands to the 'argocd-util' binary
2020-04-14 07:51:16 -07:00
rachelwang20
d326daef62
Rebase (#3333) 2020-04-02 11:08:24 -07:00
May Zhang
98337065ae
fix: Fixing could not find plugin issue when app sync and app diff (#3326)
* Fixing could not find plugin issue when app sync and app diff

* Fixing codegen error

* Revert "Fixing codegen error"

This reverts commit b2dcfb81

* Fixing codegen error

* If user is logged in, settings API would return ConfigManagementPlugins
2020-04-02 09:50:42 -07:00
Shuwei Hao
c71bfc62ba
fix: update help info about argcd account can-i (#3310)
Signed-off-by: Shuwei Hao <haoshuwei24@gmail.com>
2020-03-30 11:49:03 +02:00
Alexander Matyushentsev
ac8ac14545
fix: SSO user unable to change local account password (#3297) (#3298)
* fix: SSO user unable to change local account password (#3297)

* apply code review notes
2020-03-29 10:35:25 +02:00
Alexander Matyushentsev
521f87fe5f
fix: convert 'namesuffix', 'nameprefix' string flags to boolean flags in 'argocd app unset' (#3300) 2020-03-27 20:26:22 -07:00
May Zhang
eef35a32ab
feat: Argocd App Unset Kustomize Override (#3289)
feat: Argocd App Unset Kustomize Override (#3289)
2020-03-26 15:35:55 -07:00
Alexander Matyushentsev
7fd7999e49
fix: increase max connections count to support clusters with very large number of CRDs (#3278) 2020-03-25 01:02:33 -07:00
Jesse Suen
4bbce1cb22
perf: reduce unnecessary K8s calls for CRDs during reconciliation (#3246)
* reduce K8s calls for CRDs during reconciliation
* additional metric labels to k8s API requests (server, verb, kind, namespace)
2020-03-18 03:28:31 -07:00
Alexander Matyushentsev
3c2be61827
feat: implement Service Account / Local Users (#3215)
* feat: implement Service Account / Local Users

* add local users documentation

* implement accounts management UI

* address code review notes
2020-03-17 15:31:37 -07:00
Jesse Suen
476b09cbbf
feat: improve api-server and controller performance (#3222)
* group read comparison settings during app reconciliation
* Reduce lock contention in clusterInfo::ensureSynced(). Add getRepoObj stats
* Remove additional source of lock contention
* Exclude the coordination.k8s.io/Lease resource

Co-authored-by: Alexander Matyushentsev <amatyushentsev@gmail.com>
2020-03-16 11:51:59 -07:00
Alexander Matyushentsev
20adad76ef
feat: Disable Admin Login (fixes #3019) (#3179)
feat: Disable Admin Login (fixes #3019) (#3179)
2020-03-04 15:26:07 -08:00
Alex Mironov
4d23fe8108
feat: add "service-account" flag to "cluster add" command (#3183) (#3184)
* Add "skip-rbac-setup" flag to "cluster add" command

"InstallClusterManagerRBAC" method of the clusterauth package
is somewhat opinionated about rolebindings and role definitions
for "argocd-manager" SA. Sometimes it is desirable however to manually
pre-configure such bindings and/or modify them in order to comply
with existing infrastructure requirements.

This commit introduces a new option "--skip-rbac-setup" which allows operator
to skip the aforementioned "InstallClusterManagerRBAC" method call.

* Modified --skip-rbac-setup into --service-account flag

* use reference instead of hardoded SA name
2020-03-04 14:25:36 +01:00
jannfis
ea57d15a80
fix: Allow multiple hostnames per SSH known hosts entry and also allow IPv6 (#2814) (#3074)
* Allow multiple hostnames per SSH known hosts entry and also allow IPv6

* Satisfy lint monster

* And also satisfy the other lint monster
2020-02-10 14:11:50 -08:00
Alex Collins
ebc048167c
feat: Supports the validate-false option at an app level. Closes #1063 (#2542) 2020-02-10 14:09:25 -08:00
Jesse Suen
66d496d1ef
fix: argocd-util backup produced truncated backups. import app status (#3096) 2020-02-10 11:24:33 -08:00
jannfis
722d5b02d9
fix: Correct usage text for repo add command regarding insecure repos (#3068)
* Correct usage information for repo add command regarding insecure repositories

* Retrigger stuck CI
2020-01-31 12:50:39 -08:00
Sean Dukehart
57eeaa4231
Changes to enable helm --set-file (#2752)
Necessary STDIN changes to support Windows

Added support for SE Linux

Informational message about linting OOM

Updated due to latest helm stable being 3.x
2020-01-29 08:26:05 -08:00
Daniel Beal
e22f946415 fix: Jsonnet TLA parameters of same type are overwritten (#3022)
* TLA parameters of same time are overwritten

When updating an application deployed with existing TLAs using the following command:

```
argocd app set m2-jsonnet --jsonnet-tla-code "myTLAVar={hello:'world'}"
```

The all the TLAs of type code will be cleared and not preserved as would be expected of a set. The only TLA remaining is `myTLAVar`.
This will set the behavior of TLAs to match that of extVars

Signed-off-by: Daniel Beal <dbeal@wiser.com>

* revert gopkg.lock

* add unit tests

* fix go formatting
2020-01-24 10:34:53 -08:00
Joseph Mulloy
3c6715a6f9 fix: Replace aws-iam-authenticator to support IRSA (#3010)
Replace aws-iam-authenticator with aws cli to support EKS cluster auth
via IAM Roles for Service Accounts (IRSA)

See https://aws.amazon.com/blogs/opensource/introducing-fine-grained-iam-roles-service-accounts/
2020-01-24 10:32:33 -08:00
Dário Nascimento
4cf02fd813 Hide bindPW in dex config (#3025)
Like https://github.com/argoproj/argo-cd/issues/2536 , the DEX password for LDAP is being leaked in a command that prints configuration.
This change not only hides the bindPW but also changes the logging level to trace so that by default, the configuration is not leaked to logs.
2020-01-24 08:37:14 -08:00
Masayuki Ishii
17d217c2d6 feat: Add argocd cmd for Windows #2121 (#3015)
* fix: Explicitly cast Stdin file descriptors to int

Signed-off-by: Masayuki Ishii <masa213f@gmail.com>

* feat: Add the windows CLI

Signed-off-by: Masayuki Ishii <masa213f@gmail.com>

* fix: Fix warning message

Signed-off-by: Masayuki Ishii <masa213f@gmail.com>
2020-01-24 08:18:00 +01:00
jannfis
cc6c67d343 fix: Provide correct example for repocreds add command (#3016) (#3017)
* Correct SSH example for repocreds add command

* More example & comment fixes for repo and repocreds commands
2020-01-22 10:34:34 -08:00
Alexander Matyushentsev
da6da2a229
fix: argocd diff should use NormalizedLiveState (#2943) 2020-01-06 15:39:54 -08:00
Alexander Matyushentsev
bc33f19333
fix: diff local ignore kustomize build options (#2942) 2020-01-03 18:56:55 -08:00