* refactor: remove app destination inferrence logic
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* simplify
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* more fixes
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* more fixes
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* codegen
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* fix mocks
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* simplify
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* clusters all the way down
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* simplify
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* test
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* lint
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* tidy
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* be less radical
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
---------
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* Populate destination name when destination server is specified
Signed-off-by: Adrian Aneci <aneci@adobe.com>
* Lint nit
Signed-off-by: Adrian Aneci <aneci@adobe.com>
* Trigger CI
Signed-off-by: Adrian Aneci <aneci@adobe.com>
---------
Signed-off-by: Adrian Aneci <aneci@adobe.com>
* add lastTransitionTime to health status
Signed-off-by: Manuel Kieweg <mail@manuelkieweg.de>
* address first feedback
Signed-off-by: Manuel Kieweg <mail@manuelkieweg.de>
* set transition time if health status is unknown
Signed-off-by: Manuel Kieweg <mail@manuelkieweg.de>
* extend health improvement tests
Signed-off-by: Manuel Kieweg <mail@manuelkieweg.de>
* add apoplication controller test
Signed-off-by: Manuel Kieweg <mail@manuelkieweg.de>
* use require for NoError
Signed-off-by: Manuel Kieweg <mail@manuelkieweg.de>
* more extensive tests for health state changes
Signed-off-by: Manuel Kieweg <mail@manuelkieweg.de>
* Apply suggestions from code review
Co-authored-by: Blake Pettersson <blake.pettersson@gmail.com>
Signed-off-by: Manuel Kieweg <2939765+mkieweg@users.noreply.github.com>
* Code review suggestions
Signed-off-by: Manuel Kieweg <mail@manuelkieweg.de>
* remove obsolete assert
Signed-off-by: Manuel Kieweg <mail@manuelkieweg.de>
* Change LastTransitionTime field to pointer type
Due to implementation limitations, setting LastTransitionTime at the resource level is challenging.
Converting it to a pointer type allows it to be skipped at the resource level and prevents it from appearing
in .status.resources of the Application CR. Additionally, it doesn’t provide much value or have a known
use case right now.
Signed-off-by: Siddhesh Ghadi <sghadi1203@gmail.com>
* Resolve rebase conflicts
Signed-off-by: Siddhesh Ghadi <sghadi1203@gmail.com>
* Address review comment
Signed-off-by: Siddhesh Ghadi <sghadi1203@gmail.com>
* Trigger CI
Signed-off-by: Siddhesh Ghadi <sghadi1203@gmail.com>
---------
Signed-off-by: Manuel Kieweg <mail@manuelkieweg.de>
Signed-off-by: Manuel Kieweg <2939765+mkieweg@users.noreply.github.com>
Signed-off-by: Siddhesh Ghadi <sghadi1203@gmail.com>
Co-authored-by: Blake Pettersson <blake.pettersson@gmail.com>
Co-authored-by: Siddhesh Ghadi <sghadi1203@gmail.com>
* Adding skipSchemaValidation flag
Signed-off-by: Daniel Mosesson (soandos) <danielmosesson@gmail.com>
* Adding specific test for skip schema validation
Signed-off-by: Daniel Mosesson (soandos) <danielmosesson@gmail.com>
* Fix merge conflict
Signed-off-by: Daniel Mosesson (soandos) <danielmosesson@gmail.com>
* Fixing index.yaml to support helm 3.16
Signed-off-by: Daniel Mosesson (soandos) <danielmosesson@gmail.com>
---------
Signed-off-by: Daniel Mosesson (soandos) <danielmosesson@gmail.com>
Co-authored-by: Daniel Mosesson (soandos) <danielmosesson@gmail.com>
* Add `Prompt`, with `prompts.enabled` setting in `argocd-cm`
Signed-off-by: David Wu <155603967+david-wu-octopus@users.noreply.github.com>
* Make `SettingsOpts`, `SettingsOpts.ArgocdCMPath`, `SettingsOpts.CreateSettingsManager()` and `commandContext.CreateSettingsManager()` exportable
Signed-off-by: David Wu <155603967+david-wu-octopus@users.noreply.github.com>
* Add `prompt_test.go`
Signed-off-by: David Wu <155603967+david-wu-octopus@users.noreply.github.com>
* Refactor `NewPrompt()` and move into new package `utils`
Signed-off-by: David Wu <155603967+david-wu-octopus@users.noreply.github.com>
* Update `NewPrompt()` to use local config
Signed-off-by: David Wu <155603967+david-wu-octopus@users.noreply.github.com>
* Add `NewConfigurationCommand()`
Signed-off-by: David Wu <155603967+david-wu-octopus@users.noreply.github.com>
* Move `prompt_test.go`
Signed-off-by: David Wu <155603967+david-wu-octopus@users.noreply.github.com>
* Remove `prompt_test.go` for now
Signed-off-by: David Wu <155603967+david-wu-octopus@users.noreply.github.com>
* Add back and update `prompt_test.go`
Signed-off-by: David Wu <155603967+david-wu-octopus@users.noreply.github.com>
* Add `configuration_test.go`
Signed-off-by: David Wu <155603967+david-wu-octopus@users.noreply.github.com>
* Fix linting issues
Signed-off-by: David Wu <155603967+david-wu-octopus@users.noreply.github.com>
* Fix linting issues
Signed-off-by: David Wu <155603967+david-wu-octopus@users.noreply.github.com>
* Reverse early-termination logic in `Confirm()`
Signed-off-by: David Wu <155603967+david-wu-octopus@users.noreply.github.com>
* Rename `ArgocdCMPath` to `argocdCMPath`
Signed-off-by: David Wu <155603967+david-wu-octopus@users.noreply.github.com>
* Rename `SettingsOpts` to `settingsOpts`
Signed-off-by: David Wu <155603967+david-wu-octopus@users.noreply.github.com>
* Rename `CreateSettingsManager()` to `createSettingsManager()`
Signed-off-by: David Wu <155603967+david-wu-octopus@users.noreply.github.com>
* Rename `configuration` to `configure`
Signed-off-by: David Wu <155603967+david-wu-octopus@users.noreply.github.com>
* Further rename `configuration` to `configure`
Signed-off-by: David Wu <155603967+david-wu-octopus@users.noreply.github.com>
* Remove redundant Argo CD ConfigMap logic
Signed-off-by: David Wu <155603967+david-wu-octopus@users.noreply.github.com>
* Fix terminal output spacing
Signed-off-by: David Wu <155603967+david-wu-octopus@users.noreply.github.com>
* Make `argocd configure` use local config value as the default value for `--prompts-enabled`
Signed-off-by: David Wu <155603967+david-wu-octopus@users.noreply.github.com>
* Add global CLI flag `--force-prompts-enabled`
Signed-off-by: David Wu <155603967+david-wu-octopus@users.noreply.github.com>
* Update existing `prompt_test.go` test cases
Signed-off-by: David Wu <155603967+david-wu-octopus@users.noreply.github.com>
* Add test case for `(p *Prompt).Confirm()`
Signed-off-by: David Wu <155603967+david-wu-octopus@users.noreply.github.com>
* Add test cases for `GetBoolFlagWithFallback()` to `env_test.go`
Signed-off-by: David Wu <155603967+david-wu-octopus@users.noreply.github.com>
* Format imports
Signed-off-by: David Wu <155603967+david-wu-octopus@users.noreply.github.com>
* Further format imports and remove unused variable
Signed-off-by: David Wu <155603967+david-wu-octopus@users.noreply.github.com>
* Again format imports
Signed-off-by: David Wu <155603967+david-wu-octopus@users.noreply.github.com>
* Add fallback to `GetPromptsEnabled()`
Signed-off-by: David Wu <155603967+david-wu-octopus@users.noreply.github.com>
* Fix bug in `GetPromptsEnabled()`
Signed-off-by: David Wu <155603967+david-wu-octopus@users.noreply.github.com>
* Fix missing import
Signed-off-by: David Wu <155603967+david-wu-octopus@users.noreply.github.com>
* Add auto-generated docs for `argocd configure`
Signed-off-by: David Wu <155603967+david-wu-octopus@users.noreply.github.com>
* Add auto-generated docs for new global CLI flag `--force-prompts-enabled`
Signed-off-by: David Wu <155603967+david-wu-octopus@users.noreply.github.com>
* Update `NewPrompt()` to receive a `bool` rather than `*apiclient.ClientOptions` arg
Signed-off-by: David Wu <155603967+david-wu-octopus@users.noreply.github.com>
* Remove arg `fallback` from `GetPromptsEnabled()`
Signed-off-by: David Wu <155603967+david-wu-octopus@users.noreply.github.com>
* Add arg `useCLIOpts bool` to `GetPromptsEnabled()`
Signed-off-by: David Wu <155603967+david-wu-octopus@users.noreply.github.com>
* Make `config.LoadFlags()` exportable
Signed-off-by: David Wu <155603967+david-wu-octopus@users.noreply.github.com>
* Add tests for `GetPromptsEnabled()`
Signed-off-by: David Wu <155603967+david-wu-octopus@users.noreply.github.com>
* Fix linting errors in tests
Signed-off-by: David Wu <155603967+david-wu-octopus@users.noreply.github.com>
* Run `make codegen-local`
Signed-off-by: David Wu <155603967+david-wu-octopus@users.noreply.github.com>
---------
Signed-off-by: David Wu <155603967+david-wu-octopus@users.noreply.github.com>
* fixed doc comments and added unit tests
Signed-off-by: anandf <anjoseph@redhat.com>
* Added comments for the newly added unit tests
Signed-off-by: anandf <anjoseph@redhat.com>
* Refactored method name to deriveServiceAccountToImpersonate
Signed-off-by: anandf <anjoseph@redhat.com>
* Using const name in return value
Signed-off-by: anandf <anjoseph@redhat.com>
* Added unit tests for argocd proj add-destination-service-accounts
Signed-off-by: anandf <anjoseph@redhat.com>
* Fixed failing e2e tests
Signed-off-by: anandf <anjoseph@redhat.com>
* Fix linting errors
Signed-off-by: anandf <anjoseph@redhat.com>
* Using require package instead of assert and fixed code generation
Signed-off-by: anandf <anjoseph@redhat.com>
* Removed parallel execution of tests for sync with impersonate
Signed-off-by: anandf <anjoseph@redhat.com>
* Added err checks for glob validations
Signed-off-by: anandf <anjoseph@redhat.com>
* Fixed e2e tests for sync impersonation
Signed-off-by: anandf <anjoseph@redhat.com>
* Using consistently based expects in E2E tests
Signed-off-by: anandf <anjoseph@redhat.com>
* Added more unit tests and fixed go generate
Signed-off-by: anandf <anjoseph@redhat.com>
* Fixed failed lint errors, unit and e2e test failures
Signed-off-by: anandf <anjoseph@redhat.com>
* Fixed goimports linter issue
Signed-off-by: anandf <anjoseph@redhat.com>
* Added code comments and added few missing unit tests
Signed-off-by: anandf <anjoseph@redhat.com>
* Added missing unit test for GetDestinationServiceAccounts method
Signed-off-by: anandf <anjoseph@redhat.com>
* Fixed goimports formatting with local for project_test.go
Signed-off-by: anandf <anjoseph@redhat.com>
* Corrected typo in a field name additionalObjs
Signed-off-by: anandf <anjoseph@redhat.com>
* Fixed failing unit tests
Signed-off-by: anandf <anjoseph@redhat.com>
---------
Signed-off-by: anandf <anjoseph@redhat.com>
* fix: refine server deny check
Fixes#19804. The deny destination check can be made more intuitive by
doing the following:
* short-circuit any deny destination
* first, for any deny server destination, _also_ check if the namespace matches
* for any deny namespace destination, reject as before
Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
* fix: also assert that server matches on ns deny
Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
---------
Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
* chore: transmit manifest-generate-path resources to the cmp-server for plugin-based applications
Signed-off-by: Javier Solana <javier.solana@cabify.com>
* use SecureJoin
Signed-off-by: Javier Solana <javier.solana@cabify.com>
* make cmp manifests generation using manifest generate path annotation configurable by environment variable
Signed-off-by: Javier Solana <javier.solana@cabify.com>
* fix missing doc running codegen-local
Signed-off-by: Javier Solana <javier.solana@cabify.com>
* set reposerver.plugin.enable.manifests.generation.using.annotations false by default
Signed-off-by: Javier Solana <javier.solana@cabify.com>
* define ARGOCD_REPO_SERVER_PLUGIN_ENABLE_GENERATE_MANIFESTS_USING_MANIFEST_GENERATE_PATHS_ANNOTATION properly
Signed-off-by: Javier Solana <javier.solana@cabify.com>
* define ARGOCD_REPO_SERVER_PLUGIN_ENABLE_GENERATE_MANIFESTS_USING_MANIFEST_GENERATE_PATHS_ANNOTATION properly
Signed-off-by: Javier Solana <javier.solana@cabify.com>
* Fix conflict
Signed-off-by: Javier Solana <javier.solana@cabify.com>
* autogenerate install manifests
Signed-off-by: Javier Solana <javier.solana@cabify.com>
* add note about common root path calculation for manifest paths annotation
Signed-off-by: Javier Solana <javier.solana@cabify.com>
* log common root path calculated
Signed-off-by: Javier Solana <javier.solana@cabify.com>
* app path must be the lower common path
Signed-off-by: Javier Solana <javier.solana@cabify.com>
* tweaks
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
---------
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Co-authored-by: Javier Solana <javier.solana@cabify.com>
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* changed log file name convention
Signed-off-by: itaynvn-runai <itay.anavian@run.ai>
* fixed condition
Signed-off-by: itaynvn-runai <itay.anavian@run.ai>
* Update forwarder_overwrite.go
changed `appNamespace` to `namespace`.
as `appNamespace` will always be "argocd", and `namespace` is based on the actual k8s namespace, and will be unique.
so each log file name will always be unique, and descriptive.
Signed-off-by: itaynvn-runai <165032271+itaynvn-runai@users.noreply.github.com>
* Update forwarder_overwrite.go
added `container` to the file name
Signed-off-by: itaynvn-runai <165032271+itaynvn-runai@users.noreply.github.com>
---------
Signed-off-by: itaynvn-runai <itay.anavian@run.ai>
Signed-off-by: itaynvn-runai <165032271+itaynvn-runai@users.noreply.github.com>
* Implementation of app sync with impersonation support
Signed-off-by: anandf <anjoseph@redhat.com>
* negation test
Signed-off-by: Mangaal <angommeeteimangaal@gmail.com>
* Update doc comments to remove server name as its not supported.
Co-authored-by: Ishita Sequeira <46771830+ishitasequeira@users.noreply.github.com>
Signed-off-by: Anand Francis Joseph <anandfrancis.joseph@gmail.com>
* Update glob pattern check for matching destinations.
Co-authored-by: Ishita Sequeira <46771830+ishitasequeira@users.noreply.github.com>
Signed-off-by: Anand Francis Joseph <anandfrancis.joseph@gmail.com>
* Corrected the code comments for namespace field and destination matching logic
Signed-off-by: anandf <anjoseph@redhat.com>
* Added missing generated files
Signed-off-by: anandf <anjoseph@redhat.com>
* Fixed golint errors caused due to to gofumpt validations
Signed-off-by: anandf <anjoseph@redhat.com>
* Fix golint errors with unit test code
Signed-off-by: anandf <anjoseph@redhat.com>
* Updated the go import ordering with local packages at the end
Signed-off-by: anandf <anjoseph@redhat.com>
* Addressed review comments
Signed-off-by: anandf <anjoseph@redhat.com>
* Fixed ES lint error caused due to missing class
Signed-off-by: anandf <anjoseph@redhat.com>
* Updated the documentation to address the review comments
Signed-off-by: anandf <anjoseph@redhat.com>
* Simplified the sync code and improved logs and error handling
Signed-off-by: anandf <anjoseph@redhat.com>
* Fixed E2E tests to fail when no sa is configured
Signed-off-by: anandf <anjoseph@redhat.com>
* Updated help message generated for CLI commands
Signed-off-by: anandf <anjoseph@redhat.com>
* Fixed failing tests due to default service account not used for sync operation
Signed-off-by: anandf <anjoseph@redhat.com>
* Fixed the error message when sync fails due to no matching sa
Signed-off-by: anandf <anjoseph@redhat.com>
* Removed repeating logs and added impersonation fields to logger
Signed-off-by: anandf <anjoseph@redhat.com>
* Made changes in the proposal to match the behaviour when no matching sa is found
Signed-off-by: Anand Francis Joseph <anjoseph@redhat.com>
---------
Signed-off-by: anandf <anjoseph@redhat.com>
Signed-off-by: Mangaal <angommeeteimangaal@gmail.com>
Signed-off-by: Anand Francis Joseph <anandfrancis.joseph@gmail.com>
Signed-off-by: Anand Francis Joseph <anjoseph@redhat.com>
Co-authored-by: Mangaal <angommeeteimangaal@gmail.com>
Co-authored-by: Ishita Sequeira <46771830+ishitasequeira@users.noreply.github.com>
* chore(deps): bump k8s libs from 0.29.6 to 0.30.2
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* latest commit
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* update known types
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* bump controller-runtime to a version that's compatible with go-client 0.30.x
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* update go-to-protobuf flag
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* handle new requirements for proto file locations
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* bump gitops-engine version
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* fix openapigen
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* remove toolchain
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* bump gitops-engine version
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* chore: enable lint for deprecated symbols
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* chore: bump to k8s 1.31
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* codegen
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* don't be generic if you don't have to be
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* don't be generic if you don't have to be
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* new commit
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* use gitops-engine commit
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
---------
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* chore(deps): bump k8s libs from 0.29.6 to 0.30.2
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* latest commit
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* update known types
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* bump controller-runtime to a version that's compatible with go-client 0.30.x
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* update go-to-protobuf flag
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* handle new requirements for proto file locations
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* bump gitops-engine version
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* fix openapigen
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* remove toolchain
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* bump gitops-engine version
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* no need for replace now
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
---------
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* feat(sourceNamespace): Regex Support
Signed-off-by: Arthur <arthur@arthurvardevanyan.com>
* feat(sourceNamespace): Separate exactMatch into patternMatch
Signed-off-by: Arthur <arthur@arthurvardevanyan.com>
---------
Signed-off-by: Arthur <arthur@arthurvardevanyan.com>
* feat(helm): support `--kube-version`, `--api-versions`, and `--namespace` (#19325)
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* codegen
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* handle kube and api versions per-source
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* lint
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* fix nil ref error
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* fix nil ref error due to not handling multi-source in verify path
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* change casing to be more consistent with helm
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* Kustomize too
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* simplify verify path
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* add e2e tests for kustomize
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* reorder for consistency, and add more tests
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* Update docs/operator-manual/application.yaml
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
---------
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
Co-authored-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
* fix: update Content-Disposition filename extension to .log
Downloaded log files to have the extension ".log" instead of ".txt"
Signed-off-by: Rajat Toshniwal <rnt.rajat@gmail.com>
* chore: update log file extension for downloaded logs
Signed-off-by: Rajat Toshniwal <rnt.rajat@gmail.com>
* Update docs/operator-manual/upgrading/2.12-2.13.md
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
---------
Signed-off-by: Rajat Toshniwal <rnt.rajat@gmail.com>
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* Fixes https://github.com/argoproj/argo-cd/issues/9607
for BitBucketServer by allowing to pass a CM holding trusted certificates. Refactors implementation for GitLab.
Signed-off-by: asjervanasten <asjer94@live.com>
* Fixes https://github.com/argoproj/argo-cd/issues/9607
for BitBucketServer by allowing to pass a CM holding trusted certificates. Refactors implementation for GitLab.
Signed-off-by: asjervanasten <asjer94@live.com>
* Implemented review feedback. Util class for retrieving Secret and CM, renamed caRef.
Signed-off-by: asjervanasten <asjer94@live.com>
---------
Signed-off-by: asjervanasten <asjer94@live.com>
* fix: status.sync.comparedTo should use replace patch strategy
Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
* add e2e tests
Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
---------
Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
* chore: Update USERS.md (#17683)
Add Shield.com as one of the users in the USER.md file
Signed-off-by: suhas-chikkanna <162577490+suhas-chikkanna@users.noreply.github.com>
sec: validate project before execute action
Signed-off-by: pashakostohrys <pavel@codefresh.io>
* sec: validate a project before execute an action
Signed-off-by: pashakostohrys <pavel@codefresh.io>
---------
Signed-off-by: pashakostohrys <pavel@codefresh.io>
Co-authored-by: suhas-chikkanna <162577490+suhas-chikkanna@users.noreply.github.com>
* fix: policies in namespaces
The introduction of applications in any namespace doesn't appear to include support for specifying namespaces in rbac policy objects. This causes valid rbac objects (like `some-project/some-namespace/some-application`) to fail when they are really valid. Update the regex to include the ability to specify a namespace.
Signed-off-by: Bryce Lowe <blowe@patreon.com>
* fix: update verbiage of failing test
Signed-off-by: Bryce Lowe <blowe@patreon.com>
* feedback: test for policy and project
Signed-off-by: Bryce Lowe <blowe@patreon.com>
* fix: update test name
Signed-off-by: Bryce Lowe <blowe@patreon.com>
---------
Signed-off-by: Bryce Lowe <blowe@patreon.com>
A bug was reported, where an applicationset with an empty elements
array, when created with `argocd appset create <filename>.yaml` gets a
`...list.elements: Required value` error.
My hypothesis is that when calling the K8s API, golang JSON marshalling
mangles the empty `elements` array to `nil`, rather than creating an
empty array when submitting the `POST`.
Still need to figure out why the same setup seemingly works fine when
the same appset is in an app-of-apps.
Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
useful for argocd-servers which are not running in AWS and want to add multiple EKS clusters using
separate keys instead of assuming roles
#16766
Signed-off-by: Isaac Gaskin <isaac.gaskin@circle.com>
Co-authored-by: Soumya Ghosh Dastidar <44349253+gdsoumya@users.noreply.github.com>
* feat: PostDelete hooks support
Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
---------
Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
* feat: support components in kustomize
Signed-off-by: pashakostohrys <pavel@codefresh.io>
* feat: support components in kustomize
Signed-off-by: pashakostohrys <pavel@codefresh.io>
* feat: support components in kustomize
Signed-off-by: pashakostohrys <pavel@codefresh.io>
* feat: support components in kustomize
Signed-off-by: pashakostohrys <pavel@codefresh.io>
* fix: typo in kustomization word
Signed-off-by: pashakostohrys <pavel@codefresh.io>
* fix: typo in kustomization word
Signed-off-by: pashakostohrys <pavel@codefresh.io>
* fix: typo in kustomization word
Signed-off-by: pashakostohrys <pavel@codefresh.io>
* fix: typo in kustomization word
Signed-off-by: pashakostohrys <pavel@codefresh.io>
---------
Signed-off-by: pashakostohrys <pavel@codefresh.io>
* add retry logic for k8s client
Signed-off-by: Pavel Aborilov <aborilov@gmail.com>
* add docs for retry logic and envs to manifests
Signed-off-by: Pavel Aborilov <aborilov@gmail.com>
---------
Signed-off-by: Pavel Aborilov <aborilov@gmail.com>
Signed-off-by: Pavel <aborilov@gmail.com>
* chore(deps): upgrade k8s version and client-go
Signed-off-by: fengshunli <1171313930@qq.com>
* revert bad merge
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* fix codegen
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* fix codegen
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* fix: check for double definition
As found in #13965 (and as a follow-up to #13999), we also need to
define what happens if _both_ managedNamespaceMetadata _and_ an
Application manifest are both defined for the same namespace.
The idea here is that if that happens, we emit an
`ApplicationConditionRepeatedResourceWarning`, and set the sync status
to `Unknown`, since it's unclear what is supposed to happen.
The user will then have the option of removing one of the two
definitions.
Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
* fix: check for double definition
A simpler fix - don't add a managed namespace to the targetObjs list if
a namespace already exists in the application source.
Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
* build: extra space in doc
Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
* build: extra space in doc, again
Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
* chore: bump gitops-engine
Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
---------
Signed-off-by: fengshunli <1171313930@qq.com>
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
Co-authored-by: fengshunli <1171313930@qq.com>
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
the absence of the setting potentially causes ENHANCE_YOUR_CALM
Signed-off-by: phanama <yudiandreanp@gmail.com>
Co-authored-by: Dan Garfield <dan@codefresh.io>
* feat(appset): add option to disable SCM providers entirely (#14246)
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* clarify docs
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* more clarification, small refactor
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* more clarification
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* fix test
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* refactor
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* fix test assertion
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* simplify test expectation
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
---------
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Co-authored-by: Ishita Sequeira <46771830+ishitasequeira@users.noreply.github.com>
* feat(appset): ignoreDifferences (#9101)
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* better error messages
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* do better
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* docs
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* more tests, update docs
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* e2e test
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* expect auto-added fields
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* correct label
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* better
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* remove line that was reverted
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* Update docs/operator-manual/applicationset.yaml
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* remove line that mysteriously causes applicationset/utils unit tests to fail
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* login to fix test
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* maybe this will work, who knows
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* burn it all down
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* works on my machine
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
---------
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* fix(cli): add support for components with non-default names (#10200)
Co-Authored-By: maheshbaliga <mahesh.baliga@infracloud.io>
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
---------
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Co-authored-by: maheshbaliga <mahesh.baliga@infracloud.io>
* chore(actions): space instead of hyphen in action name (#14776)
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* new field for backwards-compatibility
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* align icons for maximum synergy
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* delete unused function
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* revert unnecessary changes
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* Update docs/operator-manual/upgrading/2.7-2.8.md
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
---------
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* fix(api): return 404 when the app is not found if a project is specified (#13393)
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
simplify, respond 404 on project specified but doesn't match, always fetch app
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
handle project updates
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* handle new endpoint, fix bad merge
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* docs
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
---------
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* Replace `os.Getenv("HOME")` with `os.UserHomeDir()`
`os.UserHomeDir()` is the recommended way of getting user home directory
Signed-off-by: Aryan Pathania <cont-a-pathania@mercari.com>
* Retrigger CI pipeline
Signed-off-by: Aryan Pathania <cont-a-pathania@mercari.com>
---------
Signed-off-by: Aryan Pathania <cont-a-pathania@mercari.com>
* fix: trigger refresh on changed ignoreDifferences
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* make the tests mean things
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
---------
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
This commit replaces `os.Setenv` with `t.Setenv` in tests. The
environment variable is automatically restored to its original value
when the test and all its subtests complete.
Reference: https://pkg.go.dev/testing#T.Setenv
Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
Signed-off-by: Robin Lieb <robin.j.lieb@gmail.com>
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
