Signed-off-by: Kevin Joe Harris <kevinjoeharris1@gmail.com>
Signed-off-by: S Kevin Joe Harris <59595928+Kevinjoeharris@users.noreply.github.com>
Co-authored-by: Regina Voloshin <regina.voloshin@codefresh.io>
* docs(proposal): manifest hydrator
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* whitespace
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* whitespace
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* remove old references to drySources as an array
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* rename fields
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* opinions
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* document limitations
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* updates
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* updates
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* multi-source is nondeterministic
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* Update docs/proposals/manifest-hydrator/commit-server/README.md
Co-authored-by: joe miller <joeym@joeym.net>
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
---------
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Co-authored-by: joe miller <joeym@joeym.net>
* fixed doc comments and added unit tests
Signed-off-by: anandf <anjoseph@redhat.com>
* Added comments for the newly added unit tests
Signed-off-by: anandf <anjoseph@redhat.com>
* Refactored method name to deriveServiceAccountToImpersonate
Signed-off-by: anandf <anjoseph@redhat.com>
* Using const name in return value
Signed-off-by: anandf <anjoseph@redhat.com>
* Added unit tests for argocd proj add-destination-service-accounts
Signed-off-by: anandf <anjoseph@redhat.com>
* Fixed failing e2e tests
Signed-off-by: anandf <anjoseph@redhat.com>
* Fix linting errors
Signed-off-by: anandf <anjoseph@redhat.com>
* Using require package instead of assert and fixed code generation
Signed-off-by: anandf <anjoseph@redhat.com>
* Removed parallel execution of tests for sync with impersonate
Signed-off-by: anandf <anjoseph@redhat.com>
* Added err checks for glob validations
Signed-off-by: anandf <anjoseph@redhat.com>
* Fixed e2e tests for sync impersonation
Signed-off-by: anandf <anjoseph@redhat.com>
* Using consistently based expects in E2E tests
Signed-off-by: anandf <anjoseph@redhat.com>
* Added more unit tests and fixed go generate
Signed-off-by: anandf <anjoseph@redhat.com>
* Fixed failed lint errors, unit and e2e test failures
Signed-off-by: anandf <anjoseph@redhat.com>
* Fixed goimports linter issue
Signed-off-by: anandf <anjoseph@redhat.com>
* Added code comments and added few missing unit tests
Signed-off-by: anandf <anjoseph@redhat.com>
* Added missing unit test for GetDestinationServiceAccounts method
Signed-off-by: anandf <anjoseph@redhat.com>
* Fixed goimports formatting with local for project_test.go
Signed-off-by: anandf <anjoseph@redhat.com>
* Corrected typo in a field name additionalObjs
Signed-off-by: anandf <anjoseph@redhat.com>
* Fixed failing unit tests
Signed-off-by: anandf <anjoseph@redhat.com>
---------
Signed-off-by: anandf <anjoseph@redhat.com>
* docs: proposal to introduce 'Prune/Delete=confirm' sync option value
Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
* add clarifications
Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
---------
Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
Co-authored-by: Dan Garfield <dan@codefresh.io>
* Implementation of app sync with impersonation support
Signed-off-by: anandf <anjoseph@redhat.com>
* negation test
Signed-off-by: Mangaal <angommeeteimangaal@gmail.com>
* Update doc comments to remove server name as its not supported.
Co-authored-by: Ishita Sequeira <46771830+ishitasequeira@users.noreply.github.com>
Signed-off-by: Anand Francis Joseph <anandfrancis.joseph@gmail.com>
* Update glob pattern check for matching destinations.
Co-authored-by: Ishita Sequeira <46771830+ishitasequeira@users.noreply.github.com>
Signed-off-by: Anand Francis Joseph <anandfrancis.joseph@gmail.com>
* Corrected the code comments for namespace field and destination matching logic
Signed-off-by: anandf <anjoseph@redhat.com>
* Added missing generated files
Signed-off-by: anandf <anjoseph@redhat.com>
* Fixed golint errors caused due to to gofumpt validations
Signed-off-by: anandf <anjoseph@redhat.com>
* Fix golint errors with unit test code
Signed-off-by: anandf <anjoseph@redhat.com>
* Updated the go import ordering with local packages at the end
Signed-off-by: anandf <anjoseph@redhat.com>
* Addressed review comments
Signed-off-by: anandf <anjoseph@redhat.com>
* Fixed ES lint error caused due to missing class
Signed-off-by: anandf <anjoseph@redhat.com>
* Updated the documentation to address the review comments
Signed-off-by: anandf <anjoseph@redhat.com>
* Simplified the sync code and improved logs and error handling
Signed-off-by: anandf <anjoseph@redhat.com>
* Fixed E2E tests to fail when no sa is configured
Signed-off-by: anandf <anjoseph@redhat.com>
* Updated help message generated for CLI commands
Signed-off-by: anandf <anjoseph@redhat.com>
* Fixed failing tests due to default service account not used for sync operation
Signed-off-by: anandf <anjoseph@redhat.com>
* Fixed the error message when sync fails due to no matching sa
Signed-off-by: anandf <anjoseph@redhat.com>
* Removed repeating logs and added impersonation fields to logger
Signed-off-by: anandf <anjoseph@redhat.com>
* Made changes in the proposal to match the behaviour when no matching sa is found
Signed-off-by: Anand Francis Joseph <anjoseph@redhat.com>
---------
Signed-off-by: anandf <anjoseph@redhat.com>
Signed-off-by: Mangaal <angommeeteimangaal@gmail.com>
Signed-off-by: Anand Francis Joseph <anandfrancis.joseph@gmail.com>
Signed-off-by: Anand Francis Joseph <anjoseph@redhat.com>
Co-authored-by: Mangaal <angommeeteimangaal@gmail.com>
Co-authored-by: Ishita Sequeira <46771830+ishitasequeira@users.noreply.github.com>
Bullets need to start with blank line, otherwise they don't render on read the docs. GitHub markdown doesn't require them but read the docs does
Signed-off-by: Cornelius Roemer <cornelius.roemer@gmail.com>
* Proposal for decoupling application sync from control plane user using impersonation
Signed-off-by: Anand Francis Joseph <anjoseph@redhat.com>
* Moved the proposal document to the right directory
Signed-off-by: Anand Francis Joseph <anjoseph@redhat.com>
* Update docs/decouple-application-sync-user-using-impersonation
Co-authored-by: Blake Pettersson <blake.pettersson@gmail.com>
Signed-off-by: Anand Francis Joseph <anandfrancis.joseph@gmail.com>
* Update docs/decouple-application-sync-user-using-impersonation
Co-authored-by: Blake Pettersson <blake.pettersson@gmail.com>
Signed-off-by: Anand Francis Joseph <anandfrancis.joseph@gmail.com>
* Update docs/decouple-application-sync-user-using-impersonation
Co-authored-by: Blake Pettersson <blake.pettersson@gmail.com>
Signed-off-by: Anand Francis Joseph <anandfrancis.joseph@gmail.com>
* Modified the proposal to have control in AppProjects alone instead of Application and AppProject
Signed-off-by: Anand Francis Joseph <anjoseph@redhat.com>
* Removed proposal placed in wrong directory and corrected examples
Signed-off-by: Anand Francis Joseph <anjoseph@redhat.com>
* Update docs/proposals/decouple-application-sync-user-using-impersonation
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Signed-off-by: Anand Francis Joseph <anandfrancis.joseph@gmail.com>
* Update docs/proposals/decouple-application-sync-user-using-impersonation
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Signed-off-by: Anand Francis Joseph <anandfrancis.joseph@gmail.com>
* Addressed review comments
Signed-off-by: Anand Francis Joseph <anjoseph@redhat.com>
* Additional corrections
Signed-off-by: anandf <anjoseph@redhat.com>
* Fixed alternative proposals section to include only AppProject based approach
Signed-off-by: anandf <anjoseph@redhat.com>
* Added information on impersonation and added related links
Signed-off-by: anandf <anjoseph@redhat.com>
* Added examples for remote cluster destination with the required RBAC access
Signed-off-by: anandf <anjoseph@redhat.com>
* Fixed clusterrole and clusterrolebinding creation commands
Signed-off-by: anandf <anjoseph@redhat.com>
* Addressed review comments from Akram
Signed-off-by: anandf <anjoseph@redhat.com>
* Corrected RBAC to include serviceaccounts that can be impersonated as swell
Signed-off-by: anandf <anjoseph@redhat.com>
* Address few more review comments from Ishita, Akram
Signed-off-by: anandf <anjoseph@redhat.com>
* Fixed a typo and updated the last updated date field
Signed-off-by: anandf <anjoseph@redhat.com>
* Added information of the sync hook behaviour and also corrected the namespace to match that of destination
Signed-off-by: Anand Francis Joseph <anjoseph@redhat.com>
* Changed proposal to meet the latest api design using destinationServiceAccounts
Signed-off-by: Anand Francis Joseph <anjoseph@redhat.com>
* Fixed proposal document to use destinationServiceAccounts struct
Signed-off-by: Anand Francis Joseph <anjoseph@redhat.com>
* Renamed proposal file to have .md extension
Signed-off-by: anandf <anjoseph@redhat.com>
* Using glob pattern instead of regex, and corrected the order of precedence when multiple matches are available
Signed-off-by: anandf <anjoseph@redhat.com>
---------
Signed-off-by: Anand Francis Joseph <anjoseph@redhat.com>
Signed-off-by: Anand Francis Joseph <anandfrancis.joseph@gmail.com>
Signed-off-by: anandf <anjoseph@redhat.com>
Co-authored-by: Blake Pettersson <blake.pettersson@gmail.com>
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* docs: Consistent proper case of Kubernetes
Signed-off-by: Adam Harvey <33203301+adamdmharvey@users.noreply.github.com>
* docs: Fix minor typo
Signed-off-by: Adam Harvey <33203301+adamdmharvey@users.noreply.github.com>
* fix: Proper case Kubernetes
Signed-off-by: Adam Harvey <33203301+adamdmharvey@users.noreply.github.com>
---------
Signed-off-by: Adam Harvey <33203301+adamdmharvey@users.noreply.github.com>
* docs(bounty): proposal for feature to hide annotations on secrets in the UI
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* fix file location
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
---------
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* Add proposal document for dynamic rebalancing of clusters across shards
Signed-off-by: ishitasequeira <ishiseq29@gmail.com>
* Use ConfigMap instead of Redis based on the feedback on the proposal
Signed-off-by: ishitasequeira <ishiseq29@gmail.com>
* address comments and add comments about not redistributing clusters for unhealthy controllers
Signed-off-by: ishitasequeira <ishiseq29@gmail.com>
* Address comments
Signed-off-by: ishitasequeira <ishiseq29@gmail.com>
---------
Signed-off-by: ishitasequeira <ishiseq29@gmail.com>
* add notifications API
we allow to list triggers, templates and services
Signed-off-by: Pavel <aborilov@gmail.com>
* fix: add notification manifest to tests
Signed-off-by: Pavel <aborilov@gmail.com>
* fix: add sleep to fix integration tests
for some reason notification configmap has old data, trying to fix with
the sleep
Signed-off-by: Pavel <aborilov@gmail.com>
* add proposal
Signed-off-by: Pavel <aborilov@gmail.com>
* more info to proposal
Signed-off-by: Pavel <aborilov@gmail.com>
* use struct for notifications objects instead of just strings
to be able easily extend API in the future return list of
trigger/template/service as list of structs
Signed-off-by: Pavel <aborilov@gmail.com>
Signed-off-by: Pavel <aborilov@gmail.com>
* docs: fix spelling mistakes in many docs files
Signed-off-by: Jesse Antoszyk <22500761+jcantosz@users.noreply.github.com>
* Update other instance of ksane -> kasane
Signed-off-by: Jesse Antoszyk <22500761+jcantosz@users.noreply.github.com>
* ran make codegen
