Elgato_dark/argo-cd
1
0
Fork 0
mirror of https://github.com/argoproj/argo-cd synced 2026-04-21 17:07:16 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 22

feat(ui): rename filter message status on SYNC STATUS view (#21061)

Browse source 
* rename filter message status

Signed-off-by: Atif Ali <atali@redhat.com>

* capitalize for cosistency with other filters

Signed-off-by: Atif Ali <atali@redhat.com>

* added tooltip for message filter

Signed-off-by: Atif Ali <atali@redhat.com>

* lint fix

Signed-off-by: Atif Ali <atali@redhat.com>

* Trigger workflow tests

Signed-off-by: Atif Ali <atali@redhat.com>

---------

Signed-off-by: Atif Ali <atali@redhat.com>
This commit is contained in:
Atif Ali 2025-01-08 17:17:27 -05:00 committed by GitHub
parent 6d27928965
commit b8508f2916
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 13 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
ui/src/app/applications/components/application-operation-state/application-operation-state.tsx
View file

@ -1,4 +1,4 @@
import {Checkbox, DropDown, Duration, NotificationType, Ticker, HelpIcon} from 'argo-ui';
import {Checkbox, DropDown, Duration, NotificationType, Ticker, HelpIcon, Tooltip} from 'argo-ui';
import * as moment from 'moment';
import * as PropTypes from 'prop-types';
import * as React from 'react';
@ -16,7 +16,7 @@ interface Props {
operationState: models.OperationState;
}
const buildResourceUniqueId = (res: Omit<models.ResourceRef, 'uid'>) => `${res.group}-${res.kind}-${res.version}-${res.namespace}-${res.name}`;
const FilterableMessageStatuses = ['configured', 'unchanged'];
const FilterableMessageStatuses = ['Changed', 'Unchanged'];
const Filter = (props: {filters: string[]; setFilters: (f: string[]) => void; options: string[]; title: string; style?: React.CSSProperties}) => {
const {filters, setFilters, options, title, style} = props;
@ -183,7 +183,12 @@ export const ApplicationOperationState: React.StatelessComponent<Props> = ({appl
}
if (pass && messageFilters.length !== 0) {
pass = messageFilters.some(filter => r.message?.toLowerCase().includes(filter.toLowerCase()));
pass = messageFilters.some(filter => {
if (filter === 'Changed') {
return r.message?.toLowerCase().includes('configured');
}
return r.message?.toLowerCase().includes(filter.toLowerCase());
});
}
return pass;
@ -210,7 +215,11 @@ export const ApplicationOperationState: React.StatelessComponent<Props> = ({appl
<Filter options={Healths} filters={healthFilters} setFilters={setHealthFilters} title='HEALTH' style={{marginRight: '5px'}} />
<Filter options={Statuses} filters={filters} setFilters={setFilters} title='STATUS' style={{marginRight: '5px'}} />
<Filter options={OperationPhases} filters={filters} setFilters={setFilters} title='HOOK' />
<Filter options={FilterableMessageStatuses} filters={messageFilters} setFilters={setMessageFilters} title='MESSAGE' />
<Tooltip placement='top-start' content='Filter on resources that have changed or remained unchanged'>
<div style={{display: 'inline-block'}}>
<Filter options={FilterableMessageStatuses} filters={messageFilters} setFilters={setMessageFilters} title='MESSAGE' />
</div>
</Tooltip>
</div>
</div>
<div className='argo-table-list'>