Issue #1579 - Impossible to sync to HEAD from UI if auto-sync is enabled (#1580)

This commit is contained in:
Alexander Matyushentsev 2019-05-07 14:54:51 -07:00 committed by GitHub
parent 6c0e21780c
commit b3ade6159e
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23

View file

@ -802,7 +802,7 @@ func (s *Server) Sync(ctx context.Context, syncReq *ApplicationSyncRequest) (*ap
return nil, status.Errorf(codes.FailedPrecondition, "application is deleting")
}
if a.Spec.SyncPolicy != nil && a.Spec.SyncPolicy.Automated != nil {
if syncReq.Revision != "" && syncReq.Revision != a.Spec.Source.TargetRevision {
if syncReq.Revision != "" && syncReq.Revision != util.FirstNonEmpty(a.Spec.Source.TargetRevision, "HEAD") {
return nil, status.Errorf(codes.FailedPrecondition, "Cannot sync to %s: auto-sync currently set to %s", syncReq.Revision, a.Spec.Source.TargetRevision)
}
}