Elgato_dark/argo-cd
1
0
Fork 0
mirror of https://github.com/argoproj/argo-cd synced 2026-04-21 17:07:16 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 22

fix: Validate chat button url only when chatUrl is set (#12655) (#12749)

Browse source 
* Validate chat button url only when chatUrl is set

Signed-off-by: Rouke Broersma <rouke.broersma@infosupport.com>

* Add Info Support to argocd USERS.md

Signed-off-by: Rouke Broersma <rouke.broersma@infosupport.com>

* Fix linter error

Signed-off-by: Rouke Broersma <rouke.broersma@infosupport.com>

* Fix linter error

Signed-off-by: Rouke Broersma <rouke.broersma@infosupport.com>

---------

Signed-off-by: Rouke Broersma <rouke.broersma@infosupport.com>
This commit is contained in:
Rouke Broersma 2023-03-07 20:34:23 +01:00 committed by GitHub
parent 0f500a5b21
commit 6953b43c9b
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 8 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
USERS.md
View file

@ -112,6 +112,7 @@ Currently, the following organizations are **officially** using Argo CD:
1. [imaware](https://imaware.health)
1. [Indeed](https://indeed.com)
1. [Index Exchange](https://www.indexexchange.com/)
1. [Info Support](https://www.infosupport.com/)
1. [InsideBoard](https://www.insideboard.com)
1. [Intuit](https://www.intuit.com/)
1. [Joblift](https://joblift.com/)

12
ui/src/app/ui-banner/ui-banner.tsx
View file

@ -69,11 +69,13 @@ export const Banner = (props: React.Props<any>) => {
chatBottomPosition = 85;
}
}
try {
const externalLink = new ExternalLink(chatUrl);
chatUrl = externalLink.ref;
} catch (InvalidExternalLinkError) {
chatUrl = 'invalid-url';
if (chatUrl) {
try {
const externalLink = new ExternalLink(chatUrl);
chatUrl = externalLink.ref;
} catch (InvalidExternalLinkError) {
chatUrl = 'invalid-url';
}
}
return (
<React.Fragment>