Elgato_dark/argo-cd
1
0
Fork 0
mirror of https://github.com/argoproj/argo-cd synced 2026-04-21 17:07:16 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 22

fix(notifications-catalog): Add nil check for notifications_catalog triggers (#14795)

Browse source 
* Add nil check for notifications_catalog triggers

Signed-off-by: Trung <trung.hoang@pricehubble.com>

* Use correct nil check

Signed-off-by: Trung <trung.hoang@pricehubble.com>

* Add missing catalog generation to makefile

Signed-off-by: Trung <trung.hoang@pricehubble.com>

* Revert changes to update-manifests.sh

Signed-off-by: Trung <trung.hoang@pricehubble.com>

---------

Signed-off-by: Trung <trung.hoang@pricehubble.com>
This commit is contained in:
Hoang Quoc Trung 2023-08-01 13:29:42 +02:00 committed by GitHub
parent 72754d7726
commit 4a7e6ec855
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 7 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
notifications_catalog/install.yaml
View file

@ -513,12 +513,13 @@ data:
- description: Application syncing has failed
send:
- app-sync-failed
when: app.status.operationState.phase in ['Error', 'Failed']
when: app.status.operationState != nil and app.status.operationState.phase in ['Error',
'Failed']
trigger.on-sync-running: |
- description: Application is being synced
send:
- app-sync-running
when: app.status.operationState.phase in ['Running']
when: app.status.operationState != nil and app.status.operationState.phase in ['Running']
trigger.on-sync-status-unknown: |
- description: Application status is 'Unknown'
send:
@ -528,7 +529,7 @@ data:
- description: Application syncing has succeeded
send:
- app-sync-succeeded
when: app.status.operationState.phase in ['Succeeded']
when: app.status.operationState != nil and app.status.operationState.phase in ['Succeeded']
kind: ConfigMap
metadata:
creationTimestamp: null

2
notifications_catalog/triggers/on-sync-failed.yaml
View file

@ -1,3 +1,3 @@
- when: app.status.operationState.phase in ['Error', 'Failed']
- when: app.status.operationState != nil and app.status.operationState.phase in ['Error', 'Failed']
description: Application syncing has failed
send: [app-sync-failed]

2
notifications_catalog/triggers/on-sync-running.yaml
View file

@ -1,3 +1,3 @@
- when: app.status.operationState.phase in ['Running']
- when: app.status.operationState != nil and app.status.operationState.phase in ['Running']
description: Application is being synced
send: [app-sync-running]

2
notifications_catalog/triggers/on-sync-succeeded.yaml
View file

@ -1,3 +1,3 @@
- when: app.status.operationState.phase in ['Succeeded']
- when: app.status.operationState != nil and app.status.operationState.phase in ['Succeeded']
description: Application syncing has succeeded
send: [app-sync-succeeded]