Elgato_dark/argo-cd
1
0
Fork 0
mirror of https://github.com/argoproj/argo-cd synced 2026-04-21 17:07:16 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 22

fix(ui): reduce rerender in pod log view (#22241)

Browse source 
Signed-off-by: linghaoSu <linghao.su@daocloud.io>
This commit is contained in:
Linghao Su 2025-03-10 01:39:09 +08:00 committed by GitHub
parent e3b333a860
commit 4202168c44
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 8 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
ui/src/app/applications/components/pod-logs-viewer/pod-logs-viewer.tsx
View file

@ -175,7 +175,11 @@ export const PodsLogsViewer = (props: PodLogsProps) => {
}),
retryWhen(errors => errors.pipe(delay(500)))
)
.subscribe(log => setLogs(previousLogs => previousLogs.concat(log)));
.subscribe(log => {
if (log.length) {
setLogs(previousLogs => previousLogs.concat(log));
}
});
return () => logsSource.unsubscribe();
}, [applicationName, applicationNamespace, namespace, podName, group, kind, name, containerName, tail, follow, sinceSeconds, filter, previous, matchCase]);
@ -247,8 +251,10 @@ export const PodsLogsViewer = (props: PodLogsProps) => {
</div>
</div>
);
const preferenceLoader = React.useCallback(() => services.viewPreferences.getPreferences(), []);
return (
<DataLoader load={() => services.viewPreferences.getPreferences()}>
<DataLoader load={preferenceLoader}>
{(prefs: ViewPreferences) => {
return (
<React.Fragment>