From 22dcc1e87d97c533726f608aa0c6ebe5dd77baa3 Mon Sep 17 00:00:00 2001 From: Alexander Matyushentsev Date: Tue, 26 May 2020 10:52:12 -0700 Subject: [PATCH] fix: prevent possible null pointer dereference error in TestAddHelmRepoInsecureSkipVerify test (#3650) --- test/e2e/repo_management_test.go | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/test/e2e/repo_management_test.go b/test/e2e/repo_management_test.go index 7888264480..ad5a0fd95b 100644 --- a/test/e2e/repo_management_test.go +++ b/test/e2e/repo_management_test.go @@ -121,15 +121,24 @@ func TestAddHelmRepoInsecureSkipVerify(t *testing.T) { "--insecure-skip-server-verification", "--tls-client-cert-path", repos.CertPath, "--tls-client-cert-key-path", repos.CertKeyPath) - assert.NoError(t, err) + + if !assert.NoError(t, err) { + return + } conn, repoClient, err := fixture.ArgoCDClientset.NewRepoClient() - assert.NoError(t, err) + if !assert.NoError(t, err) { + return + } + defer argoio.Close(conn) repo, err := repoClient.List(context.Background(), &repositorypkg.RepoQuery{}) - assert.NoError(t, err) + if !assert.NoError(t, err) { + return + } + exists := false for i := range repo.Items { if repo.Items[i].Repo == fixture.RepoURL(fixture.RepoURLTypeHelm) {