Elgato_dark/argo-cd
1
0
Fork 0
mirror of https://github.com/argoproj/argo-cd synced 2026-05-24 01:38:43 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

fix: prevent possible null pointer dereference error in TestAddHelmRepoInsecureSkipVerify test (#3650)

Browse source
This commit is contained in:
Alexander Matyushentsev 2020-05-26 10:52:12 -07:00 committed by GitHub
parent 91d5d7e37b
commit 22dcc1e87d
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 12 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
test/e2e/repo_management_test.go
View file

@ -121,15 +121,24 @@ func TestAddHelmRepoInsecureSkipVerify(t *testing.T) {
"--insecure-skip-server-verification",
"--tls-client-cert-path", repos.CertPath,
"--tls-client-cert-key-path", repos.CertKeyPath)
assert.NoError(t, err)
if !assert.NoError(t, err) {
return
}
conn, repoClient, err := fixture.ArgoCDClientset.NewRepoClient()
assert.NoError(t, err)
if !assert.NoError(t, err) {
return
}
defer argoio.Close(conn)
repo, err := repoClient.List(context.Background(), &repositorypkg.RepoQuery{})
assert.NoError(t, err)
if !assert.NoError(t, err) {
return
}
exists := false
for i := range repo.Items {
if repo.Items[i].Repo == fixture.RepoURL(fixture.RepoURLTypeHelm) {