From ecb1d21953f32e163e8a67aa99d7bddb5baaeeb6 Mon Sep 17 00:00:00 2001
From: Matej Baco <matejbacocom@gmail.com>
Date: Sat, 5 Feb 2022 16:38:08 +0100
Subject: [PATCH] Fixed Bitly response parsing

---
 src/Appwrite/Auth/OAuth2/Bitly.php  | 18 +++++++++++++-----
 src/Appwrite/Auth/OAuth2/Github.php |  8 ++++++--
 2 files changed, 19 insertions(+), 7 deletions(-)

diff --git a/src/Appwrite/Auth/OAuth2/Bitly.php b/src/Appwrite/Auth/OAuth2/Bitly.php
index 4b7e525a76..fb1cb57e18 100644
--- a/src/Appwrite/Auth/OAuth2/Bitly.php
+++ b/src/Appwrite/Auth/OAuth2/Bitly.php
@@ -65,7 +65,7 @@ class Bitly extends OAuth2
     protected function getTokens(string $code): array
     {
         if(empty($this->tokens)) {
-            $this->tokens = \json_decode($this->request(
+            $response = $this->request(
                 'POST',
                 $this->resourceEndpoint . 'oauth/access_token',
                 ["Content-Type: application/x-www-form-urlencoded"],
@@ -76,8 +76,12 @@ class Bitly extends OAuth2
                     "redirect_uri" => $this->callback,
                     "state" => \json_encode($this->state)
                 ])
-            ), true);
-        }
+            );
+
+        $output = [];
+        \parse_str($response, $output);
+        $this->tokens = $output;
+    }
 
         return $this->tokens;
     }
@@ -89,7 +93,7 @@ class Bitly extends OAuth2
      */
     public function refreshTokens(string $refreshToken):array
     {
-        $this->tokens = \json_decode($this->request(
+        $response = $this->request(
             'POST',
             $this->resourceEndpoint . 'oauth/access_token',
             ["Content-Type: application/x-www-form-urlencoded"],
@@ -99,7 +103,11 @@ class Bitly extends OAuth2
                 "refresh_token" => $refreshToken,
                 'grant_type' => 'refresh_token'
             ])
-        ), true);
+        );
+
+        $output = [];
+        \parse_str($response, $output);
+        $this->tokens = $output;
 
         if(empty($this->tokens['refresh_token'])) {
             $this->tokens['refresh_token'] = $refreshToken;
diff --git a/src/Appwrite/Auth/OAuth2/Github.php b/src/Appwrite/Auth/OAuth2/Github.php
index ceda2a4740..dddd4a5181 100644
--- a/src/Appwrite/Auth/OAuth2/Github.php
+++ b/src/Appwrite/Auth/OAuth2/Github.php
@@ -80,7 +80,7 @@ class Github extends OAuth2
      */
     public function refreshTokens(string $refreshToken):array
     {
-        $this->tokens = \json_decode($this->request(
+        $response = $this->request(
             'POST',
             'https://github.com/login/oauth/access_token',
             [],
@@ -90,7 +90,11 @@ class Github extends OAuth2
                 'grant_type' => 'refresh_token',
                 'refresh_token' => $refreshToken
             ])
-        ), true);
+        );
+
+        $output = [];
+        \parse_str($response, $output);
+        $this->tokens = $output;
 
         if(empty($this->tokens['refresh_token'])) {
             $this->tokens['refresh_token'] = $refreshToken;