Elgato_dark/appwrite
1
0
Fork 0
mirror of https://github.com/appwrite/appwrite synced 2026-05-23 17:08:45 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Don't require data for delete operation

Browse source
This commit is contained in:
Jake Barnby 2025-09-26 00:50:25 +12:00
parent 7a03084e83
commit e06c358db4
No known key found for this signature in database
GPG key ID: C437A8CC85B96E9C
1 changed files with 31 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

39
src/Appwrite/Utopia/Database/Validator/Operation.php
View file

@ -24,6 +24,20 @@ class Operation extends Validator
'decrement' => true,
];
/** @var array<string, bool> */
private array $requiresData = [
'create' => true,
'update' => true,
'upsert' => true,
'delete' => false, // Delete doesn't need data
'increment' => true,
'decrement' => true,
'bulkCreate' => true,
'bulkUpdate' => true,
'bulkUpsert' => true,
'bulkDelete' => true,
];
/** @var array<string, bool> */
private array $actions = [
'create' => true,
@ -121,14 +135,23 @@ class Operation extends Validator
return false;
}
// Data must be present and must be array (can be empty)
if (!\array_key_exists('data', $value)) {
$this->description = "Missing required key: data";
return false;
}
if (!\is_array($value['data'])) {
$this->description = "Key 'data' must be an array";
return false;
// Data validation - only required for certain actions
if (isset($this->requiresData[$value['action']]) && $this->requiresData[$value['action']]) {
// Data is required for this action
if (!\array_key_exists('data', $value)) {
$this->description = "Missing required key: data";
return false;
}
if (!\is_array($value['data'])) {
$this->description = "Key 'data' must be an array";
return false;
}
} else if (\array_key_exists('data', $value)) {
// Data is optional but if provided, must be an array
if (!\is_array($value['data'])) {
$this->description = "Key 'data' must be an array";
return false;
}
}
return true;