From d9aadb02e7a316c2743a24e0a4283a02859fe7fd Mon Sep 17 00:00:00 2001
From: Jake Barnby <jakeb994@gmail.com>
Date: Fri, 29 Aug 2025 19:53:47 +1200
Subject: [PATCH] Move filter

---
 .../Databases/Http/Databases/Collections/Documents/Create.php | 4 ++--
 .../Databases/Http/Databases/Collections/Documents/Delete.php | 1 +
 .../Databases/Http/Databases/Collections/Documents/Update.php | 4 ++--
 .../Databases/Http/Databases/Collections/Documents/Upsert.php | 4 ++--
 4 files changed, 7 insertions(+), 6 deletions(-)

diff --git a/src/Appwrite/Platform/Modules/Databases/Http/Databases/Collections/Documents/Create.php b/src/Appwrite/Platform/Modules/Databases/Http/Databases/Collections/Documents/Create.php
index 4bd0c6cdee..6222c6c183 100644
--- a/src/Appwrite/Platform/Modules/Databases/Http/Databases/Collections/Documents/Create.php
+++ b/src/Appwrite/Platform/Modules/Databases/Http/Databases/Collections/Documents/Create.php
@@ -298,8 +298,6 @@ class Create extends Action
                 );
 
                 foreach ($relations as &$relation) {
-                    $relation = $this->removeReadonlyAttributes($relation);
-
                     if (
                         \is_array($relation)
                         && \array_values($relation) !== $relation
@@ -309,6 +307,8 @@ class Create extends Action
                         $relation = new Document($relation);
                     }
                     if ($relation instanceof Document) {
+                        $relation = $this->removeReadonlyAttributes($relation);
+
                         $current = Authorization::skip(
                             fn () => $dbForProject->getDocument('database_' . $database->getSequence() . '_collection_' . $relatedCollection->getSequence(), $relation->getId())
                         );
diff --git a/src/Appwrite/Platform/Modules/Databases/Http/Databases/Collections/Documents/Delete.php b/src/Appwrite/Platform/Modules/Databases/Http/Databases/Collections/Documents/Delete.php
index 4ae1624f73..f34b4630c2 100644
--- a/src/Appwrite/Platform/Modules/Databases/Http/Databases/Collections/Documents/Delete.php
+++ b/src/Appwrite/Platform/Modules/Databases/Http/Databases/Collections/Documents/Delete.php
@@ -117,6 +117,7 @@ class Delete extends Action
         }
 
         $collectionsCache = [];
+
         $this->processDocument(
             database: $database,
             collection: $collection,
diff --git a/src/Appwrite/Platform/Modules/Databases/Http/Databases/Collections/Documents/Update.php b/src/Appwrite/Platform/Modules/Databases/Http/Databases/Collections/Documents/Update.php
index fd86fa995c..7512b1aab0 100644
--- a/src/Appwrite/Platform/Modules/Databases/Http/Databases/Collections/Documents/Update.php
+++ b/src/Appwrite/Platform/Modules/Databases/Http/Databases/Collections/Documents/Update.php
@@ -195,8 +195,6 @@ class Update extends Action
                 );
 
                 foreach ($relations as &$relation) {
-                    $relation = $this->removeReadonlyAttributes($relation);
-
                     // If the relation is an array it can be either update or create a child document.
                     if (
                         \is_array($relation)
@@ -207,6 +205,8 @@ class Update extends Action
                         $relation = new Document($relation);
                     }
                     if ($relation instanceof Document) {
+                        $relation = $this->removeReadonlyAttributes($relation);
+
                         $oldDocument = Authorization::skip(fn () => $dbForProject->getDocument(
                             'database_' . $database->getSequence() . '_collection_' . $relatedCollection->getSequence(),
                             $relation->getId()
diff --git a/src/Appwrite/Platform/Modules/Databases/Http/Databases/Collections/Documents/Upsert.php b/src/Appwrite/Platform/Modules/Databases/Http/Databases/Collections/Documents/Upsert.php
index 622b43db2a..004777c1b2 100644
--- a/src/Appwrite/Platform/Modules/Databases/Http/Databases/Collections/Documents/Upsert.php
+++ b/src/Appwrite/Platform/Modules/Databases/Http/Databases/Collections/Documents/Upsert.php
@@ -204,8 +204,6 @@ class Upsert extends Action
                 );
 
                 foreach ($relations as &$relation) {
-                    $relation = $this->removeReadonlyAttributes($relation);
-
                     // If the relation is an array it can be either update or create a child document.
                     if (
                         \is_array($relation)
@@ -216,6 +214,8 @@ class Upsert extends Action
                         $relation = new Document($relation);
                     }
                     if ($relation instanceof Document) {
+                        $relation = $this->removeReadonlyAttributes($relation);
+
                         $oldDocument = Authorization::skip(fn () => $dbForProject->getDocument(
                             'database_' . $database->getSequence() . '_collection_' . $relatedCollection->getSequence(),
                             $relation->getId()