From c6fb4687a29545d4bffee65f8e8eb87de4a684ea Mon Sep 17 00:00:00 2001 From: Chirag Aggarwal Date: Sat, 30 Aug 2025 12:32:57 +0530 Subject: [PATCH] readability --- app/controllers/general.php | 17 ++++++++++++++--- 1 file changed, 14 insertions(+), 3 deletions(-) diff --git a/app/controllers/general.php b/app/controllers/general.php index f1f6c52354..a38e9c9591 100644 --- a/app/controllers/general.php +++ b/app/controllers/general.php @@ -1081,11 +1081,22 @@ App::init() if ($replaceWith) { $replaceWith = preg_replace('/\./', '#', $replaceWith, 1); } - $sdkName = $request->getHeader('x-sdk-name', 'rest'); - $sdkPlatform = !empty($sdkName) ? $request->getHeader('x-sdk-platform', 'server') : 'server'; + + $sdkNameHeader = $request->getHeader('x-sdk-name', ''); + $sdkPlatformHeader = $request->getHeader('x-sdk-platform', ''); + + $sdkExists = !empty($sdkNameHeader); + $sdkName = $sdkExists ? $sdkNameHeader : 'rest'; + $sdkPlatform = !empty($sdkPlatformHeader) ? $sdkPlatformHeader : 'server'; + $deprecatedReplaceWithLink = 'https://appwrite.io/docs/references/cloud/' . $sdkPlatform . '-' . strtolower($sdkName) . '/' . $replaceWith; - $deprecationWarning = (empty($sdkName) ? 'Route ' . $route->getPath() : 'Method `' . $sdkItems[0]->getNamespace() . '.' . $sdkItems[0]->getMethodName() . '`') . ' is deprecated since ' . $deprecatedMethod->getSince() . '. Please use `' . $deprecatedMethod->getReplaceWith() . '` instead. See: ' . $deprecatedReplaceWithLink; + $deprecationWarning = ( + !$sdkExists + ? 'Route ' . $route->getPath() + : 'Method `' . $sdkItems[0]->getNamespace() . '.' . $sdkItems[0]->getMethodName() . '`' + ) . ' is deprecated since ' . $deprecatedMethod->getSince() . '. Please use `' . $deprecatedMethod->getReplaceWith() . '` instead. See: ' . $deprecatedReplaceWithLink; + $warnings[] = $deprecationWarning; } }