Elgato_dark/appwrite
1
0
Fork 0
mirror of https://github.com/appwrite/appwrite synced 2026-05-05 22:38:37 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Remove redundant validation

Browse source
This commit is contained in:
Jake Barnby 2025-12-04 21:23:08 +13:00
parent 331e294ef5
commit c6ccbfaae1
1 changed files with 8 additions and 18 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

26
src/Appwrite/Platform/Modules/Databases/Http/Databases/Collections/Create.php
View file

@ -24,7 +24,6 @@ use Utopia\Database\Helpers\Permission;
use Utopia\Database\Validator\Authorization;
use Utopia\Database\Validator\Index as IndexValidator;
use Utopia\Database\Validator\Permissions;
use Utopia\Database\Validator\Structure;
use Utopia\Database\Validator\UID;
use Utopia\Swoole\Response as SwooleResponse;
use Utopia\Validator\Boolean;
@ -252,19 +251,6 @@ class Create extends Action
];
}
if (!empty($format)) {
if (!Structure::hasFormat($format, $type)) {
throw new Exception($this->getFormatUnsupportedException(), "Format $format not available for $type attributes.");
}
}
if ($required && isset($default) && $default !== null) {
throw new Exception($this->getDefaultUnsupportedException(), 'Cannot set default value for required ' . $this->getContext());
}
if ($array && isset($default) && $default !== null) {
throw new Exception($this->getDefaultUnsupportedException(), 'Cannot set default value for array ' . $this->getContext() . 's');
}
if (\in_array($type, Database::SPATIAL_TYPES)) {
if (!$dbForProject->getAdapter()->getSupportForSpatialIndex()) {
@ -419,16 +405,20 @@ class Create extends Action
/**
* Cleanup on failure: delete the collection document and the underlying DB collection
*/
protected function cleanup(Database $dbForProject, string $databaseKey, string $collectionKey, string $collectionId): void
{
protected function cleanup(
Database $dbForProject,
string $databaseId,
string $collectionId,
string $collectionDocumentId
): void {
try {
$dbForProject->deleteCollection($collectionKey);
$dbForProject->deleteCollection($collectionId);
} catch (\Throwable) {
// Ignore cleanup errors for collection deletion
}
try {
$dbForProject->deleteDocument($databaseKey, $collectionId);
$dbForProject->deleteDocument($databaseId, $collectionDocumentId);
} catch (\Throwable) {
// Ignore cleanup errors for document deletion
}