From bc55639bf793e766d1993d007e3b2d0c01fe70bb Mon Sep 17 00:00:00 2001 From: Darshan Date: Fri, 8 Aug 2025 16:25:48 +0530 Subject: [PATCH] update: if/else > switch > match --- .../Collections/Documents/Logs/XList.php | 16 +++++----------- .../Http/Databases/Collections/Logs/XList.php | 12 ++++-------- 2 files changed, 9 insertions(+), 19 deletions(-) diff --git a/src/Appwrite/Platform/Modules/Databases/Http/Databases/Collections/Documents/Logs/XList.php b/src/Appwrite/Platform/Modules/Databases/Http/Databases/Collections/Documents/Logs/XList.php index 0e5a51df7b..0f8a8688c6 100644 --- a/src/Appwrite/Platform/Modules/Databases/Http/Databases/Collections/Documents/Logs/XList.php +++ b/src/Appwrite/Platform/Modules/Databases/Http/Databases/Collections/Documents/Logs/XList.php @@ -106,18 +106,12 @@ class XList extends Action ]); $audit = new Audit($dbForProject); - $isRows = $this->getContext() === ROWS; - - // returns what we want, ignore the naming! $type = $this->getCollectionsEventsContext(); - $item = $isRows ? 'row' : 'document'; - - if (!$isRows) { - $resource = "database/$databaseId/$type/$collectionId/$item/{$document->getId()}"; - } else { - // grid - $resource = "database/$databaseId/grid/$type/$collectionId/$item/{$document->getId()}"; - } + $context = $this->getContext(); + $resource = match ($context) { + ROWS => "database/$databaseId/grid/$type/$collectionId/$context/{$document->getId()}", + default => "database/$databaseId/$type/$collectionId/$context/{$document->getId()}", + }; $logs = $audit->getLogsByResource($resource, $queries); diff --git a/src/Appwrite/Platform/Modules/Databases/Http/Databases/Collections/Logs/XList.php b/src/Appwrite/Platform/Modules/Databases/Http/Databases/Collections/Logs/XList.php index 1341edd1a9..359fed118a 100644 --- a/src/Appwrite/Platform/Modules/Databases/Http/Databases/Collections/Logs/XList.php +++ b/src/Appwrite/Platform/Modules/Databases/Http/Databases/Collections/Logs/XList.php @@ -103,15 +103,11 @@ class XList extends Action ]); $audit = new Audit($dbForProject); - $context = $this->getContext(); - $isTables = $context === TABLES; - - if (!$isTables) { - $resource = "database/$databaseId/$context/$collectionId"; - } else { - $resource = "database/$databaseId/grid/$context/$collectionId"; - } + $resource = match ($context) { + TABLES => "database/$databaseId/grid/$context/$collectionId", + default => "database/$databaseId/$context/$collectionId", + }; $logs = $audit->getLogsByResource($resource, $queries);