From 0895a2561508e5fce7aa4e08cb9584b7a44e366d Mon Sep 17 00:00:00 2001 From: Eldad Fux Date: Wed, 7 Sep 2022 14:02:36 +0300 Subject: [PATCH 1/4] Fixed response syntax with new FW version --- app/controllers/api/account.php | 25 +++++++----- app/controllers/api/databases.php | 64 ++++++++++++++++++------------- app/controllers/api/functions.php | 16 ++++---- app/controllers/api/projects.php | 25 +++++++----- app/controllers/api/storage.php | 10 +++-- app/controllers/api/teams.php | 19 +++++---- app/controllers/api/users.php | 5 ++- composer.json | 2 +- 8 files changed, 98 insertions(+), 68 deletions(-) diff --git a/app/controllers/api/account.php b/app/controllers/api/account.php index 6c90441afb..ece9916dba 100644 --- a/app/controllers/api/account.php +++ b/app/controllers/api/account.php @@ -128,8 +128,9 @@ App::post('/v1/account') $usage->setParam('users.create', 1); $events->setParam('userId', $user->getId()); - $response->setStatusCode(Response::STATUS_CODE_CREATED); - $response->dynamic($user, Response::MODEL_USER); + $response + ->setStatusCode(Response::STATUS_CODE_CREATED) + ->dynamic($user, Response::MODEL_USER); }); App::post('/v1/account/sessions/email') @@ -1227,8 +1228,9 @@ App::post('/v1/account/jwt') $jwt = new JWT(App::getEnv('_APP_OPENSSL_KEY_V1'), 'HS256', 900, 10); // Instantiate with key, algo, maxAge and leeway. - $response->setStatusCode(Response::STATUS_CODE_CREATED); - $response->dynamic(new Document(['jwt' => $jwt->encode([ + $response + ->setStatusCode(Response::STATUS_CODE_CREATED) + ->dynamic(new Document(['jwt' => $jwt->encode([ // 'uid' => 1, // 'aud' => 'http://site.com', // 'scopes' => ['user'], @@ -2013,8 +2015,9 @@ App::post('/v1/account/recovery') $audits->setResource('user/' . $profile->getId()); $usage->setParam('users.update', 1); - $response->setStatusCode(Response::STATUS_CODE_CREATED); - $response->dynamic($recovery, Response::MODEL_TOKEN); + $response + ->setStatusCode(Response::STATUS_CODE_CREATED) + ->dynamic($recovery, Response::MODEL_TOKEN); }); App::put('/v1/account/recovery') @@ -2173,8 +2176,9 @@ App::post('/v1/account/verification') $audits->setResource('user/' . $user->getId()); $usage->setParam('users.update', 1); - $response->setStatusCode(Response::STATUS_CODE_CREATED); - $response->dynamic($verification, Response::MODEL_TOKEN); + $response + ->setStatusCode(Response::STATUS_CODE_CREATED) + ->dynamic($verification, Response::MODEL_TOKEN); }); App::put('/v1/account/verification') @@ -2321,8 +2325,9 @@ App::post('/v1/account/verification/phone') $audits->setResource('user/' . $user->getId()); $usage->setParam('users.update', 1); - $response->setStatusCode(Response::STATUS_CODE_CREATED); - $response->dynamic($verification, Response::MODEL_TOKEN); + $response + ->setStatusCode(Response::STATUS_CODE_CREATED) + ->dynamic($verification, Response::MODEL_TOKEN); }); App::put('/v1/account/verification/phone') diff --git a/app/controllers/api/databases.php b/app/controllers/api/databases.php index bfba82dc29..b4edb37716 100644 --- a/app/controllers/api/databases.php +++ b/app/controllers/api/databases.php @@ -226,8 +226,9 @@ App::post('/v1/databases') $events->setParam('databaseId', $database->getId()); $usage->setParam('databases.create', 1); - $response->setStatusCode(Response::STATUS_CODE_CREATED); - $response->dynamic($database, Response::MODEL_DATABASE); + $response + ->setStatusCode(Response::STATUS_CODE_CREATED) + ->dynamic($database, Response::MODEL_DATABASE); }); App::get('/v1/databases') @@ -550,8 +551,9 @@ App::post('/v1/databases/:databaseId/collections') ->setParam('databaseId', $databaseId) ->setParam('databases.collections.create', 1); - $response->setStatusCode(Response::STATUS_CODE_CREATED); - $response->dynamic($collection, Response::MODEL_COLLECTION); + $response + ->setStatusCode(Response::STATUS_CODE_CREATED) + ->dynamic($collection, Response::MODEL_COLLECTION); }); App::get('/v1/databases/:databaseId/collections') @@ -915,8 +917,9 @@ App::post('/v1/databases/:databaseId/collections/:collectionId/attributes/string 'array' => $array, ]), $response, $dbForProject, $database, $audits, $events, $usage); - $response->setStatusCode(Response::STATUS_CODE_ACCEPTED); - $response->dynamic($attribute, Response::MODEL_ATTRIBUTE_STRING); + $response + ->setStatusCode(Response::STATUS_CODE_ACCEPTED) + ->dynamic($attribute, Response::MODEL_ATTRIBUTE_STRING); }); App::post('/v1/databases/:databaseId/collections/:collectionId/attributes/email') @@ -956,8 +959,9 @@ App::post('/v1/databases/:databaseId/collections/:collectionId/attributes/email' 'format' => APP_DATABASE_ATTRIBUTE_EMAIL, ]), $response, $dbForProject, $database, $audits, $events, $usage); - $response->setStatusCode(Response::STATUS_CODE_ACCEPTED); - $response->dynamic($attribute, Response::MODEL_ATTRIBUTE_EMAIL); + $response + ->setStatusCode(Response::STATUS_CODE_ACCEPTED) + ->dynamic($attribute, Response::MODEL_ATTRIBUTE_EMAIL); }); App::post('/v1/databases/:databaseId/collections/:collectionId/attributes/enum') @@ -1013,8 +1017,9 @@ App::post('/v1/databases/:databaseId/collections/:collectionId/attributes/enum') 'formatOptions' => ['elements' => $elements], ]), $response, $dbForProject, $database, $audits, $events, $usage); - $response->setStatusCode(Response::STATUS_CODE_ACCEPTED); - $response->dynamic($attribute, Response::MODEL_ATTRIBUTE_ENUM); + $response + ->setStatusCode(Response::STATUS_CODE_ACCEPTED) + ->dynamic($attribute, Response::MODEL_ATTRIBUTE_ENUM); }); App::post('/v1/databases/:databaseId/collections/:collectionId/attributes/ip') @@ -1054,8 +1059,9 @@ App::post('/v1/databases/:databaseId/collections/:collectionId/attributes/ip') 'format' => APP_DATABASE_ATTRIBUTE_IP, ]), $response, $dbForProject, $database, $audits, $events, $usage); - $response->setStatusCode(Response::STATUS_CODE_ACCEPTED); - $response->dynamic($attribute, Response::MODEL_ATTRIBUTE_IP); + $response + ->setStatusCode(Response::STATUS_CODE_ACCEPTED) + ->dynamic($attribute, Response::MODEL_ATTRIBUTE_IP); }); App::post('/v1/databases/:databaseId/collections/:collectionId/attributes/url') @@ -1095,8 +1101,9 @@ App::post('/v1/databases/:databaseId/collections/:collectionId/attributes/url') 'format' => APP_DATABASE_ATTRIBUTE_URL, ]), $response, $dbForProject, $database, $audits, $events, $usage); - $response->setStatusCode(Response::STATUS_CODE_ACCEPTED); - $response->dynamic($attribute, Response::MODEL_ATTRIBUTE_URL); + $response + ->setStatusCode(Response::STATUS_CODE_ACCEPTED) + ->dynamic($attribute, Response::MODEL_ATTRIBUTE_URL); }); App::post('/v1/databases/:databaseId/collections/:collectionId/attributes/integer') @@ -1165,8 +1172,9 @@ App::post('/v1/databases/:databaseId/collections/:collectionId/attributes/intege $attribute->setAttribute('max', \intval($formatOptions['max'])); } - $response->setStatusCode(Response::STATUS_CODE_ACCEPTED); - $response->dynamic($attribute, Response::MODEL_ATTRIBUTE_INTEGER); + $response + ->setStatusCode(Response::STATUS_CODE_ACCEPTED) + ->dynamic($attribute, Response::MODEL_ATTRIBUTE_INTEGER); }); App::post('/v1/databases/:databaseId/collections/:collectionId/attributes/float') @@ -1238,8 +1246,9 @@ App::post('/v1/databases/:databaseId/collections/:collectionId/attributes/float' $attribute->setAttribute('max', \floatval($formatOptions['max'])); } - $response->setStatusCode(Response::STATUS_CODE_ACCEPTED); - $response->dynamic($attribute, Response::MODEL_ATTRIBUTE_FLOAT); + $response + ->setStatusCode(Response::STATUS_CODE_ACCEPTED) + ->dynamic($attribute, Response::MODEL_ATTRIBUTE_FLOAT); }); App::post('/v1/databases/:databaseId/collections/:collectionId/attributes/boolean') @@ -1278,8 +1287,9 @@ App::post('/v1/databases/:databaseId/collections/:collectionId/attributes/boolea 'array' => $array, ]), $response, $dbForProject, $database, $audits, $events, $usage); - $response->setStatusCode(Response::STATUS_CODE_ACCEPTED); - $response->dynamic($attribute, Response::MODEL_ATTRIBUTE_BOOLEAN); + $response + ->setStatusCode(Response::STATUS_CODE_ACCEPTED) + ->dynamic($attribute, Response::MODEL_ATTRIBUTE_BOOLEAN); }); App::get('/v1/databases/:databaseId/collections/:collectionId/attributes') @@ -1632,8 +1642,8 @@ App::post('/v1/databases/:databaseId/collections/:collectionId/indexes') ->setParam('databaseId', $databaseId) ->setParam('collectionId', $collection->getId()) ->setParam('indexId', $index->getId()) - ->setContext('collection', $collection) - ->setContext('database', $db) + ->setContext('collection', $collection) + ->setContext('database', $db) ; $audits @@ -1641,8 +1651,9 @@ App::post('/v1/databases/:databaseId/collections/:collectionId/indexes') ->setPayload($index->getArrayCopy()) ; - $response->setStatusCode(Response::STATUS_CODE_ACCEPTED); - $response->dynamic($index, Response::MODEL_INDEX); + $response + ->setStatusCode(Response::STATUS_CODE_ACCEPTED) + ->dynamic($index, Response::MODEL_INDEX); }); App::get('/v1/databases/:databaseId/collections/:collectionId/indexes') @@ -1932,8 +1943,9 @@ App::post('/v1/databases/:databaseId/collections/:collectionId/documents') ->setPayload($document->getArrayCopy()) ; - $response->setStatusCode(Response::STATUS_CODE_CREATED); - $response->dynamic($document, Response::MODEL_DOCUMENT); + $response + ->setStatusCode(Response::STATUS_CODE_CREATED) + ->dynamic($document, Response::MODEL_DOCUMENT); }); App::get('/v1/databases/:databaseId/collections/:collectionId/documents') diff --git a/app/controllers/api/functions.php b/app/controllers/api/functions.php index ac49636407..d04969cd3f 100644 --- a/app/controllers/api/functions.php +++ b/app/controllers/api/functions.php @@ -82,8 +82,9 @@ App::post('/v1/functions') $eventsInstance->setParam('functionId', $function->getId()); - $response->setStatusCode(Response::STATUS_CODE_CREATED); - $response->dynamic($function, Response::MODEL_FUNCTION); + $response + ->setStatusCode(Response::STATUS_CODE_CREATED) + ->dynamic($function, Response::MODEL_FUNCTION); }); App::get('/v1/functions') @@ -622,8 +623,9 @@ App::post('/v1/functions/:functionId/deployments') ->setParam('functionId', $function->getId()) ->setParam('deploymentId', $deployment->getId()); - $response->setStatusCode(Response::STATUS_CODE_ACCEPTED); - $response->dynamic($deployment, Response::MODEL_DEPLOYMENT); + $response + ->setStatusCode(Response::STATUS_CODE_ACCEPTED) + ->dynamic($deployment, Response::MODEL_DEPLOYMENT); }); App::get('/v1/functions/:functionId/deployments') @@ -906,9 +908,9 @@ App::post('/v1/functions/:functionId/executions') $event->trigger(); - $response->setStatusCode(Response::STATUS_CODE_ACCEPTED); - - return $response->dynamic($execution, Response::MODEL_EXECUTION); + return $response + ->setStatusCode(Response::STATUS_CODE_ACCEPTED) + ->dynamic($execution, Response::MODEL_EXECUTION); } /** Collect environment variables */ diff --git a/app/controllers/api/projects.php b/app/controllers/api/projects.php index 86996f4a58..b74993b260 100644 --- a/app/controllers/api/projects.php +++ b/app/controllers/api/projects.php @@ -155,8 +155,9 @@ App::post('/v1/projects') $dbForProject->createCollection($key, $attributes, $indexes); } - $response->setStatusCode(Response::STATUS_CODE_CREATED); - $response->dynamic($project, Response::MODEL_PROJECT); + $response + ->setStatusCode(Response::STATUS_CODE_CREATED) + ->dynamic($project, Response::MODEL_PROJECT); }); App::get('/v1/projects') @@ -605,8 +606,9 @@ App::post('/v1/projects/:projectId/webhooks') $dbForConsole->deleteCachedDocument('projects', $project->getId()); - $response->setStatusCode(Response::STATUS_CODE_CREATED); - $response->dynamic($webhook, Response::MODEL_WEBHOOK); + $response + ->setStatusCode(Response::STATUS_CODE_CREATED) + ->dynamic($webhook, Response::MODEL_WEBHOOK); }); App::get('/v1/projects/:projectId/webhooks') @@ -846,8 +848,9 @@ App::post('/v1/projects/:projectId/keys') $dbForConsole->deleteCachedDocument('projects', $project->getId()); - $response->setStatusCode(Response::STATUS_CODE_CREATED); - $response->dynamic($key, Response::MODEL_KEY); + $response + ->setStatusCode(Response::STATUS_CODE_CREATED) + ->dynamic($key, Response::MODEL_KEY); }); App::get('/v1/projects/:projectId/keys') @@ -1043,8 +1046,9 @@ App::post('/v1/projects/:projectId/platforms') $dbForConsole->deleteCachedDocument('projects', $project->getId()); - $response->setStatusCode(Response::STATUS_CODE_CREATED); - $response->dynamic($platform, Response::MODEL_PLATFORM); + $response + ->setStatusCode(Response::STATUS_CODE_CREATED) + ->dynamic($platform, Response::MODEL_PLATFORM); }); App::get('/v1/projects/:projectId/platforms') @@ -1256,8 +1260,9 @@ App::post('/v1/projects/:projectId/domains') $dbForConsole->deleteCachedDocument('projects', $project->getId()); - $response->setStatusCode(Response::STATUS_CODE_CREATED); - $response->dynamic($domain, Response::MODEL_DOMAIN); + $response + ->setStatusCode(Response::STATUS_CODE_CREATED) + ->dynamic($domain, Response::MODEL_DOMAIN); }); App::get('/v1/projects/:projectId/domains') diff --git a/app/controllers/api/storage.php b/app/controllers/api/storage.php index b62aa750db..2ce0b03157 100644 --- a/app/controllers/api/storage.php +++ b/app/controllers/api/storage.php @@ -137,8 +137,9 @@ App::post('/v1/storage/buckets') $usage->setParam('storage.buckets.create', 1); - $response->setStatusCode(Response::STATUS_CODE_CREATED); - $response->dynamic($bucket, Response::MODEL_BUCKET); + $response + ->setStatusCode(Response::STATUS_CODE_CREATED) + ->dynamic($bucket, Response::MODEL_BUCKET); }); App::get('/v1/storage/buckets') @@ -655,8 +656,9 @@ App::post('/v1/storage/buckets/:bucketId/files') $metadata = null; // was causing leaks as it was passed by reference - $response->setStatusCode(Response::STATUS_CODE_CREATED); - $response->dynamic($file, Response::MODEL_FILE); + $response + ->setStatusCode(Response::STATUS_CODE_CREATED) + ->dynamic($file, Response::MODEL_FILE); }); App::get('/v1/storage/buckets/:bucketId/files') diff --git a/app/controllers/api/teams.php b/app/controllers/api/teams.php index 383bcac149..1f9b178bf9 100644 --- a/app/controllers/api/teams.php +++ b/app/controllers/api/teams.php @@ -100,8 +100,9 @@ App::post('/v1/teams') ->setParam('data', $team->getArrayCopy()) ; - $response->setStatusCode(Response::STATUS_CODE_CREATED); - $response->dynamic($team, Response::MODEL_TEAM); + $response + ->setStatusCode(Response::STATUS_CODE_CREATED) + ->dynamic($team, Response::MODEL_TEAM); }); App::get('/v1/teams') @@ -423,12 +424,14 @@ App::post('/v1/teams/:teamId/memberships') ->setParam('membershipId', $membership->getId()) ; - $response->setStatusCode(Response::STATUS_CODE_CREATED); - $response->dynamic( - $membership - ->setAttribute('teamName', $team->getAttribute('name')) - ->setAttribute('userName', $user->getAttribute('name')) - ->setAttribute('userEmail', $user->getAttribute('email')), + $response + ->setStatusCode(Response::STATUS_CODE_CREATED) + ->dynamic( + $membership + ->setAttribute('teamName', $team->getAttribute('name')) + ->setAttribute('userName', $user->getAttribute('name')) + ->setAttribute('userEmail', $user->getAttribute('email')) + , Response::MODEL_MEMBERSHIP ); }); diff --git a/app/controllers/api/users.php b/app/controllers/api/users.php index 8845db4810..2630ecfb10 100644 --- a/app/controllers/api/users.php +++ b/app/controllers/api/users.php @@ -85,8 +85,9 @@ App::post('/v1/users') ->setParam('userId', $user->getId()) ; - $response->setStatusCode(Response::STATUS_CODE_CREATED); - $response->dynamic($user, Response::MODEL_USER); + $response + ->setStatusCode(Response::STATUS_CODE_CREATED) + ->dynamic($user, Response::MODEL_USER); }); App::get('/v1/users') diff --git a/composer.json b/composer.json index 4f26341669..12fcf99304 100644 --- a/composer.json +++ b/composer.json @@ -42,7 +42,7 @@ "ext-sockets": "*", "appwrite/php-clamav": "1.1.*", "appwrite/php-runtimes": "0.10.*", - "utopia-php/framework": "0.19.*", + "utopia-php/framework": "0.20.*", "utopia-php/logger": "0.3.*", "utopia-php/abuse": "0.7.*", "utopia-php/analytics": "0.2.*", From 01fb4045bd913a49cda64626254cd18c97eef039 Mon Sep 17 00:00:00 2001 From: Eldad Fux Date: Wed, 7 Sep 2022 14:11:10 +0300 Subject: [PATCH 2/4] Sync with 0.16 --- app/controllers/api/account.php | 15 +++++++------ app/controllers/api/databases.php | 25 +++++++++++++--------- app/controllers/api/functions.php | 5 +++-- app/controllers/api/storage.php | 5 +++-- app/controllers/api/teams.php | 19 ++++++++++------- app/controllers/api/users.php | 35 ++++++++++++++++++------------- 6 files changed, 62 insertions(+), 42 deletions(-) diff --git a/app/controllers/api/account.php b/app/controllers/api/account.php index 671a921df5..eeec83e069 100644 --- a/app/controllers/api/account.php +++ b/app/controllers/api/account.php @@ -1981,8 +1981,9 @@ App::post('/v1/account/recovery') // Hide secret for clients $recovery->setAttribute('secret', ($isPrivilegedUser || $isAppUser) ? $secret : ''); - $response->setStatusCode(Response::STATUS_CODE_CREATED); - $response->dynamic($recovery, Response::MODEL_TOKEN); + $response + ->setStatusCode(Response::STATUS_CODE_CREATED) + ->dynamic($recovery, Response::MODEL_TOKEN); }); App::put('/v1/account/recovery') @@ -2137,8 +2138,9 @@ App::post('/v1/account/verification') // Hide secret for clients $verification->setAttribute('secret', ($isPrivilegedUser || $isAppUser) ? $verificationSecret : ''); - $response->setStatusCode(Response::STATUS_CODE_CREATED); - $response->dynamic($verification, Response::MODEL_TOKEN); + $response + ->setStatusCode(Response::STATUS_CODE_CREATED) + ->dynamic($verification, Response::MODEL_TOKEN); }); App::put('/v1/account/verification') @@ -2278,8 +2280,9 @@ App::post('/v1/account/verification/phone') // Hide secret for clients $verification->setAttribute('secret', ($isPrivilegedUser || $isAppUser) ? $verificationSecret : ''); - $response->setStatusCode(Response::STATUS_CODE_CREATED); - $response->dynamic($verification, Response::MODEL_TOKEN); + $response + ->setStatusCode(Response::STATUS_CODE_CREATED) + ->dynamic($verification, Response::MODEL_TOKEN); }); App::put('/v1/account/verification/phone') diff --git a/app/controllers/api/databases.php b/app/controllers/api/databases.php index 1a5ba02f25..94b17aa7b2 100644 --- a/app/controllers/api/databases.php +++ b/app/controllers/api/databases.php @@ -530,8 +530,9 @@ App::post('/v1/databases/:databaseId/collections') ->setParam('databaseId', $databaseId) ->setParam('collectionId', $collection->getId()); - $response->setStatusCode(Response::STATUS_CODE_CREATED); - $response->dynamic($collection, Response::MODEL_COLLECTION); + $response + ->setStatusCode(Response::STATUS_CODE_CREATED) + ->dynamic($collection, Response::MODEL_COLLECTION); }); App::get('/v1/databases/:databaseId/collections') @@ -1265,8 +1266,9 @@ App::post('/v1/databases/:databaseId/collections/:collectionId/attributes/boolea 'array' => $array, ]), $response, $dbForProject, $database, $events); - $response->setStatusCode(Response::STATUS_CODE_ACCEPTED); - $response->dynamic($attribute, Response::MODEL_ATTRIBUTE_BOOLEAN); + $response + ->setStatusCode(Response::STATUS_CODE_ACCEPTED) + ->dynamic($attribute, Response::MODEL_ATTRIBUTE_BOOLEAN); }); @@ -1308,8 +1310,9 @@ App::post('/v1/databases/:databaseId/collections/:collectionId/attributes/dateti 'filters' => ['datetime'] ]), $response, $dbForProject, $database, $events); - $response->setStatusCode(Response::STATUS_CODE_ACCEPTED); - $response->dynamic($attribute, Response::MODEL_ATTRIBUTE_DATETIME); + $response + ->setStatusCode(Response::STATUS_CODE_ACCEPTED) + ->dynamic($attribute, Response::MODEL_ATTRIBUTE_DATETIME); }); @@ -1654,8 +1657,9 @@ App::post('/v1/databases/:databaseId/collections/:collectionId/indexes') ->setContext('database', $db) ; - $response->setStatusCode(Response::STATUS_CODE_ACCEPTED); - $response->dynamic($index, Response::MODEL_INDEX); + $response + ->setStatusCode(Response::STATUS_CODE_ACCEPTED) + ->dynamic($index, Response::MODEL_INDEX); }); App::get('/v1/databases/:databaseId/collections/:collectionId/indexes') @@ -1933,8 +1937,9 @@ App::post('/v1/databases/:databaseId/collections/:collectionId/documents') ->setContext('database', $database) ; - $response->setStatusCode(Response::STATUS_CODE_CREATED); - $response->dynamic($document, Response::MODEL_DOCUMENT); + $response + ->setStatusCode(Response::STATUS_CODE_CREATED) + ->dynamic($document, Response::MODEL_DOCUMENT); }); App::get('/v1/databases/:databaseId/collections/:collectionId/documents') diff --git a/app/controllers/api/functions.php b/app/controllers/api/functions.php index 67e84bf0e0..762da9aba7 100644 --- a/app/controllers/api/functions.php +++ b/app/controllers/api/functions.php @@ -1342,8 +1342,9 @@ App::post('/v1/functions/:functionId/variables') $dbForProject->deleteCachedDocument('functions', $function->getId()); - $response->setStatusCode(Response::STATUS_CODE_CREATED); - $response->dynamic($variable, Response::MODEL_VARIABLE); + $response + ->setStatusCode(Response::STATUS_CODE_CREATED) + ->dynamic($variable, Response::MODEL_VARIABLE); }); App::get('/v1/functions/:functionId/variables') diff --git a/app/controllers/api/storage.php b/app/controllers/api/storage.php index 45d70edb45..594dee006a 100644 --- a/app/controllers/api/storage.php +++ b/app/controllers/api/storage.php @@ -136,8 +136,9 @@ App::post('/v1/storage/buckets') ->setParam('bucketId', $bucket->getId()) ; - $response->setStatusCode(Response::STATUS_CODE_CREATED); - $response->dynamic($bucket, Response::MODEL_BUCKET); + $response + ->setStatusCode(Response::STATUS_CODE_CREATED) + ->dynamic($bucket, Response::MODEL_BUCKET); }); App::get('/v1/storage/buckets') diff --git a/app/controllers/api/teams.php b/app/controllers/api/teams.php index 40eab55630..de8ccea5cc 100644 --- a/app/controllers/api/teams.php +++ b/app/controllers/api/teams.php @@ -116,8 +116,9 @@ App::post('/v1/teams') $events->setParam('userId', $user->getId()); } - $response->setStatusCode(Response::STATUS_CODE_CREATED); - $response->dynamic($team, Response::MODEL_TEAM); + $response + ->setStatusCode(Response::STATUS_CODE_CREATED) + ->dynamic($team, Response::MODEL_TEAM); }); App::get('/v1/teams') @@ -446,12 +447,14 @@ App::post('/v1/teams/:teamId/memberships') ->setParam('membershipId', $membership->getId()) ; - $response->setStatusCode(Response::STATUS_CODE_CREATED); - $response->dynamic( - $membership - ->setAttribute('teamName', $team->getAttribute('name')) - ->setAttribute('userName', $invitee->getAttribute('name')) - ->setAttribute('userEmail', $invitee->getAttribute('email')), + $response + ->setStatusCode(Response::STATUS_CODE_CREATED) + ->dynamic( + $membership + ->setAttribute('teamName', $team->getAttribute('name')) + ->setAttribute('userName', $invitee->getAttribute('name')) + ->setAttribute('userEmail', $invitee->getAttribute('email')) + , Response::MODEL_MEMBERSHIP ); }); diff --git a/app/controllers/api/users.php b/app/controllers/api/users.php index 2af0db3eed..a3b9f8741b 100644 --- a/app/controllers/api/users.php +++ b/app/controllers/api/users.php @@ -108,8 +108,9 @@ App::post('/v1/users') ->action(function (string $userId, ?string $email, ?string $phone, ?string $password, string $name, Response $response, Database $dbForProject, Event $events) { $user = createUser('plaintext', '{}', $userId, $email, $password, $phone, $name, $dbForProject, $events); - $response->setStatusCode(Response::STATUS_CODE_CREATED); - $response->dynamic($user, Response::MODEL_USER); + $response + ->setStatusCode(Response::STATUS_CODE_CREATED) + ->dynamic($user, Response::MODEL_USER); }); App::post('/v1/users/bcrypt') @@ -136,8 +137,9 @@ App::post('/v1/users/bcrypt') ->action(function (string $userId, string $email, string $password, string $name, Response $response, Database $dbForProject, Event $events) { $user = createUser('bcrypt', '{}', $userId, $email, $password, null, $name, $dbForProject, $events); - $response->setStatusCode(Response::STATUS_CODE_CREATED); - $response->dynamic($user, Response::MODEL_USER); + $response + ->setStatusCode(Response::STATUS_CODE_CREATED) + ->dynamic($user, Response::MODEL_USER); }); App::post('/v1/users/md5') @@ -164,8 +166,9 @@ App::post('/v1/users/md5') ->action(function (string $userId, string $email, string $password, string $name, Response $response, Database $dbForProject, Event $events) { $user = createUser('md5', '{}', $userId, $email, $password, null, $name, $dbForProject, $events); - $response->setStatusCode(Response::STATUS_CODE_CREATED); - $response->dynamic($user, Response::MODEL_USER); + $response + ->setStatusCode(Response::STATUS_CODE_CREATED) + ->dynamic($user, Response::MODEL_USER); }); App::post('/v1/users/argon2') @@ -192,8 +195,9 @@ App::post('/v1/users/argon2') ->action(function (string $userId, string $email, string $password, string $name, Response $response, Database $dbForProject, Event $events) { $user = createUser('argon2', '{}', $userId, $email, $password, null, $name, $dbForProject, $events); - $response->setStatusCode(Response::STATUS_CODE_CREATED); - $response->dynamic($user, Response::MODEL_USER); + $response + ->setStatusCode(Response::STATUS_CODE_CREATED) + ->dynamic($user, Response::MODEL_USER); }); App::post('/v1/users/sha') @@ -227,8 +231,9 @@ App::post('/v1/users/sha') $user = createUser('sha', $options, $userId, $email, $password, null, $name, $dbForProject, $events); - $response->setStatusCode(Response::STATUS_CODE_CREATED); - $response->dynamic($user, Response::MODEL_USER); + $response + ->setStatusCode(Response::STATUS_CODE_CREATED) + ->dynamic($user, Response::MODEL_USER); }); App::post('/v1/users/phpass') @@ -255,8 +260,9 @@ App::post('/v1/users/phpass') ->action(function (string $userId, string $email, string $password, string $name, Response $response, Database $dbForProject, Event $events) { $user = createUser('phpass', '{}', $userId, $email, $password, null, $name, $dbForProject, $events); - $response->setStatusCode(Response::STATUS_CODE_CREATED); - $response->dynamic($user, Response::MODEL_USER); + $response + ->setStatusCode(Response::STATUS_CODE_CREATED) + ->dynamic($user, Response::MODEL_USER); }); App::post('/v1/users/scrypt') @@ -296,8 +302,9 @@ App::post('/v1/users/scrypt') $user = createUser('scrypt', \json_encode($options), $userId, $email, $password, null, $name, $dbForProject, $events); - $response->setStatusCode(Response::STATUS_CODE_CREATED); - $response->dynamic($user, Response::MODEL_USER); + $response + ->setStatusCode(Response::STATUS_CODE_CREATED) + ->dynamic($user, Response::MODEL_USER); }); App::post('/v1/users/scrypt-modified') From c22c28bc670321dcd4263446cb7131c0956abeb0 Mon Sep 17 00:00:00 2001 From: Eldad Fux Date: Wed, 7 Sep 2022 14:14:53 +0300 Subject: [PATCH 3/4] Fixed indentation --- app/controllers/api/teams.php | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/app/controllers/api/teams.php b/app/controllers/api/teams.php index de8ccea5cc..a2ea889a8f 100644 --- a/app/controllers/api/teams.php +++ b/app/controllers/api/teams.php @@ -454,9 +454,9 @@ App::post('/v1/teams/:teamId/memberships') ->setAttribute('teamName', $team->getAttribute('name')) ->setAttribute('userName', $invitee->getAttribute('name')) ->setAttribute('userEmail', $invitee->getAttribute('email')) - , - Response::MODEL_MEMBERSHIP - ); + , + Response::MODEL_MEMBERSHIP + ); }); App::get('/v1/teams/:teamId/memberships') From c442a5bce2895f0ff6adc178ba96f12b417d3e47 Mon Sep 17 00:00:00 2001 From: Eldad Fux Date: Wed, 7 Sep 2022 14:23:57 +0300 Subject: [PATCH 4/4] Fix linter test --- app/controllers/api/teams.php | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/app/controllers/api/teams.php b/app/controllers/api/teams.php index a2ea889a8f..29463dc32c 100644 --- a/app/controllers/api/teams.php +++ b/app/controllers/api/teams.php @@ -453,8 +453,7 @@ App::post('/v1/teams/:teamId/memberships') $membership ->setAttribute('teamName', $team->getAttribute('name')) ->setAttribute('userName', $invitee->getAttribute('name')) - ->setAttribute('userEmail', $invitee->getAttribute('email')) - , + ->setAttribute('userEmail', $invitee->getAttribute('email')), Response::MODEL_MEMBERSHIP ); });