From aef7b8df38e1760bee332cb9d64c101ce7b94e18 Mon Sep 17 00:00:00 2001 From: Prem Palanisamy Date: Wed, 28 Jan 2026 08:41:10 +0000 Subject: [PATCH] fix: use RELATIONSHIP_VALUE_INVALID exception for validation errors --- .../Http/Databases/Collections/Documents/Action.php | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/Appwrite/Platform/Modules/Databases/Http/Databases/Collections/Documents/Action.php b/src/Appwrite/Platform/Modules/Databases/Http/Databases/Collections/Documents/Action.php index c0a95ce0bd..1df947f8c3 100644 --- a/src/Appwrite/Platform/Modules/Databases/Http/Databases/Collections/Documents/Action.php +++ b/src/Appwrite/Platform/Modules/Databases/Http/Databases/Collections/Documents/Action.php @@ -265,13 +265,16 @@ abstract class Action extends DatabasesAction } elseif (\is_array($relation) && !\array_is_list($relation)) { $relationId = $relation['$id'] ?? null; } else { - throw new Exception(Exception::GENERAL_BAD_REQUEST, 'Relationship value must be an object, document ID string, or associative array'); + throw new Exception(Exception::RELATIONSHIP_VALUE_INVALID, 'Relationship value must be an object, document ID string, or associative array'); } if ($relationId !== null) { + if (!\is_string($relationId)) { + throw new Exception(Exception::RELATIONSHIP_VALUE_INVALID, 'Relationship $id must be a string'); + } $validator = new CustomId(); if (!$validator->isValid($relationId)) { - throw new Exception(Exception::GENERAL_BAD_REQUEST, $validator->getDescription()); + throw new Exception(Exception::RELATIONSHIP_VALUE_INVALID, $validator->getDescription()); } } }