From ab4401992c460489d8f1e645d26592cd4caae404 Mon Sep 17 00:00:00 2001
From: loks0n <22452787+loks0n@users.noreply.github.com>
Date: Thu, 30 May 2024 16:36:05 +0100
Subject: [PATCH] Revert "feat: use param instead"

This reverts commit 72cca45d6d6d714398b75aaf2832faf7fa82dad1.
---
 src/Appwrite/Platform/Workers/Messaging.php | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/src/Appwrite/Platform/Workers/Messaging.php b/src/Appwrite/Platform/Workers/Messaging.php
index a58f2e12ba..6f642fabb7 100644
--- a/src/Appwrite/Platform/Workers/Messaging.php
+++ b/src/Appwrite/Platform/Workers/Messaging.php
@@ -400,7 +400,9 @@ class Messaging extends Action
                 'twilio' => [
                     'accountSid' => $user,
                     'authToken' => $password,
-                    'messagingServiceSid' => $smsDSN->getParam('messagingServiceSid') ?? null
+                    // Twilio Messaging Service SIDs always start with MG
+                    // https://www.twilio.com/docs/messaging/services
+                    'messagingServiceSid' => \str_starts_with($from, 'MG') ? $from : null
                 ],
                 'textmagic' => [
                     'username' => $user,
@@ -423,7 +425,7 @@ class Messaging extends Action
             },
             'options' => match ($host) {
                 'twilio' => [
-                    'from' => $smsDSN->getParam('messagingServiceSid') ? null : $from
+                    'from' => \str_starts_with($from, 'MG') ? null : $from
                 ],
                 default => [
                     'from' => $from