From 65e2e7945751dc053ae5416f2e2b69e4532217f9 Mon Sep 17 00:00:00 2001 From: Steven Nguyen Date: Mon, 4 Sep 2023 16:10:49 -0700 Subject: [PATCH] Fix create execution request filter from previous SDK version When an older SDK executes a function without passing any data, the data param is unset/null so we need to make sure to handle that case. --- src/Appwrite/Utopia/Request/Filters/V16.php | 2 +- tests/unit/Utopia/Request/Filters/V16Test.php | 6 ++++++ 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/src/Appwrite/Utopia/Request/Filters/V16.php b/src/Appwrite/Utopia/Request/Filters/V16.php index 5413b2fce4..51b05359b3 100644 --- a/src/Appwrite/Utopia/Request/Filters/V16.php +++ b/src/Appwrite/Utopia/Request/Filters/V16.php @@ -17,7 +17,7 @@ class V16 extends Filter $content['commands'] = $this->getCommands($content['runtime'] ?? ''); break; case 'functions.createExecution': - $content['body'] = $content['data']; + $content['body'] = $content['data'] ?? ''; unset($content['data']); break; } diff --git a/tests/unit/Utopia/Request/Filters/V16Test.php b/tests/unit/Utopia/Request/Filters/V16Test.php index 25b97a0ce4..daa1d45a0d 100644 --- a/tests/unit/Utopia/Request/Filters/V16Test.php +++ b/tests/unit/Utopia/Request/Filters/V16Test.php @@ -34,6 +34,12 @@ class V16Test extends TestCase 'body' => 'Lorem ipsum' ], ], + 'no data' => [ + [], + [ + 'body' => '' + ], + ], ]; }