From 2951a1b7b896ccbbf32ef3c5b4308527e11f6004 Mon Sep 17 00:00:00 2001 From: Chirag Aggarwal Date: Wed, 29 Oct 2025 15:11:42 +0530 Subject: [PATCH 1/3] fix: testListSites 2 not matching expected 1 --- tests/e2e/Services/Sites/SitesCustomServerTest.php | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tests/e2e/Services/Sites/SitesCustomServerTest.php b/tests/e2e/Services/Sites/SitesCustomServerTest.php index c8301b9428..a89d4e8099 100644 --- a/tests/e2e/Services/Sites/SitesCustomServerTest.php +++ b/tests/e2e/Services/Sites/SitesCustomServerTest.php @@ -641,7 +641,9 @@ class SitesCustomServerTest extends Scope 'siteId' => ID::unique() ]); - $sites = $this->listSites(); + $sites = $this->listSites([ + 'siteId' => $siteId, + ]); $this->assertEquals($sites['headers']['status-code'], 200); $this->assertCount(1, $sites['body']['sites']); From 1180dc0781ffd880045a998e52b1dd57a7a128fa Mon Sep 17 00:00:00 2001 From: Chirag Aggarwal Date: Wed, 29 Oct 2025 15:13:33 +0530 Subject: [PATCH 2/3] use search --- tests/e2e/Services/Sites/SitesCustomServerTest.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/e2e/Services/Sites/SitesCustomServerTest.php b/tests/e2e/Services/Sites/SitesCustomServerTest.php index a89d4e8099..6a5af920cc 100644 --- a/tests/e2e/Services/Sites/SitesCustomServerTest.php +++ b/tests/e2e/Services/Sites/SitesCustomServerTest.php @@ -634,7 +634,7 @@ class SitesCustomServerTest extends Scope 'buildRuntime' => 'node-22', 'fallbackFile' => '', 'framework' => 'other', - 'name' => 'Test Site', + 'name' => 'Test List Sites', 'outputDirectory' => './', 'providerBranch' => 'main', 'providerRootDirectory' => './', @@ -642,7 +642,7 @@ class SitesCustomServerTest extends Scope ]); $sites = $this->listSites([ - 'siteId' => $siteId, + 'search' => 'Test List Sites', ]); $this->assertEquals($sites['headers']['status-code'], 200); From d995dbb1590d7b56e54b2f1f57a99bb7b9f14b02 Mon Sep 17 00:00:00 2001 From: Chirag Aggarwal Date: Wed, 29 Oct 2025 15:19:16 +0530 Subject: [PATCH 3/3] fix: naming --- .../Services/Sites/SitesCustomServerTest.php | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/tests/e2e/Services/Sites/SitesCustomServerTest.php b/tests/e2e/Services/Sites/SitesCustomServerTest.php index 6a5af920cc..8591514796 100644 --- a/tests/e2e/Services/Sites/SitesCustomServerTest.php +++ b/tests/e2e/Services/Sites/SitesCustomServerTest.php @@ -647,7 +647,7 @@ class SitesCustomServerTest extends Scope $this->assertEquals($sites['headers']['status-code'], 200); $this->assertCount(1, $sites['body']['sites']); - $this->assertEquals($sites['body']['sites'][0]['name'], 'Test Site'); + $this->assertEquals($sites['body']['sites'][0]['name'], 'Test List Sites'); // Test pagination limit $sites = $this->listSites([ @@ -691,7 +691,7 @@ class SitesCustomServerTest extends Scope // Test search name $sites = $this->listSites([ - 'search' => 'Test' + 'search' => 'Test List Sites' ]); $this->assertEquals($sites['headers']['status-code'], 200); @@ -714,21 +714,23 @@ class SitesCustomServerTest extends Scope 'buildRuntime' => 'node-22', 'fallbackFile' => '', 'framework' => 'other', - 'name' => 'Test Site 2', + 'name' => 'Test List Sites 2', 'outputDirectory' => './', 'providerBranch' => 'main', 'providerRootDirectory' => './', 'siteId' => ID::unique() ]); - $sites = $this->listSites(); + $sites = $this->listSites([ + 'search' => 'Test List Sites', + ]); $this->assertEquals($sites['headers']['status-code'], 200); $this->assertEquals($sites['body']['total'], 2); $this->assertIsArray($sites['body']['sites']); $this->assertCount(2, $sites['body']['sites']); - $this->assertEquals($sites['body']['sites'][0]['name'], 'Test Site'); - $this->assertEquals($sites['body']['sites'][1]['name'], 'Test Site 2'); + $this->assertEquals($sites['body']['sites'][0]['name'], 'Test List Sites'); + $this->assertEquals($sites['body']['sites'][1]['name'], 'Test List Sites 2'); $sites1 = $this->listSites([ 'queries' => [ @@ -738,7 +740,7 @@ class SitesCustomServerTest extends Scope $this->assertEquals($sites1['headers']['status-code'], 200); $this->assertCount(1, $sites1['body']['sites']); - $this->assertEquals($sites1['body']['sites'][0]['name'], 'Test Site 2'); + $this->assertEquals($sites1['body']['sites'][0]['name'], 'Test List Sites 2'); $sites2 = $this->listSites([ 'queries' => [ @@ -748,7 +750,7 @@ class SitesCustomServerTest extends Scope $this->assertEquals($sites2['headers']['status-code'], 200); $this->assertCount(1, $sites2['body']['sites']); - $this->assertEquals($sites2['body']['sites'][0]['name'], 'Test Site'); + $this->assertEquals($sites2['body']['sites'][0]['name'], 'Test List Sites'); /** * Test for FAILURE