From 5e5ca0ba1614551deba4c505aee346a13667063c Mon Sep 17 00:00:00 2001 From: Torsten Dittmann Date: Wed, 14 Sep 2022 09:12:17 +0200 Subject: [PATCH] adapt to review --- src/Appwrite/Migration/Migration.php | 7 ++----- src/Appwrite/Migration/Version/V15.php | 7 ++++++- 2 files changed, 8 insertions(+), 6 deletions(-) diff --git a/src/Appwrite/Migration/Migration.php b/src/Appwrite/Migration/Migration.php index 52de2c6022..a17a962471 100644 --- a/src/Appwrite/Migration/Migration.php +++ b/src/Appwrite/Migration/Migration.php @@ -41,7 +41,8 @@ abstract class Migration * @var array */ public static array $versions = [ - '1.0.0-RC1' => 'V15' + '1.0.0-RC1' => 'V15', + '1.0.0' => 'V15' ]; /** @@ -123,10 +124,6 @@ abstract class Migration } catch (\Throwable $th) { Console::error('Failed to update document: ' . $th->getMessage()); return; - - if ($document && $new->getId() !== $document->getId()) { - throw new Exception('Duplication Error'); - } } }, $document, $callback); } diff --git a/src/Appwrite/Migration/Version/V15.php b/src/Appwrite/Migration/Version/V15.php index b7c7e6a9a9..5d58936d9f 100644 --- a/src/Appwrite/Migration/Version/V15.php +++ b/src/Appwrite/Migration/Version/V15.php @@ -732,7 +732,12 @@ class V15 extends Migration Console::log("Migrating Collection \"{$id}\" Variables"); foreach ($this->documentsIterator($id) as $function) { - foreach ($function->getAttribute('vars', []) as $key => $value) { + $vars = $function->getAttribute('vars', []); + if (!is_array($vars)) { + continue; + } + + foreach ($vars as $key => $value) { if ($value instanceof Document) { continue; }