mirror of
https://github.com/appwrite/appwrite
synced 2026-05-24 01:18:37 +00:00
PR review changes
This commit is contained in:
parent
f4a4cfa207
commit
50c2ebc950
1 changed files with 2 additions and 5 deletions
|
|
@ -169,7 +169,6 @@ class Certificates extends Action
|
||||||
$success = true;
|
$success = true;
|
||||||
} catch (Throwable $e) {
|
} catch (Throwable $e) {
|
||||||
$logs = $e->getMessage();
|
$logs = $e->getMessage();
|
||||||
$finalException = $e;
|
|
||||||
|
|
||||||
// Set exception as log in certificate document
|
// Set exception as log in certificate document
|
||||||
$certificate->setAttribute('logs', \mb_strcut($logs, 0, 1000000));// Limit to 1MB
|
$certificate->setAttribute('logs', \mb_strcut($logs, 0, 1000000));// Limit to 1MB
|
||||||
|
|
@ -183,6 +182,8 @@ class Certificates extends Action
|
||||||
|
|
||||||
// Send email to security email
|
// Send email to security email
|
||||||
$this->notifyError($domain->get(), $e->getMessage(), $attempts, $queueForMails);
|
$this->notifyError($domain->get(), $e->getMessage(), $attempts, $queueForMails);
|
||||||
|
|
||||||
|
throw $e;
|
||||||
} finally {
|
} finally {
|
||||||
// All actions result in new updatedAt date
|
// All actions result in new updatedAt date
|
||||||
$certificate->setAttribute('updated', DateTime::now());
|
$certificate->setAttribute('updated', DateTime::now());
|
||||||
|
|
@ -190,10 +191,6 @@ class Certificates extends Action
|
||||||
// Save all changes we made to certificate document into database
|
// Save all changes we made to certificate document into database
|
||||||
$this->saveCertificateDocument($domain->get(), $certificate, $success, $dbForConsole, $queueForEvents, $queueForFunctions);
|
$this->saveCertificateDocument($domain->get(), $certificate, $success, $dbForConsole, $queueForEvents, $queueForFunctions);
|
||||||
}
|
}
|
||||||
|
|
||||||
if (isset($finalException)) {
|
|
||||||
throw $finalException;
|
|
||||||
}
|
|
||||||
}
|
}
|
||||||
|
|
||||||
/**
|
/**
|
||||||
|
|
|
||||||
Loading…
Reference in a new issue