From 738b08aab54d4615738d4c067d8c1d9af1239362 Mon Sep 17 00:00:00 2001 From: Binyamin Yawitz <316103+byawitz@users.noreply.github.com> Date: Fri, 9 Aug 2024 12:43:05 -0400 Subject: [PATCH 1/3] fix: Updating benchmark comment instead of a new one --- .github/workflows/tests.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index 3e5cb35721..c4e911b340 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -8,7 +8,7 @@ env: IMAGE: appwrite-dev CACHE_KEY: appwrite-dev-${{ github.event.pull_request.head.sha }} -on: [pull_request] +on: [ pull_request ] jobs: setup: @@ -216,3 +216,4 @@ jobs: uses: thollander/actions-comment-pull-request@v2 with: filePath: benchmark.txt + comment_tag: benchmark From bd30c9c1532e9bb560a46fa9818f50069f542994 Mon Sep 17 00:00:00 2001 From: Binyamin Yawitz <316103+byawitz@users.noreply.github.com> Date: Fri, 9 Aug 2024 14:19:30 -0400 Subject: [PATCH 2/3] fix: checking other package --- .github/workflows/tests.yml | 17 +++++++++++++---- 1 file changed, 13 insertions(+), 4 deletions(-) diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index c4e911b340..d6b8c3e0c1 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -212,8 +212,17 @@ jobs: name: benchmark.json path: benchmark.json retention-days: 7 - - name: Comment on PR - uses: thollander/actions-comment-pull-request@v2 + - name: Find Comment + uses: peter-evans/find-comment@v3 + id: fc with: - filePath: benchmark.txt - comment_tag: benchmark + issue-number: ${{ github.event.pull_request.number }} + comment-author: 'github-actions[bot]' + body-includes: Benchmark results + - name: Comment on PR + uses: peter-evans/create-or-update-comment@v4 + with: + comment-id: ${{ steps.fc.outputs.comment-id }} + issue-number: ${{ github.event.pull_request.number }} + body-path: benchmark.txt + edit-mode: replace From 6f1e3722bb7e37e33f6f2d451b88d87a2eb4e057 Mon Sep 17 00:00:00 2001 From: Binyamin Yawitz <316103+byawitz@users.noreply.github.com> Date: Fri, 9 Aug 2024 14:44:51 -0400 Subject: [PATCH 3/3] fix: checking another package --- .github/workflows/tests.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index d6b8c3e0c1..633bd46ea4 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -8,7 +8,7 @@ env: IMAGE: appwrite-dev CACHE_KEY: appwrite-dev-${{ github.event.pull_request.head.sha }} -on: [ pull_request ] +on: [pull_request] jobs: setup: