From 4b78169152a01cc4d9d2feb4ba11f496c336d41e Mon Sep 17 00:00:00 2001 From: Jake Barnby Date: Mon, 8 Aug 2022 22:59:16 +1200 Subject: [PATCH] Fix setting default permissions --- src/Appwrite/Permissions/PermissionsProcessor.php | 15 ++++++--------- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/src/Appwrite/Permissions/PermissionsProcessor.php b/src/Appwrite/Permissions/PermissionsProcessor.php index c4e638111c..ec88972b59 100644 --- a/src/Appwrite/Permissions/PermissionsProcessor.php +++ b/src/Appwrite/Permissions/PermissionsProcessor.php @@ -4,6 +4,7 @@ namespace Appwrite\Permissions; use Appwrite\Auth\Auth; use Utopia\Database\Database; +use Utopia\Database\Document; use Utopia\Database\Validator\Authorization; class PermissionsProcessor @@ -38,10 +39,10 @@ class PermissionsProcessor $permissions = []; if (!empty($userId)) { $permissions = [ - 'read(user:' . $userId . ') ', - 'create(user:' . $userId . ') ', - 'update(user:' . $userId . ') ', - 'delete(user:' . $userId . ') ', + 'read(user:' . $userId . ')', + 'create(user:' . $userId . ')', + 'update(user:' . $userId . ')', + 'delete(user:' . $userId . ')', ]; } return $permissions; @@ -54,12 +55,8 @@ class PermissionsProcessor return $permissions; } - public static function allowedForUserType(?array $permissions): bool + public static function allowedForUserType(array $permissions): bool { - if (\is_null($permissions)) { - return false; - } - // Users can only manage their own roles, API keys and Admin users can manage any $roles = Authorization::getRoles();