From 48834cd114d50581265e33fd17aa5f3a17470eac Mon Sep 17 00:00:00 2001
From: Chirag Aggarwal <chiragaggarwal5k@gmail.com>
Date: Mon, 11 Aug 2025 09:21:12 +0530
Subject: [PATCH] chore: make check for adding warning header stricter

---
 app/controllers/general.php | 12 ++++++++++--
 1 file changed, 10 insertions(+), 2 deletions(-)

diff --git a/app/controllers/general.php b/app/controllers/general.php
index ee580e6f07..5accae6a32 100644
--- a/app/controllers/general.php
+++ b/app/controllers/general.php
@@ -1038,11 +1038,19 @@ App::init()
         /**
          * Deprecation Warning
          */
+        /** @var \Appwrite\SDK\Method $sdk */
         $sdk = $route->getLabel('sdk', false);
         $deprecationWarning = 'This route is deprecated. See the updated documentation for improved compatibility and migration details.';
         $sdkItems = is_array($sdk) ? $sdk : (!empty($sdk) ? [$sdk] : []);
-        foreach ($sdkItems as $sdkItem) {
-            if ($sdkItem->isDeprecated()) {
+        if (!empty($sdkItems) && count($sdkItems) > 0) {
+            $allDeprecated = true;
+            foreach ($sdkItems as $sdkItem) {
+                if (!$sdkItem->isDeprecated()) {
+                    $allDeprecated = false;
+                    break;
+                }
+            }
+            if ($allDeprecated) {
                 $warnings[] = $deprecationWarning;
             }
         }