From 3896cd3d39d617b982a51f552335849952372731 Mon Sep 17 00:00:00 2001 From: Jake Barnby Date: Thu, 14 Jul 2022 01:34:25 +1200 Subject: [PATCH] No content responses --- app/controllers/api/projects.php | 8 ++++---- app/controllers/api/storage.php | 2 +- app/controllers/api/teams.php | 4 ++-- app/controllers/mock.php | 2 +- 4 files changed, 8 insertions(+), 8 deletions(-) diff --git a/app/controllers/api/projects.php b/app/controllers/api/projects.php index 0a6f66e408..86996f4a58 100644 --- a/app/controllers/api/projects.php +++ b/app/controllers/api/projects.php @@ -552,7 +552,7 @@ App::delete('/v1/projects/:projectId') throw new Exception('Failed to remove project from DB', 500, Exception::GENERAL_SERVER_ERROR); } - $response->dynamic(new Document(), Response::MODEL_NONE); + $response->noContent(); }); // Webhooks @@ -801,7 +801,7 @@ App::delete('/v1/projects/:projectId/webhooks/:webhookId') $dbForConsole->deleteCachedDocument('projects', $project->getId()); - $response->dynamic(new Document(), Response::MODEL_NONE); + $response->noContent(); }); // Keys @@ -996,7 +996,7 @@ App::delete('/v1/projects/:projectId/keys/:keyId') $dbForConsole->deleteCachedDocument('projects', $project->getId()); - $response->dynamic(new Document(), Response::MODEL_NONE); + $response->noContent(); }); // Platforms @@ -1194,7 +1194,7 @@ App::delete('/v1/projects/:projectId/platforms/:platformId') $dbForConsole->deleteCachedDocument('projects', $project->getId()); - $response->dynamic(new Document(), Response::MODEL_NONE); + $response->noContent(); }); // Domains diff --git a/app/controllers/api/storage.php b/app/controllers/api/storage.php index 9b2dda496f..b62aa750db 100644 --- a/app/controllers/api/storage.php +++ b/app/controllers/api/storage.php @@ -1463,7 +1463,7 @@ App::delete('/v1/storage/buckets/:bucketId/files/:fileId') ->setPayload($response->output($file, Response::MODEL_FILE)) ; - $response->dynamic(new Document(), Response::MODEL_NONE); + $response->noContent(); }); App::get('/v1/storage/usage') diff --git a/app/controllers/api/teams.php b/app/controllers/api/teams.php index b6b4379480..383bcac149 100644 --- a/app/controllers/api/teams.php +++ b/app/controllers/api/teams.php @@ -264,7 +264,7 @@ App::delete('/v1/teams/:teamId') ->setParam('data', $team->getArrayCopy()) ; - $response->dynamic(new Document(), Response::MODEL_NONE); + $response->noContent(); }); App::post('/v1/teams/:teamId/memberships') @@ -820,7 +820,7 @@ App::delete('/v1/teams/:teamId/memberships/:membershipId') ->setPayload($response->output($membership, Response::MODEL_MEMBERSHIP)) ; - $response->dynamic(new Document(), Response::MODEL_NONE); + $response->noContent(); }); App::get('/v1/teams/:teamId/logs') diff --git a/app/controllers/mock.php b/app/controllers/mock.php index 4240d62701..f681cb2482 100644 --- a/app/controllers/mock.php +++ b/app/controllers/mock.php @@ -392,7 +392,7 @@ App::get('/v1/mock/tests/general/empty') ->inject('response') ->action(function (Response $response) { - $response->dynamic(new Document(), Response::MODEL_NONE); + $response->noContent(); }); App::get('/v1/mock/tests/general/400-error')