From dcc676a0c920b7f267b352f5c91074bbe038c712 Mon Sep 17 00:00:00 2001 From: Steven Nguyen Date: Thu, 31 Aug 2023 12:21:44 -0700 Subject: [PATCH] Make install confirmation case insensitive When a previous installation is found during installation/upgrade, the user is prompted to confirm whether they want to overwrite it. We originally only accepted 'Y', but this PR changes it to accept 'y' as well to reduce friction. --- CHANGES.md | 8 ++++++++ src/Appwrite/Platform/Tasks/Install.php | 2 +- 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/CHANGES.md b/CHANGES.md index 2d9af087db..6441a6e438 100644 --- a/CHANGES.md +++ b/CHANGES.md @@ -1,3 +1,11 @@ +# Version 1.4.2 + +## Fixes + +## Changes + +- Make installation confirmation case insensitive [#6097](https://github.com/appwrite/appwrite/pull/6097) + # Version 1.4.1 ## Features diff --git a/src/Appwrite/Platform/Tasks/Install.php b/src/Appwrite/Platform/Tasks/Install.php index 22355d0269..c9ed1d733e 100644 --- a/src/Appwrite/Platform/Tasks/Install.php +++ b/src/Appwrite/Platform/Tasks/Install.php @@ -70,7 +70,7 @@ class Install extends Action if ($interactive == 'Y' && Console::isInteractive()) { $answer = Console::confirm('Previous installation found, do you want to overwrite it (a backup will be created before overwriting)? (Y/n)'); - if ($answer !== 'Y') { + if (\strtolower($answer) !== 'y') { Console::info('No action taken.'); return; }