From ffdfc3622956a4045b4b86ac87c85a2518a476c0 Mon Sep 17 00:00:00 2001 From: Eldad Fux Date: Sat, 21 Nov 2020 01:44:00 +0200 Subject: [PATCH 1/4] Skip mail when no SMTP hostname set --- app/workers/mails.php | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/app/workers/mails.php b/app/workers/mails.php index e80759cead..dcb5026bda 100644 --- a/app/workers/mails.php +++ b/app/workers/mails.php @@ -1,6 +1,7 @@ args['event']; $from = $this->args['from']; $recipient = $this->args['recipient']; From 1afd9f2c5be9735765bfcb9e7e4c25ef92c71a35 Mon Sep 17 00:00:00 2001 From: Eldad Fux Date: Sat, 21 Nov 2020 08:26:22 +0200 Subject: [PATCH 2/4] Updated log description --- app/workers/mails.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/workers/mails.php b/app/workers/mails.php index dcb5026bda..a7f6f6c235 100644 --- a/app/workers/mails.php +++ b/app/workers/mails.php @@ -25,7 +25,7 @@ class MailsV1 global $register; if(empty(App::getEnv('_APP_SMTP_HOST'))) { - Console::info('Skipped mail. No SMTP server hostname has been set.'); + Console::info('Skipped mail processing. No SMTP server hostname has been set.'); return; } From 1a1204ad1ad21d3ae2f8d548268b7001d3ef3a8f Mon Sep 17 00:00:00 2001 From: Eldad Fux Date: Sat, 21 Nov 2020 13:19:21 +0200 Subject: [PATCH 3/4] Updated changelog --- CHANGES.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGES.md b/CHANGES.md index 9aadc06e46..b90dd2f1ea 100644 --- a/CHANGES.md +++ b/CHANGES.md @@ -40,6 +40,7 @@ - Upgraded Traefik image to version 2.3 - Upgraded Redis Docker image to version 6.0 (alpine) - Upgraded Influxdb Docker image to version 1.8 (alpine) +- Added option to disable mail sending by setting empty SMTP host ## Breaking Changes (Read before upgrading!) - **Deprecated** `first` and `last` query params for documents list route in the database API From fc6d7a2e313efaf38fdd82ad59e392a96e2dc064 Mon Sep 17 00:00:00 2001 From: Eldad Fux Date: Sat, 21 Nov 2020 13:21:04 +0200 Subject: [PATCH 4/4] Updated docs --- docs/tutorials/environment-variables.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/tutorials/environment-variables.md b/docs/tutorials/environment-variables.md index 7de4c95e49..3ab2183ff2 100644 --- a/docs/tutorials/environment-variables.md +++ b/docs/tutorials/environment-variables.md @@ -112,7 +112,7 @@ If running in production, it might be easier to use a 3rd party SMTP server as i ### _APP_SMTP_HOST -SMTP server host name address. Default value is: 'smtp' +SMTP server host name address. Default value is: 'smtp'. Pass an empty string to disable all mail sending from the server. ### _APP_SMTP_PORT