From 7d284a9872bc124c868359a1219833deb1cf8c3f Mon Sep 17 00:00:00 2001 From: Khushboo Verma Date: Thu, 29 May 2025 14:34:21 +0530 Subject: [PATCH 1/6] Remove powered by from error pages --- app/views/general/error.phtml | 4 ++-- tests/e2e/Services/Sites/SitesCustomServerTest.php | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/app/views/general/error.phtml b/app/views/general/error.phtml index de1c2b6541..9706c8ee94 100644 --- a/app/views/general/error.phtml +++ b/app/views/general/error.phtml @@ -512,7 +512,7 @@ switch ($type) { -
+ \ No newline at end of file diff --git a/tests/e2e/Services/Sites/SitesCustomServerTest.php b/tests/e2e/Services/Sites/SitesCustomServerTest.php index d3b4922b87..3a70a21e37 100644 --- a/tests/e2e/Services/Sites/SitesCustomServerTest.php +++ b/tests/e2e/Services/Sites/SitesCustomServerTest.php @@ -1446,7 +1446,7 @@ class SitesCustomServerTest extends Scope $this->assertEquals(404, $response['headers']['status-code']); $this->assertStringContainsString("Page not found", $response['body']); // Title $this->assertStringContainsString("Go to homepage", $response['body']); // Button - $this->assertStringContainsString("Powered by", $response['body']); // Brand + // $this->assertStringContainsString("Powered by", $response['body']); // Brand $this->cleanupSite($siteId); } @@ -1502,7 +1502,7 @@ class SitesCustomServerTest extends Scope $this->assertEquals(200, $response['headers']['status-code']); $this->assertStringContainsString("Customized 404 page", $response['body']); - $this->assertStringNotContainsString("Powered by", $response['body']); // Brand + // $this->assertStringNotContainsString("Powered by", $response['body']); // Brand $this->cleanupSite($siteId); } From c4510004ce15969edd951c7187a772182351a120 Mon Sep 17 00:00:00 2001 From: Khushboo Verma Date: Thu, 29 May 2025 14:46:25 +0530 Subject: [PATCH 2/6] update test --- tests/e2e/Services/Sites/SitesCustomServerTest.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/e2e/Services/Sites/SitesCustomServerTest.php b/tests/e2e/Services/Sites/SitesCustomServerTest.php index 3a70a21e37..8459e46c6f 100644 --- a/tests/e2e/Services/Sites/SitesCustomServerTest.php +++ b/tests/e2e/Services/Sites/SitesCustomServerTest.php @@ -1446,7 +1446,7 @@ class SitesCustomServerTest extends Scope $this->assertEquals(404, $response['headers']['status-code']); $this->assertStringContainsString("Page not found", $response['body']); // Title $this->assertStringContainsString("Go to homepage", $response['body']); // Button - // $this->assertStringContainsString("Powered by", $response['body']); // Brand + $this->assertStringNotContainsString("Powered by", $response['body']); // Brand $this->cleanupSite($siteId); } @@ -1502,7 +1502,7 @@ class SitesCustomServerTest extends Scope $this->assertEquals(200, $response['headers']['status-code']); $this->assertStringContainsString("Customized 404 page", $response['body']); - // $this->assertStringNotContainsString("Powered by", $response['body']); // Brand + $this->assertStringNotContainsString("Powered by", $response['body']); //brand $this->cleanupSite($siteId); } From 0a80ffe4a7e6b781e9eaf3cd42f876fc5c6b6554 Mon Sep 17 00:00:00 2001 From: Khushboo Verma Date: Thu, 29 May 2025 18:29:15 +0530 Subject: [PATCH 3/6] Fix error --- tests/e2e/Services/Sites/SitesCustomServerTest.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/e2e/Services/Sites/SitesCustomServerTest.php b/tests/e2e/Services/Sites/SitesCustomServerTest.php index 8459e46c6f..879182539a 100644 --- a/tests/e2e/Services/Sites/SitesCustomServerTest.php +++ b/tests/e2e/Services/Sites/SitesCustomServerTest.php @@ -1446,7 +1446,7 @@ class SitesCustomServerTest extends Scope $this->assertEquals(404, $response['headers']['status-code']); $this->assertStringContainsString("Page not found", $response['body']); // Title $this->assertStringContainsString("Go to homepage", $response['body']); // Button - $this->assertStringNotContainsString("Powered by", $response['body']); // Brand + $this->assertStringContainsString("Powered by", $response['body']); // Brand $this->cleanupSite($siteId); } From 502b7df2d0b18393b17890c033fbaedef9889cf2 Mon Sep 17 00:00:00 2001 From: Khushboo Verma Date: Fri, 30 May 2025 11:26:05 +0530 Subject: [PATCH 4/6] Remove powered by from all error pages --- app/views/general/404.phtml | 4 ++-- tests/e2e/Services/Sites/SitesCustomServerTest.php | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/app/views/general/404.phtml b/app/views/general/404.phtml index 5e63344c8a..fb06c07f3e 100644 --- a/app/views/general/404.phtml +++ b/app/views/general/404.phtml @@ -152,7 +152,7 @@
-
+ \ No newline at end of file diff --git a/tests/e2e/Services/Sites/SitesCustomServerTest.php b/tests/e2e/Services/Sites/SitesCustomServerTest.php index 879182539a..8459e46c6f 100644 --- a/tests/e2e/Services/Sites/SitesCustomServerTest.php +++ b/tests/e2e/Services/Sites/SitesCustomServerTest.php @@ -1446,7 +1446,7 @@ class SitesCustomServerTest extends Scope $this->assertEquals(404, $response['headers']['status-code']); $this->assertStringContainsString("Page not found", $response['body']); // Title $this->assertStringContainsString("Go to homepage", $response['body']); // Button - $this->assertStringContainsString("Powered by", $response['body']); // Brand + $this->assertStringNotContainsString("Powered by", $response['body']); // Brand $this->cleanupSite($siteId); } From 34150f0c380dbe79b2213088378598fdba519cf1 Mon Sep 17 00:00:00 2001 From: Khushboo Verma Date: Fri, 30 May 2025 12:39:33 +0530 Subject: [PATCH 5/6] Remove div --- app/views/general/404.phtml | 31 ------------------------------- 1 file changed, 31 deletions(-) diff --git a/app/views/general/404.phtml b/app/views/general/404.phtml index fb06c07f3e..2a9ff7f312 100644 --- a/app/views/general/404.phtml +++ b/app/views/general/404.phtml @@ -151,37 +151,6 @@
- - \ No newline at end of file From b3098085924e4a1df7d0d242ad8347ab6c478f71 Mon Sep 17 00:00:00 2001 From: Khushboo Verma Date: Fri, 30 May 2025 14:18:35 +0530 Subject: [PATCH 6/6] Remove all 'powered by' divs --- app/views/general/error.phtml | 30 ------------------------------ 1 file changed, 30 deletions(-) diff --git a/app/views/general/error.phtml b/app/views/general/error.phtml index 9706c8ee94..a427f1d5e8 100644 --- a/app/views/general/error.phtml +++ b/app/views/general/error.phtml @@ -512,36 +512,6 @@ switch ($type) { - \ No newline at end of file