From 67279bbda897f60ca48029e68aa459243c755ff6 Mon Sep 17 00:00:00 2001 From: Eldad Fux Date: Wed, 4 Nov 2020 12:15:25 +0200 Subject: [PATCH] Added some code review fixes --- app/tasks/doctor.php | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/app/tasks/doctor.php b/app/tasks/doctor.php index 3bcf25a3d7..f152c90ea7 100644 --- a/app/tasks/doctor.php +++ b/app/tasks/doctor.php @@ -40,7 +40,7 @@ $cli Console::log('🟢 CNAME target has a public suffix ('.$domain->get().')'); } - if(App::getEnv('_APP_OPENSSL_KEY_V1', 'your-secret-key') === 'your-secret-key' || empty(App::getEnv('_APP_OPENSSL_KEY_V1', 'your-secret-key'))) { + if(App::getEnv('_APP_OPENSSL_KEY_V1') === 'your-secret-key' || empty(App::getEnv('_APP_OPENSSL_KEY_V1'))) { Console::log('🔴 Using a unique secret key for encryption'); } else { @@ -54,7 +54,7 @@ $cli Console::log('🟢 App enviornment is set for production'); } - if(App::getEnv('_APP_OPTIONS_ABUSE', 'disabled') === 'disabled' || empty(App::getEnv('_APP_OPTIONS_ABUSE', 'disabled'))) { + if('enabled' !== App::getEnv('_APP_OPTIONS_ABUSE', 'disabled')) { Console::log('🔴 Abuse protection is enabled'); } else { @@ -75,7 +75,7 @@ $cli Console::log('🟢 Console access limits are enabled'); } - if('disabled' === App::getEnv('_APP_OPTIONS_FORCE_HTTPS', 'disabled') || empty(App::getEnv('_APP_OPTIONS_FORCE_HTTPS', 'disabled'))) { + if('enabled' !== App::getEnv('_APP_OPTIONS_FORCE_HTTPS', 'disabled')) { Console::log('🔴 HTTPS force option is disabled'); } else {