diff --git a/app/controllers/api/account.php b/app/controllers/api/account.php index 1111293f3b..f1575a08d7 100644 --- a/app/controllers/api/account.php +++ b/app/controllers/api/account.php @@ -1336,8 +1336,6 @@ App::post('/v1/account/sessions/phone') $message = $message->setParam('{{token}}', $secret); $message = $message->render(); - var_dump($request->getIP()); - var_dump($project->getId()); $queueForMessaging ->setRecipient($phone) ->setMessage($message) @@ -2939,8 +2937,6 @@ App::post('/v1/account/verification/phone') $message = $message->setParam('{{token}}', $secret); $message = $message->render(); - var_dump($request->getIP()); - var_dump($project->getId()); $queueForMessaging ->setRecipient($user->getAttribute('phone')) ->setMessage($message) diff --git a/app/controllers/api/health.php b/app/controllers/api/health.php index 1c5b68e9c3..a85f9da321 100644 --- a/app/controllers/api/health.php +++ b/app/controllers/api/health.php @@ -426,9 +426,9 @@ App::get('/v1/health/certificate') $sslExpiration = $certificatePayload['validTo_time_t']; - $status = ($sslExpiration < time()) ? 'fail' : 'pass'; + $status = $sslExpiration < time() ? 'fail' : 'pass'; - if ($status == 'fail') { + if ($status === 'fail') { throw new Exception(Exception::HEALTH_CERTIFICATE_EXPIRED); } diff --git a/app/controllers/api/teams.php b/app/controllers/api/teams.php index 6baad094db..a374c57cf1 100644 --- a/app/controllers/api/teams.php +++ b/app/controllers/api/teams.php @@ -380,7 +380,6 @@ App::post('/v1/teams/:teamId/memberships') ->param('roles', [], new ArrayList(new Key(), APP_LIMIT_ARRAY_PARAMS_SIZE), 'Array of strings. Use this param to set the user roles in the team. A role can be any string. Learn more about [roles and permissions](https://appwrite.io/docs/permissions). Maximum of ' . APP_LIMIT_ARRAY_PARAMS_SIZE . ' roles are allowed, each 32 characters long.') ->param('url', '', fn($clients) => new Host($clients), 'URL to redirect the user back to your app from the invitation email. Only URLs from hostnames in your project platform list are allowed. This requirement helps to prevent an [open redirect](https://cheatsheetseries.owasp.org/cheatsheets/Unvalidated_Redirects_and_Forwards_Cheat_Sheet.html) attack against your project API.', true, ['clients']) // TODO add our own built-in confirm page ->param('name', '', new Text(128), 'Name of the new team member. Max length: 128 chars.', true) - ->inject('request') ->inject('response') ->inject('project') ->inject('user') @@ -389,7 +388,7 @@ App::post('/v1/teams/:teamId/memberships') ->inject('queueForMails') ->inject('queueForMessaging') ->inject('queueForEvents') - ->action(function (string $teamId, string $email, string $userId, string $phone, array $roles, string $url, string $name, Request $request, Response $response, Document $project, Document $user, Database $dbForProject, Locale $locale, Mail $queueForMails, EventPhone $queueForMessaging, Event $queueForEvents) { + ->action(function (string $teamId, string $email, string $userId, string $phone, array $roles, string $url, string $name, Response $response, Document $project, Document $user, Database $dbForProject, Locale $locale, Mail $queueForMails, EventPhone $queueForMessaging, Event $queueForEvents) { $isAPIKey = Auth::isAppUser(Authorization::getRoles()); $isPrivilegedUser = Auth::isPrivilegedUser(Authorization::getRoles()); @@ -639,8 +638,6 @@ App::post('/v1/teams/:teamId/memberships') $message = $message->setParam('{{token}}', $url); $message = $message->render(); - var_dump($request->getIP()); - var_dump($project->getId()); $queueForMessaging ->setRecipient($phone) ->setMessage($message) diff --git a/src/Appwrite/Platform/Tasks/QueueCount.php b/src/Appwrite/Platform/Tasks/QueueCount.php index 61d4750fac..9b7bba82d1 100644 --- a/src/Appwrite/Platform/Tasks/QueueCount.php +++ b/src/Appwrite/Platform/Tasks/QueueCount.php @@ -58,18 +58,11 @@ class QueueCount extends Action $queueClient = new Client($name, $queue); - $count = 0; - - switch ($type) { - case 'success': - $count = $queueClient->countSuccessfulJobs(); - break; - case 'failed': - $count = $queueClient->countFailedJobs(); - break; - case 'processing': - $count = $queueClient->countProcessingJobs(); - break; + $count = match ($type) { + 'success' => $queueClient->countSuccessfulJobs(), + 'failed' => $queueClient->countFailedJobs(), + 'processing' => $queueClient->countProcessingJobs(), + default => 0 }; Console::log("Queue: '{$name}' has {$count} {$type} jobs.");