From 101283f345e6f9fb3ca3c4022281f39943dca217 Mon Sep 17 00:00:00 2001
From: Steven Nguyen <stnguyen90@users.noreply.github.com>
Date: Fri, 25 Apr 2025 16:07:59 -0700
Subject: [PATCH] fix: prevent update migration from clearing scopes and
 resetting specs

---
 src/Appwrite/Migration/Version/V21.php | 12 ++--
 src/Appwrite/Migration/Version/V22.php | 83 --------------------------
 2 files changed, 8 insertions(+), 87 deletions(-)
 delete mode 100644 src/Appwrite/Migration/Version/V22.php

diff --git a/src/Appwrite/Migration/Version/V21.php b/src/Appwrite/Migration/Version/V21.php
index 04e5adc5fb..c072c81a34 100644
--- a/src/Appwrite/Migration/Version/V21.php
+++ b/src/Appwrite/Migration/Version/V21.php
@@ -229,11 +229,15 @@ class V21 extends Migration
                 $document->setAttribute('accessedAt', DateTime::now());
                 break;
             case 'functions':
-                // Add scopes attribute
-                $document->setAttribute('scopes', []);
+                // Set scopes attribute
+                if (empty($document->getAttribute('scopes', []))) {
+                    $document->setAttribute('scopes', []);
+                }
 
-                // Add size attribute
-                $document->setAttribute('specification', APP_FUNCTION_SPECIFICATION_DEFAULT);
+                // Set specification attribute
+                if (empty($document->getAttribute('specification'))) {
+                    $document->setAttribute('specification', APP_FUNCTION_SPECIFICATION_DEFAULT);
+                }
         }
 
         return $document;
diff --git a/src/Appwrite/Migration/Version/V22.php b/src/Appwrite/Migration/Version/V22.php
deleted file mode 100644
index 4d15662112..0000000000
--- a/src/Appwrite/Migration/Version/V22.php
+++ /dev/null
@@ -1,83 +0,0 @@
-<?php
-
-namespace Appwrite\Migration\Version;
-
-use Appwrite\Migration\Migration;
-use Exception;
-use Throwable;
-use Utopia\CLI\Console;
-use Utopia\Database\Database;
-
-class V22 extends Migration
-{
-    /**
-     * @throws Throwable
-     */
-    public function execute(): void
-    {
-        /**
-        * Disable SubQueries for Performance.
-        */
-        foreach (['subQueryIndexes', 'subQueryPlatforms', 'subQueryDomains', 'subQueryKeys', 'subQueryWebhooks', 'subQuerySessions', 'subQueryTokens', 'subQueryMemberships', 'subQueryVariables', 'subQueryChallenges', 'subQueryProjectVariables', 'subQueryTargets', 'subQueryTopicTargets'] as $name) {
-            Database::addFilter(
-                $name,
-                fn () => null,
-                fn () => []
-            );
-        }
-
-        Console::info('Migrating Collections');
-        $this->migrateCollections();
-    }
-
-    /**
-     * Migrate Collections.
-     *
-     * @return void
-     * @throws Exception|Throwable
-     */
-    private function migrateCollections(): void
-    {
-        $internalProjectId = $this->project->getInternalId();
-        $collectionType = match ($internalProjectId) {
-            'console' => 'console',
-            default => 'projects',
-        };
-
-        $collections = $this->collections[$collectionType];
-        foreach ($collections as $collection) {
-            $id = $collection['$id'];
-
-            Console::log("Migrating Collection \"{$id}\"");
-
-            $this->projectDB->setNamespace("_$internalProjectId");
-
-            switch ($id) {
-                case 'installations':
-                    // Create personalAccessToken attribute
-                    try {
-                        $this->createAttributeFromCollection($this->projectDB, $id, 'personalAccessToken');
-                    } catch (Throwable $th) {
-                        Console::warning("'personalAccessToken' from {$id}: {$th->getMessage()}");
-                    }
-
-                    // Create personalAccessTokenExpiry attribute
-                    try {
-                        $this->createAttributeFromCollection($this->projectDB, $id, 'personalAccessTokenExpiry');
-                    } catch (Throwable $th) {
-                        Console::warning("'personalAccessTokenExpiry' from {$id}: {$th->getMessage()}");
-                    }
-
-                    // Create personalRefreshToken attribute
-                    try {
-                        $this->createAttributeFromCollection($this->projectDB, $id, 'personalRefreshToken');
-                    } catch (Throwable $th) {
-                        Console::warning("'personalRefreshToken' from {$id}: {$th->getMessage()}");
-                    }
-                    break;
-            }
-
-            usleep(50000);
-        }
-    }
-}