From 0fe59d457b08fbbf588a128e8a410e618d48308e Mon Sep 17 00:00:00 2001
From: Safwan Parkar <safwanparkar6@gmail.com>
Date: Tue, 1 Aug 2023 22:57:59 +0400
Subject: [PATCH] fixed stale team memberships on user

---
 app/controllers/api/teams.php | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/app/controllers/api/teams.php b/app/controllers/api/teams.php
index a06ab6b2a0..fe58129f1a 100644
--- a/app/controllers/api/teams.php
+++ b/app/controllers/api/teams.php
@@ -343,11 +343,17 @@ App::delete('/v1/teams/:teamId')
             Query::limit(2000), // TODO fix members limit
         ]);
 
-        // TODO delete all members individually from the user object
         foreach ($memberships as $membership) {
             if (!$dbForProject->deleteDocument('memberships', $membership->getId())) {
                 throw new Exception(Exception::GENERAL_SERVER_ERROR, 'Failed to remove membership for team from DB');
             }
+
+            $user = $dbForProject->getDocument('users', $membership->getAttribute('userId'));
+            $user->setAttribute('memberships', array_values(array_filter(
+                $user->getAttribute('memberships', []), 
+                fn($um) => $um['teamId'] !== $membership->getAttribute('teamId'))
+            ));
+            $dbForProject->updateDocument('users', $user->getId(), $user);
         }
 
         if (!$dbForProject->deleteDocument('teams', $teamId)) {