appwrite/phpstan.neon

parameters:
  level: 4
  tmpDir: .phpstan-cache
  paths:
    - src
    - app
    - bin
    - tests
  bootstrapFiles:
    - app/init/constants.php
  scanDirectories:
    - vendor/swoole/ide-helper
  excludePaths:
    - tests/resources
Convert to library approach 2025-02-11 13:26:49 +00:00			`parameters:`
chore: bump PHPStan to level 4 and fix all new errors Raises `phpstan.neon` level from 3 to 4 and fixes the 549 new errors that level 4 surfaces across 157 files. Fixes are root-cause — no `@phpstan-ignore`, no `@var` casts, no baseline entries, no widened types. A handful of latent bugs were fixed along the way: - `app/controllers/general.php`: path-traversal guard was negating `\substr(...)` before the strict comparison (`!\substr(...) === $base` was always `false === $base`). Rewritten as `\substr(...) !== $base`. - `src/Appwrite/Platform/Modules/Databases/Http/Databases/Logs/XList.php` and `.../TablesDB/Logs/XList.php`: were importing the raw Matomo `DeviceDetector` (whose `getDevice()` returns `?int`) but treating the result as an array with `deviceName/deviceBrand/deviceModel` keys. Swapped to `Appwrite\Detector\Detector`, matching the wrapper already used a few lines below for `$os`/`$client`. - `src/Appwrite/Platform/Modules/Functions/Workers/Builds.php`: a match key was checking `$resourceKey === 'functions'` when `$resourceKey` is `'functionId'\|'siteId'` — always false. Switched to the intended `$resource->getCollection() === 'functions'` check. - `src/Appwrite/OpenSSL/OpenSSL.php`: `encrypt()` return type tightened to `string\|false` to match `openssl_encrypt`; this lets callers' `=== false` error handling remain meaningful. - `app/controllers/api/messaging.php`: removed a dead `array_key_exists('from', [])` branch in the Msg91 provider (empty array literal; branch was unreachable). Large cleanup categories across the 549 fixes: - Removed redundant `?? default` on array offsets and expressions that PHPStan now knows are non-nullable. - Removed unreachable statements (mostly `return;` after `throw` or `markTestSkipped()`). - Removed redundant `is_array`/`is_string`/`is_bool`/`instanceof` checks on already-narrowed types. - Added `default =>` arms (or throwing arms) to non-exhaustive matches on `string`/`mixed` input. - Removed dead `$document === false` branches where method return types were tightened to non-nullable `Document`. - Removed unused properties (`$version` on Etsy/Zoom OAuth2, `$paths` on Installer State, `$source` on MigrationsWorker, `$account2` on two GraphQL auth tests), unused traits (`ApiVectorsDB`, `DatabaseFixture`), and an unused `cleanupStaleExecutions` task method. - Replaced `assertTrue(true)` and redundant `assertIsArray`/`assertIsString`/ `assertNotNull` assertions with `addToAssertionCount(1)` or `assertNotEmpty` where the runtime type was already known. 2026-04-19 12:01:20 +00:00			`level: 4`
Speed up PHPStan analysis with result caching Configure a project-local result cache directory so PHPStan only re-analyses files that changed. In CI, persist the cache across runs with actions/cache and suppress progress output. 2026-04-01 06:30:32 +00:00			`tmpDir: .phpstan-cache`
Convert to library approach 2025-02-11 13:26:49 +00:00			`paths:`
ci: upgrade PHPStan to v2 with baseline and full codebase coverage - Upgrade phpstan/phpstan from 1.12.* to ^2.0 - Raise analysis level to max - Expand paths from 3 specific dirs to src/, app/, bin/, tests/ - Generate baseline capturing 95,365 existing errors for incremental adoption - Rename composer script from `check` to `analyze` - Add --memory-limit=1G to handle larger scan scope Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> 2026-03-15 17:49:49 +00:00			`- src`
			`- app`
			`- bin`
			`- tests`
refactor: replace queueForExecutions with Bus event bus Introduce a generic event bus (Utopia\Bus) with typed events, listener base class, Span instrumentation, and coroutine dispatch. Replace all direct queueForExecutions and inline execution usage calls with ExecutionCompleted event and dedicated listeners (Log, Usage). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> 2026-02-13 12:28:26 +00:00			`bootstrapFiles:`
			`- app/init/constants.php`
Convert to library approach 2025-02-11 13:26:49 +00:00			`scanDirectories:`
			`- vendor/swoole/ide-helper`
			`excludePaths:`
Fix merge 2025-07-27 05:09:50 +00:00			`- tests/resources`