mirror of
https://github.com/angular/angular
synced 2026-05-24 09:28:37 +00:00
fa0104017a
Prior to this change, the template type checker would always use a type-constructor to instantiate a directive. This type-constructor call serves two purposes: 1. Infer any generic types for the directive instance from the inputs that are passed in. 2. Type check the inputs that are passed into the directive's inputs. The first purpose is only relevant when the directive actually has any generic types and using a type-constructor for these cases inhibits a type-check performance penalty, as a type-constructor's signature is quite complex and needs to be generated for each directive. This commit refactors the generated type-check blocks to only generate a type-constructor call for directives that have generic types. Type checking of inputs is achieved by generating individual statements for all inputs, using assignments into the directive's fields. Even if a type-constructor is used for type-inference of generic types will the input checking also be achieved using the individual assignment statements. This is done to support the rework of the language service, which will start to extract symbol information from the type-check blocks. As a future optimization, it may be possible to reduce the number of inputs passed into a type-constructor to only those inputs that contribute the the type-inference of the generics. As this is not a necessity at the moment this is left as follow-up work. Closes #38185 PR Close #38249 |
||
|---|---|---|
| .. | ||
| annotations | ||
| core | ||
| cycles | ||
| diagnostics | ||
| entry_point | ||
| file_system | ||
| imports | ||
| incremental | ||
| indexer | ||
| logging | ||
| metadata | ||
| modulewithproviders | ||
| partial_evaluator | ||
| perf | ||
| reflection | ||
| resource | ||
| routing | ||
| scope | ||
| shims | ||
| sourcemaps | ||
| switch | ||
| testing | ||
| transform | ||
| translator | ||
| typecheck | ||
| util | ||
| program.ts | ||
| tsc_plugin.ts | ||