mirror of
https://github.com/angular/angular
synced 2026-05-24 09:28:37 +00:00
ee8b8f52aa
This change changes the priority order of static styling.
Current priority:
```
(least priority)
- Static
- Component
- Directives
- Template
- Dynamic Binding
- Component
- Map/Interpolation
- Property
- Directives
- Map/Interpolation
- Property
- Template
- Map/Interpolation
- Property
(highest priority)
```
The issue with the above priority is this use case:
```
<div style="color: red;" directive-which-sets-color-blue>
```
In the above case the directive will win and the resulting color will be `blue`. However a small change of adding interpolation to the example like so. (Style interpolation is coming in https://github.com/angular/angular/pull/34202)
```
<div style="color: red; width: {{exp}}px" directive-which-sets-color-blue>
```
Changes the priority from static binding to interpolated binding which means now the resulting color is `red`. It is very surprising that adding an unrelated interpolation and style can change the `color` which was not changed. To fix that we need to make sure that the static values are associated with priority of the source (directive or template) where they were declared. The new resulting priority is:
```
(least priority)
- Component
- Static
- Map/Interpolation
- Property
- Directives
- Static
- Map/Interpolation
- Property
- Template
- Static
- Map/Interpolation
- Property
(highest priority)
```
PR Close #34938
|
||
|---|---|---|
| .. | ||
| instructions | ||
| ivy | ||
| jit | ||
| perf | ||
| styling_next | ||
| util | ||
| basic_perf.ts | ||
| BUILD.bazel | ||
| change_detection_spec.ts | ||
| common_with_def.ts | ||
| component_ref_spec.ts | ||
| component_spec.ts | ||
| control_flow_spec.ts | ||
| di_spec.ts | ||
| domino.d.ts | ||
| global_utils_spec.ts | ||
| i18n_spec.ts | ||
| imported_renderer2.ts | ||
| instructions_spec.ts | ||
| integration_spec.ts | ||
| jit_environment_spec.ts | ||
| lifecycle_spec.ts | ||
| listeners_spec.ts | ||
| load_domino.ts | ||
| metadata_spec.ts | ||
| node_selector_matcher_spec.ts | ||
| outputs_spec.ts | ||
| perfCounter_spec.ts | ||
| pipe_spec.ts | ||
| providers_spec.ts | ||
| pure_function_spec.ts | ||
| query_spec.ts | ||
| render_util.ts | ||
| renderer_factory_spec.ts | ||
| testing_spec.ts | ||
| view_container_ref_spec.ts | ||
| view_utils_spec.ts | ||