mirror of
https://github.com/angular/angular
synced 2026-05-24 09:28:37 +00:00
75bb931889
This commit changes the reference emitters in the Ivy compiler to prefer non-aliased exports if they exist. This avoids selecting "private exports" that may not be stable, e.g. the reexports that have been added by the View Engine compiler. Such reexports are not stable and are therefore not suitable to be emitted into partial compilations, as the output of partial compilations should only reference stable symbols from upstream libraries. An alternative solution has been considered where ViewEngine-generated exports would gain a certain prefix, such that the Ivy compiler could just exclude those exports (see #41443). However, that solution would be insufficient in case a library is built using partial compilation and while depending itself on a VE-compiled library from earlier versions of Angular, where the magic prefix would be missing. For such libraries, ngcc would have generated reexports using the declared name if not already present so this change does result in choosing the correct export. Because ngcc always generates reexports using the declared name even if an aliased export is present, this change causes those ngcc-generated exports to be chosen in downstream libraries using partial compilation. This is unfortunate as it means that the declared names become effectively public even if the library author was intentionally exporting it using an alias. This commit does not address this problem; it is expected that this should not result in widespread issues across the library ecosystem. Fixes #41277 PR Close #41866 |
||
|---|---|---|
| .. | ||
| r3_compiler_compliance | ||
| r3_view_compiler | ||
| r3_view_compiler_bindings | ||
| r3_view_compiler_di/di | ||
| r3_view_compiler_directives/matching | ||
| r3_view_compiler_i18n | ||
| r3_view_compiler_input_outputs | ||
| r3_view_compiler_listener | ||
| r3_view_compiler_providers | ||
| r3_view_compiler_styling | ||
| r3_view_compiler_template | ||
| source_mapping | ||
| BUILD.bazel | ||
| list_golden_update_rules.ts | ||
| test_case_schema.json | ||