angular/packages/compiler-cli/ngcc/test
JoostK e4424863c2 fix(ngcc): fix compilation of ChangeDetectorRef in pipe constructors (#38892)
In #38666 we changed how ngcc deals with type expressions, where it
would now always emit the original type expression into the generated
code as a "local" type value reference instead of synthesizing new
imports using an "imported" type value reference. This was done as a fix
to properly deal with renamed symbols, however it turns out that the
compiler has special handling for certain imported symbols, e.g.
`ChangeDetectorRef` from `@angular/core`. The "local" type value
reference prevented this special logic from being hit, resulting in
incorrect compilation of pipe factories.

This commit fixes the issue by manually inspecting the import of the
type expression, in order to return an "imported" type value reference.
By manually inspecting the import we continue to handle renamed symbols.

Fixes #38883

PR Close #38892
2020-09-18 08:02:46 -07:00
..
analysis refactor(ngcc): let isWithinPackage operate on paths instead of source files (#37596) 2020-06-29 12:21:22 -07:00
dependencies refactor(ngcc): move logging code into ngtsc (#37114) 2020-06-22 13:38:47 -07:00
entry_point_finder perf(ngcc): use EntryPointManifest to speed up noop ProgramBaseEntryPointFinder (#37665) 2020-06-25 14:11:03 -07:00
execution fix(ngcc): ensure lockfile is removed when analyzeFn fails (#37739) 2020-06-29 10:29:11 -07:00
helpers perf(ngcc): introduce cache for sharing data across entry-points (#38840) 2020-09-15 11:23:04 -07:00
host fix(ngcc): fix compilation of ChangeDetectorRef in pipe constructors (#38892) 2020-09-18 08:02:46 -07:00
integration fix(ngcc): fix compilation of ChangeDetectorRef in pipe constructors (#38892) 2020-09-18 08:02:46 -07:00
locking refactor(ngcc): move logging code into ngtsc (#37114) 2020-06-22 13:38:47 -07:00
migrations refactor(ngcc): move logging code into ngtsc (#37114) 2020-06-22 13:38:47 -07:00
packages perf(ngcc): introduce cache for sharing data across entry-points (#38840) 2020-09-15 11:23:04 -07:00
rendering refactor(ngcc): move logging code into ngtsc (#37114) 2020-06-22 13:38:47 -07:00
writing perf(ngcc): introduce cache for sharing data across entry-points (#38840) 2020-09-15 11:23:04 -07:00
BUILD.bazel refactor(ngcc): move logging code into ngtsc (#37114) 2020-06-22 13:38:47 -07:00
ngcc_options_spec.ts perf(ngcc): reduce maximum worker count (#38840) 2020-09-15 11:23:09 -07:00
utils_spec.ts build: update license headers to reference Google LLC (#37205) 2020-05-26 14:26:58 -04:00